From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E435A3F6602; Tue, 17 Mar 2026 17:05:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773767152; cv=none; b=XAnzUrg9cB09lBUmRVMuSTeEoDJwNTzkN1lV1BRJPmtNcb++Wq4gxwapdETHAqrbdZ1BxrriIP37rEMhG2cFVV4zdnVN2Cr0s6vjTkgZsGNvDEQqEM3SswRTff5hHmF4+1ikOsCHdCp0EQqSGp8qNcZ3+jubmAHaiTLWmwzHBRQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773767152; c=relaxed/simple; bh=4jfGS/k5Wom/KHl4ER/ydkKfMhufOzFw9vFBaRb8tXs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pmaiaBuJfzN4rzEeghaFW8IswI2oFdyY07rEBG83H57NYlZIXKwm/5+jRxdlRum0ALr5TIdWBe9VmM/kX5yw8FtaUKPnG6R2hHc09Qm6JYK19KVAz17YvkJLW9iFG73Fp0goGpmGEkVmcQvSMn2RDYufnQsB7ArqwQe92+F81WE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=KS/dYsA8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="KS/dYsA8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A3D2C4CEF7; Tue, 17 Mar 2026 17:05:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1773767151; bh=4jfGS/k5Wom/KHl4ER/ydkKfMhufOzFw9vFBaRb8tXs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KS/dYsA8Dri/Aw+mhc0mvYKXlIvVZ1sd0iictQwn6KJuYxPN3sezv0xsNKbGtZWr0 +kWO8Ip0kAPeeSNiQIW3/2cJBBnjkTnbeQQsMnpdtcka6XD7AyJx3Bg2xoEhGCu1LM 8N2Omtc0vJec/vGMnoJ588ZHLhtxOG1FeJusR9qo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Guenter Roeck , ChenXiaoSong , Namjae Jeon , Steve French , Sasha Levin Subject: [PATCH 6.18 025/333] smb/server: Fix another refcount leak in smb2_open() Date: Tue, 17 Mar 2026 17:30:54 +0100 Message-ID: <20260317163000.294819264@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260317162959.345812316@linuxfoundation.org> References: <20260317162959.345812316@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Guenter Roeck [ Upstream commit c15e7c62feb3751cbdd458555819df1d70374890 ] If ksmbd_override_fsids() fails, we jump to err_out2. At that point, fp is NULL because it hasn't been assigned dh_info.fp yet, so ksmbd_fd_put(work, fp) will not be called. However, dh_info.fp was already inserted into the session file table by ksmbd_reopen_durable_fd(), so it will leak in the session file table until the session is closed. Move fp = dh_info.fp; ahead of the ksmbd_override_fsids() check to fix the problem. Found by an experimental AI code review agent at Google. Fixes: c8efcc786146a ("ksmbd: add support for durable handles v1/v2") Signed-off-by: Guenter Roeck Reviewed-by: ChenXiaoSong Acked-by: Namjae Jeon Signed-off-by: Steve French Signed-off-by: Sasha Levin --- fs/smb/server/smb2pdu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c index e52b9136abbff..37b14a2396147 100644 --- a/fs/smb/server/smb2pdu.c +++ b/fs/smb/server/smb2pdu.c @@ -3020,13 +3020,14 @@ int smb2_open(struct ksmbd_work *work) goto err_out2; } + fp = dh_info.fp; + if (ksmbd_override_fsids(work)) { rc = -ENOMEM; ksmbd_put_durable_fd(dh_info.fp); goto err_out2; } - fp = dh_info.fp; file_info = FILE_OPENED; rc = ksmbd_vfs_getattr(&fp->filp->f_path, &stat); -- 2.51.0