From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A8513F65EC; Tue, 17 Mar 2026 16:52:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773766338; cv=none; b=lzsNU+T5HJd/YmEhr/CPaz7MJksUdyPkdf9n50uPLtEJCQbZpVPjDZtEof0pUbsG8sRXM8nJzFIPCttcEU2ZvbY8sNVcgsFn0/i5p13oyAQMCHWWkWQzOGx+Ah7AfwSS9cc6zF6dB+XdyW1CiQAysEikdRsVsLA1FEjQ7jnG24A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773766338; c=relaxed/simple; bh=ighv4/k353IEb97lfeZYObamKNQc3S7O0KJUR+sWj7w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iwB8fh7tySLS5NbqJoJymTwfFUSZyTd/3Vrp7vL2cPHgK2I8XWzHSw5tYn7VV7v5JcSuqSLV/DFPrHCXf0D1fsBez6qfUoYw4yEmXPSn2WmJRx4r7gEFt9crXQwS//EjxOh9/unstm0RuRFCQj1nQIr38Twr9CrfM7m7Axg8fck= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=iLPsmIOl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="iLPsmIOl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8ECEAC4CEF7; Tue, 17 Mar 2026 16:52:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1773766338; bh=ighv4/k353IEb97lfeZYObamKNQc3S7O0KJUR+sWj7w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iLPsmIOluJAb4W9r3QiONcwFwwEQR+kaPLXrtXhhVP+saVSUlpEbDtu/ZNPDlE94F TBaIOTdomSHHQpLNbEfOq3BIktgRxGqfJwQw2wZydUUBthoj4lfpjPNY2Rq0Tq9CNV N1vZ3Tgla09C/bssEI5pP8mR8Lpt4ZLWmPElyBAE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Igor Raits , Corey Minyard Subject: [PATCH 6.19 222/378] ipmi:si: Use a long timeout when the BMC is misbehaving Date: Tue, 17 Mar 2026 17:32:59 +0100 Message-ID: <20260317163015.177486242@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260317163006.959177102@linuxfoundation.org> References: <20260317163006.959177102@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Corey Minyard commit c3bb3295637cc9bf514f690941ca9a385bf30113 upstream. If the driver goes into HOSED state, don't reset the timeout to the short timeout in the timeout handler. Reported-by: Igor Raits Closes: https://lore.kernel.org/linux-acpi/CAK8fFZ58fidGUCHi5WFX0uoTPzveUUDzT=k=AAm4yWo3bAuCFg@mail.gmail.com/ Fixes: bc3a9d217755 ("ipmi:si: Gracefully handle if the BMC is non-functional") Cc: stable@vger.kernel.org # 4.18 Signed-off-by: Corey Minyard Signed-off-by: Greg Kroah-Hartman --- drivers/char/ipmi/ipmi_si_intf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/char/ipmi/ipmi_si_intf.c +++ b/drivers/char/ipmi/ipmi_si_intf.c @@ -1113,7 +1113,9 @@ static void smi_timeout(struct timer_lis * SI_USEC_PER_JIFFY); smi_result = smi_event_handler(smi_info, time_diff); - if ((smi_info->io.irq) && (!smi_info->interrupt_disabled)) { + if (smi_info->si_state == SI_HOSED) { + timeout = jiffies + SI_TIMEOUT_HOSED; + } else if ((smi_info->io.irq) && (!smi_info->interrupt_disabled)) { /* Running with interrupts, only do long timeouts. */ timeout = jiffies + SI_TIMEOUT_JIFFIES; smi_inc_stat(smi_info, long_timeouts);