From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E91A8346AC6; Tue, 17 Mar 2026 16:59:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773766796; cv=none; b=kvS5N6RccVBcvEFWi48yqqC4H6kgE/jPvrNVusC9uhOjDLDP2hc2OhYIMph4n3qEcQXXfE22UpxxYvgo1FII2Bb3vWIop1CUAjtu1tDCCOm7Uy0iVb5+QgBgxoX8x0UPl9FHB/X8GUzCg+GdTmoPzF8bz7LllX/MicIpOlFPRuA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773766796; c=relaxed/simple; bh=ksJ1dSLuAb57S/1TdgHuJ+lBSMdcRr0WtsZ5oeSyrNM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EJMf/OmI8bLtUqHTMm42G4yu3NmaMdbr+YVkyQ3hdbPleSKfFHOvLO0se2N7O9GkID/cnxYD+AD49ioGVEuAYerV6pvYPabfoBbwrT3DL4J2L8gCq8+0TeAbrQufSJWuzIhMrLkzlBxbOKvM4KyMNVreqCoZRq9SpV5pfUdHgZg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=yllIesek; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="yllIesek" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61E73C4CEF7; Tue, 17 Mar 2026 16:59:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1773766795; bh=ksJ1dSLuAb57S/1TdgHuJ+lBSMdcRr0WtsZ5oeSyrNM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yllIeseklLNYSB/jXFB6fTTmVJ2iEp8KTh3J/z8q6n2FYXsI7drpqQe+QHpdOC5EC 7CzE9r5w6q/QXHJ6N0uJFIehvRShLBkudDsjBJEtAkatEo2PW1wGKrqsW0FFmSl8s7 RLgNqWSQ4UO6g9sb3HZRI7ly5rLU2HLV1L/szXfQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Andrea Righi , Tejun Heo Subject: [PATCH 6.19 323/378] sched_ext: Fix enqueue_task_scx() truncation of upper enqueue flags Date: Tue, 17 Mar 2026 17:34:40 +0100 Message-ID: <20260317163018.873680538@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260317163006.959177102@linuxfoundation.org> References: <20260317163006.959177102@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tejun Heo commit 57ccf5ccdc56954f2a91a7f66684fd31c566bde5 upstream. enqueue_task_scx() takes int enq_flags from the sched_class interface. SCX enqueue flags starting at bit 32 (SCX_ENQ_PREEMPT and above) are silently truncated when passed through activate_task(). extra_enq_flags was added as a workaround - storing high bits in rq->scx.extra_enq_flags and OR-ing them back in enqueue_task_scx(). However, the OR target is still the int parameter, so the high bits are lost anyway. The current impact is limited as the only affected flag is SCX_ENQ_PREEMPT which is informational to the BPF scheduler - its loss means the scheduler doesn't know about preemption but doesn't cause incorrect behavior. Fix by renaming the int parameter to core_enq_flags and introducing a u64 enq_flags local that merges both sources. All downstream functions already take u64 enq_flags. Fixes: f0e1a0643a59 ("sched_ext: Implement BPF extensible scheduler class") Cc: stable@vger.kernel.org # v6.12+ Acked-by: Andrea Righi Signed-off-by: Tejun Heo Signed-off-by: Greg Kroah-Hartman --- kernel/sched/ext.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) --- a/kernel/sched/ext.c +++ b/kernel/sched/ext.c @@ -1464,16 +1464,15 @@ static void clr_task_runnable(struct tas p->scx.flags |= SCX_TASK_RESET_RUNNABLE_AT; } -static void enqueue_task_scx(struct rq *rq, struct task_struct *p, int enq_flags) +static void enqueue_task_scx(struct rq *rq, struct task_struct *p, int core_enq_flags) { struct scx_sched *sch = scx_root; int sticky_cpu = p->scx.sticky_cpu; + u64 enq_flags = core_enq_flags | rq->scx.extra_enq_flags; if (enq_flags & ENQUEUE_WAKEUP) rq->scx.flags |= SCX_RQ_IN_WAKEUP; - enq_flags |= rq->scx.extra_enq_flags; - if (sticky_cpu >= 0) p->scx.sticky_cpu = -1;