From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BACC2EF67A for ; Tue, 17 Mar 2026 17:20:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773768000; cv=none; b=ceumGcNmR2MJGd5AmjHM7REaDirodtrxXG85UxtcDhg5mV7B05TeVgktSUJ7iUrGqi48nWFItMidozxzAo3eDMd3BivdfT+8fMPZbOeEAJN1JJJncGY4tGDD89j25swsf7e5MGI6LuHNy11dTbtxfFTG1+VbWov3aGMGOfeP0Jo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773768000; c=relaxed/simple; bh=kITr4AKHtuCYSviSuxg0M5Wv6rjK+UL0kTB3V33AeJs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OQPZZoyTG+1XMMlDvRkwiR4/oPDcJv0L/ANRh6Slyq2JHQZXoGG8Vrka3IM97r8IO+VYyyaAI3BXbKVaQcopageKN6t9z/5Ung4iBoqvQIfWRlqn40Wj6cz/AujJX1JUfi8Th8XbyN+oVHpvScydjIkFYj0nfKabNd45jiczkHA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SvPYHj7R; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SvPYHj7R" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74531C2BCB0; Tue, 17 Mar 2026 17:19:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773768000; bh=kITr4AKHtuCYSviSuxg0M5Wv6rjK+UL0kTB3V33AeJs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SvPYHj7R5irsOaRa1rW3AE/ldOnzwJ1zdc7+x0fqjnIpJsHKI0ssr0v/GPNr3pWev 8XPF0g6/+3exCVUdTar3wmE+bZ50v0NLDhN9QWFjP8PPiuZxU32rGOdJFAHpM0T83v A0zycmWxutH4xn1AWC8LN2bd2OHo06j5A66Hm5CZrSzh67QES9OJ/cS48r6vTIQpDM 4IN0DscTo7rF2EPA2SAQR1nzzwVMLngboODELX4p2pcYW0LfpCMfFr8GoeFkF7siJ7 xHNWtctty0sAaY9c5HEjMDVAJJxC8WJPKTA33bQUAE7o1IQb3sElBJKgjDdTeWDeTC MwKoPbGKWM+dA== From: Sasha Levin To: stable@vger.kernel.org Cc: Andy Shevchenko , "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 5.10.y 4/8] device property: Unify access to of_node Date: Tue, 17 Mar 2026 13:19:50 -0400 Message-ID: <20260317171954.238398-4-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260317171954.238398-1-sashal@kernel.org> References: <2026031703-caravan-bladder-c63a@gregkh> <20260317171954.238398-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Andy Shevchenko [ Upstream commit fb38f314fbd173e2e9f9f0f2e720a5f4889562da ] Historically we have a few variants how we access dev->fwnode and dev->of_node. Some of the functions during development gained different versions of the getters. Unify access to of_node and as a side change slightly refactor ACPI specific branches. Signed-off-by: Andy Shevchenko Signed-off-by: Rafael J. Wysocki Stable-dep-of: 2692c614f8f0 ("device property: Allow secondary lookup in fwnode_get_next_child_node()") Signed-off-by: Sasha Levin --- drivers/base/property.c | 29 +++++++++++++---------------- include/linux/property.h | 2 +- 2 files changed, 14 insertions(+), 17 deletions(-) diff --git a/drivers/base/property.c b/drivers/base/property.c index f8d9b9056d9c7..40968fd9c8d14 100644 --- a/drivers/base/property.c +++ b/drivers/base/property.c @@ -759,13 +759,8 @@ EXPORT_SYMBOL_GPL(fwnode_get_next_available_child_node); struct fwnode_handle *device_get_next_child_node(struct device *dev, struct fwnode_handle *child) { - struct acpi_device *adev = ACPI_COMPANION(dev); - struct fwnode_handle *fwnode = NULL, *next; - - if (dev->of_node) - fwnode = of_fwnode_handle(dev->of_node); - else if (adev) - fwnode = acpi_fwnode_handle(adev); + const struct fwnode_handle *fwnode = dev_fwnode(dev); + struct fwnode_handle *next; /* Try to find a child in primary fwnode */ next = fwnode_get_next_child_node(fwnode, child); @@ -868,28 +863,31 @@ EXPORT_SYMBOL_GPL(device_get_child_node_count); bool device_dma_supported(struct device *dev) { + const struct fwnode_handle *fwnode = dev_fwnode(dev); + /* For DT, this is always supported. * For ACPI, this depends on CCA, which * is determined by the acpi_dma_supported(). */ - if (IS_ENABLED(CONFIG_OF) && dev->of_node) + if (is_of_node(fwnode)) return true; - return acpi_dma_supported(ACPI_COMPANION(dev)); + return acpi_dma_supported(to_acpi_device_node(fwnode)); } EXPORT_SYMBOL_GPL(device_dma_supported); enum dev_dma_attr device_get_dma_attr(struct device *dev) { + const struct fwnode_handle *fwnode = dev_fwnode(dev); enum dev_dma_attr attr = DEV_DMA_NOT_SUPPORTED; - if (IS_ENABLED(CONFIG_OF) && dev->of_node) { - if (of_dma_is_coherent(dev->of_node)) + if (is_of_node(fwnode)) { + if (of_dma_is_coherent(to_of_node(fwnode))) attr = DEV_DMA_COHERENT; else attr = DEV_DMA_NON_COHERENT; } else - attr = acpi_get_dma_attr(ACPI_COMPANION(dev)); + attr = acpi_get_dma_attr(to_acpi_device_node(fwnode)); return attr; } @@ -1007,14 +1005,13 @@ EXPORT_SYMBOL(device_get_mac_address); * Returns Linux IRQ number on success. Other values are determined * accordingly to acpi_/of_ irq_get() operation. */ -int fwnode_irq_get(struct fwnode_handle *fwnode, unsigned int index) +int fwnode_irq_get(const struct fwnode_handle *fwnode, unsigned int index) { - struct device_node *of_node = to_of_node(fwnode); struct resource res; int ret; - if (IS_ENABLED(CONFIG_OF) && of_node) - return of_irq_get(of_node, index); + if (is_of_node(fwnode)) + return of_irq_get(to_of_node(fwnode), index); ret = acpi_irq_get(ACPI_HANDLE_FWNODE(fwnode), index, &res); if (ret) diff --git a/include/linux/property.h b/include/linux/property.h index 3c2031c2c3034..0604bb73e6282 100644 --- a/include/linux/property.h +++ b/include/linux/property.h @@ -119,7 +119,7 @@ struct fwnode_handle *device_get_named_child_node(struct device *dev, struct fwnode_handle *fwnode_handle_get(struct fwnode_handle *fwnode); void fwnode_handle_put(struct fwnode_handle *fwnode); -int fwnode_irq_get(struct fwnode_handle *fwnode, unsigned int index); +int fwnode_irq_get(const struct fwnode_handle *fwnode, unsigned int index); unsigned int device_get_child_node_count(struct device *dev); -- 2.51.0