From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 039333DE447 for ; Wed, 18 Mar 2026 14:59:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773845990; cv=none; b=PMRKJptLBc0sijWlkvU8iLEp93xbXEi4c4mAKQX7YkPb3Ap1uCMXRN0xvMe8BAHBmH8IhOM0Ahs/FzFIwg4qWfIzUeyEjC3xxr3sbdH5utAQmnCAOoTGMmxoPIVHLVFe0Jdxph2Eurgwo5L27y+mGcW7rwqqZ5PwrJMjnyVe9yE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773845990; c=relaxed/simple; bh=3/32bOj6ZC5aJdwCpvzLBVZO+irId8q0lUAMvM04gu8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=siXowK4yjnWAHNaddG39MOKioNILDylv4tNgTaWcvslwOFF5JRz6sgH4MdJZerVv0MeDj9mFraqN8A13MYmtAGp8Q6Kbto5oJUBcsYxjuJyLSDMYffzwzfvd+yinDQhXO8oA6hqz8JcDIIHTQOwTWPdI3Pq3Efk+WsLbxYA1zp0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FMik18yW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FMik18yW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9560C2BCAF; Wed, 18 Mar 2026 14:59:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773845989; bh=3/32bOj6ZC5aJdwCpvzLBVZO+irId8q0lUAMvM04gu8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FMik18yWe9njrwF0o+WuOMuMvYkCTJ0OUtMCNtB4AGodqwhRnTrWb7ULIhIKqmpYc 6QFDlUBx+7QJUR+Smlu4LcckINmyRSpjDhygqa6/mBdbF+V+x15qWwEk3WiYntpyCg o9RAQu/1SaZ/em+nw+QVrziooIhw9sfWbUgjIjZEqJ0nvfwKOk3S/kB7wX2mDKUlhC ykm1KkS1Jm0FKC5hGc8DaubY/NeQeb86YkwbJFl4FpZQlpfRrqc7bV2ufKmyl1YtRg +WAZF9Qw9pXwpsipZIMZAsQxZHYwUAvJ2vLYbqDZGp8ISE2HXEUoUoBLd2cEBDoePZ Ni3lPJjrRyZ3w== From: Sasha Levin To: stable@vger.kernel.org Cc: Thorsten Blum , Namjae Jeon , Steve French , Sasha Levin Subject: [PATCH 5.15.y] ksmbd: Don't log keys in SMB3 signing and encryption key generation Date: Wed, 18 Mar 2026 10:59:47 -0400 Message-ID: <20260318145947.858748-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <2026031719-unranked-wrongdoer-d47a@gregkh> References: <2026031719-unranked-wrongdoer-d47a@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Thorsten Blum [ Upstream commit 441336115df26b966575de56daf7107ed474faed ] When KSMBD_DEBUG_AUTH logging is enabled, generate_smb3signingkey() and generate_smb3encryptionkey() log the session, signing, encryption, and decryption key bytes. Remove the logs to avoid exposing credentials. Fixes: e2f34481b24d ("cifsd: add server-side procedures for SMB3") Cc: stable@vger.kernel.org Signed-off-by: Thorsten Blum Acked-by: Namjae Jeon Signed-off-by: Steve French [ Context ] Signed-off-by: Sasha Levin --- fs/ksmbd/auth.c | 22 ++-------------------- 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/fs/ksmbd/auth.c b/fs/ksmbd/auth.c index 647692ca78a28..63c631fd2f2eb 100644 --- a/fs/ksmbd/auth.c +++ b/fs/ksmbd/auth.c @@ -783,12 +783,8 @@ static int generate_smb3signingkey(struct ksmbd_session *sess, if (!(conn->dialect >= SMB30_PROT_ID && signing->binding)) memcpy(chann->smb3signingkey, key, SMB3_SIGN_KEY_SIZE); - ksmbd_debug(AUTH, "dumping generated AES signing keys\n"); + ksmbd_debug(AUTH, "generated SMB3 signing key\n"); ksmbd_debug(AUTH, "Session Id %llu\n", sess->id); - ksmbd_debug(AUTH, "Session Key %*ph\n", - SMB2_NTLMV2_SESSKEY_SIZE, sess->sess_key); - ksmbd_debug(AUTH, "Signing Key %*ph\n", - SMB3_SIGN_KEY_SIZE, key); return 0; } @@ -852,23 +848,9 @@ static int generate_smb3encryptionkey(struct ksmbd_conn *conn, if (rc) return rc; - ksmbd_debug(AUTH, "dumping generated AES encryption keys\n"); + ksmbd_debug(AUTH, "generated SMB3 encryption/decryption keys\n"); ksmbd_debug(AUTH, "Cipher type %d\n", conn->cipher_type); ksmbd_debug(AUTH, "Session Id %llu\n", sess->id); - ksmbd_debug(AUTH, "Session Key %*ph\n", - SMB2_NTLMV2_SESSKEY_SIZE, sess->sess_key); - if (conn->cipher_type == SMB2_ENCRYPTION_AES256_CCM || - conn->cipher_type == SMB2_ENCRYPTION_AES256_GCM) { - ksmbd_debug(AUTH, "ServerIn Key %*ph\n", - SMB3_GCM256_CRYPTKEY_SIZE, sess->smb3encryptionkey); - ksmbd_debug(AUTH, "ServerOut Key %*ph\n", - SMB3_GCM256_CRYPTKEY_SIZE, sess->smb3decryptionkey); - } else { - ksmbd_debug(AUTH, "ServerIn Key %*ph\n", - SMB3_GCM128_CRYPTKEY_SIZE, sess->smb3encryptionkey); - ksmbd_debug(AUTH, "ServerOut Key %*ph\n", - SMB3_GCM128_CRYPTKEY_SIZE, sess->smb3decryptionkey); - } return 0; } -- 2.51.0