From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8900E34107A for ; Wed, 18 Mar 2026 20:41:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773866504; cv=none; b=UQ37zZIaIfZ9KmllbMCTwTIrHPACP6AB/U1MvBgV+jBVk0p4ekWRJr5b8aVzE3O97C/xvlf2wnrTZwnsqENmx+PS4ZUDRcDgPdDTM40eB9w7c00O010ZKQNpE8IEPmecQdY29Gkd6eHkMRXEvyFtAg2Jh35zgXi0NQFQKNINSdU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773866504; c=relaxed/simple; bh=yrdIZaku+ltjPzr5+mmCP5tWE1r2lTt1ZmS6vhPlXM8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qgBdXbVxHhw+z7IcC+7oqkwzDqI9jmBucFP285grQU4oBYJfd1hPlgUWvRQq10+d70JeAcB5YkkF74CWy+3w5RHcyDIw22tNpyP49KLEIWSr+uVAw51gwSoPlxabxZfI2S4Fl2YofOA61FSwVdMOiPa9FU9CSIqHgsKD7ZpIgh0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BNb7iMnb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BNb7iMnb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7A531C19421; Wed, 18 Mar 2026 20:41:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773866504; bh=yrdIZaku+ltjPzr5+mmCP5tWE1r2lTt1ZmS6vhPlXM8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BNb7iMnbcAL6xy7gFadC9pR6VIog560K/o1/Llv392R4gxpY+a2uyZVCT/KGXZjJK HOrsZ0exhdcTTBEpAe0TUu50S1V46C2nMgqAI2wiLj6KKILYga/AD4MPQL1esaQK/H s05aed2hRa1ShyT6bBOqEqTECrcjD1JYZ+v7rw7fjI3lcwxVt15JahXkNutLskc8QU Eu8ACv41ig+E3cCB6Orwh8dZNPHMS2V5Cr7Ww283AeGPcLB8XHHCXPaf3USvhMfDSw eIasbvTGC14Ty6SXrYsGTvvo9xAoVXDwldUKmzBK6bTvlTE27UDVXTCzXloBIq1Yyi Lqy0TZ6jd7cjw== From: Sasha Levin To: stable@vger.kernel.org Cc: Varun Gupta , Shuicheng Lin , Matthew Brost , Tejas Upadhyay , Rodrigo Vivi , Sasha Levin Subject: [PATCH 6.19.y] drm/xe: Fix memory leak in xe_vm_madvise_ioctl Date: Wed, 18 Mar 2026 16:41:41 -0400 Message-ID: <20260318204141.1139130-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <2026031742-pull-husband-3953@gregkh> References: <2026031742-pull-husband-3953@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Varun Gupta [ Upstream commit 0cfe9c4838f1147713f6b5c02094cd4dc0c598fa ] When check_bo_args_are_sane() validation fails, jump to the new free_vmas cleanup label to properly free the allocated resources. This ensures proper cleanup in this error path. Fixes: 293032eec4ba ("drm/xe/bo: Update atomic_access attribute on madvise") Cc: stable@vger.kernel.org # v6.18+ Reviewed-by: Shuicheng Lin Signed-off-by: Varun Gupta Reviewed-by: Matthew Brost Link: https://patch.msgid.link/20260223175145.1532801-1-varun.gupta@intel.com Signed-off-by: Tejas Upadhyay (cherry picked from commit 29bd06faf727a4b76663e4be0f7d770e2d2a7965) Signed-off-by: Rodrigo Vivi [ changed old goto target from `madv_fini` to `unlock_vm` ] Signed-off-by: Sasha Levin --- drivers/gpu/drm/xe/xe_vm_madvise.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xe/xe_vm_madvise.c b/drivers/gpu/drm/xe/xe_vm_madvise.c index fe7e1b45f5c0c..9dc801f657129 100644 --- a/drivers/gpu/drm/xe/xe_vm_madvise.c +++ b/drivers/gpu/drm/xe/xe_vm_madvise.c @@ -390,7 +390,7 @@ int xe_vm_madvise_ioctl(struct drm_device *dev, void *data, struct drm_file *fil madvise_range.num_vmas, args->atomic.val)) { err = -EINVAL; - goto unlock_vm; + goto free_vmas; } } @@ -426,6 +426,7 @@ int xe_vm_madvise_ioctl(struct drm_device *dev, void *data, struct drm_file *fil err_fini: if (madvise_range.has_bo_vmas) drm_exec_fini(&exec); +free_vmas: kfree(madvise_range.vmas); madvise_range.vmas = NULL; unlock_vm: -- 2.51.0