From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0266E284693 for ; Thu, 19 Mar 2026 14:35:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773930945; cv=none; b=jW2lDMvPXYs8uVf9xhuU/DIGgAjsMJM6YZOBBSAGJCElsNFQnJCjMaNiAWB27Bn9pk7M/o4V2e1FBxBDDTp0DotGcGxQmleFuXSrY/ky5K6Z9KHpVp4OT7E/3aoAMzUj/Dj5lg06q1X/UmXMw0c5gJnkmI9uj6ZcOJ7QQjtO34w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773930945; c=relaxed/simple; bh=uLnXtIaLEaryzqEolHOs3gNwJifTJXlDl/iFjMOoN18=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GWrueT/Rl88+5XUlLxchR1nmtCFCVubDLQ/YLoSM2TXGGSuU8i3HJ7nhIFZmWxfvPBfqglw+Xz+KrMg9dpoFkxWXqMiEu/BEe33kfHsJHNIJVUbWDi00kcZJ3v92jXi8enwuYoFbHWtQg/VtQuT/CnRSrL/mPovZt1EMfZOlhtc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=zteub98z; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="zteub98z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D90FC19424; Thu, 19 Mar 2026 14:35:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1773930944; bh=uLnXtIaLEaryzqEolHOs3gNwJifTJXlDl/iFjMOoN18=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zteub98z8royI9OAqvNMRyiwGJi0mbQG+ZC2SgfmCkPTApbGAGt1DC1panx/32G0a 3NHK0iVziXZnOBHgx4GhJPTwfmgz9JWcVvNpvfBUN5Sp3W191/SDJHNVRUypIKhHAX Tot1pBRxAauhs4gw1BWf0x+Qa4dgdgUZTsjthrSo= Date: Thu, 19 Mar 2026 15:35:40 +0100 From: Greg KH To: vsntk18@gmail.com Cc: stable@vger.kernel.org, baolu.lu@linux.intel.com, black.hawk@163.com, jgg@nvidia.com, joro@8bytes.org, Vasant Karasulli Subject: Re: [PATCH 5.15-stable] iommu: fix a reference count leak in iommu_sva_bind_device() Message-ID: <2026031901-supreme-laptop-72f2@gregkh> References: <20260319142544.23049-1-vsntk18@gmail.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260319142544.23049-1-vsntk18@gmail.com> On Thu, Mar 19, 2026 at 03:25:44PM +0100, vsntk18@gmail.com wrote: > From: Vasant Karasulli > > From: Vasant Karasulli Two from lines? > > commit b34289505180 ("iommu: disable SVA when CONFIG_X86 is set") > disables SVA to mitigate a security vulnerability. Trailing whitespace :( > > Due the current placement of the condition check, > function returns after iommu_group_get() without a corresponding > iommu_group_put(). So move the condition check above. > > This is a stable-only fix applicable to linux-5.15.y. > > Fixes: b34289505("iommu: disable SVA when CONFIG_X86 is set") This needs an extra space, and the proper number of digits > > Signed-off-by: Vasant Karasulli No blank line between the two. thanks, greg k-h