From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B5FC3C2796 for ; Thu, 19 Mar 2026 11:40:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773920409; cv=none; b=ipeCe9fqm+5JiXAwshJ47eiiKf6ulryxssYnJxJNBgZ32EsYM5qXEXFGs5Wwu5dfE6UefoI+3p1IYbmT5Yu5DZ+HSnmtYR6zkVEIhzrtGGWleYq83QrIycQ7ngAH5EVl8kUFTa79kLGjPcfrZMfCr08bNC3tmLIRH9mHxi3OoT4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773920409; c=relaxed/simple; bh=qIkLNR7+ZeHfeqFPzxIPCfzS+ttK2D0PbrApFdChGkI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XAdJOrLCS2/MxzwzlwOj0cvvI/HRx7/2FLalcf1xcZzrJ+RxomMqbB3XZJX0iextsW5tU6UiYNsJIgWDTu6A/EBhzprh0ld0uTtWjgvWqAss+2JaqUY1vV2BSw9kyrR6hTnPN8wzrtOQ/pO5+AaPlG7FqevHXLW7VxIKERWt1po= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dTsSlivE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dTsSlivE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6DA01C19424; Thu, 19 Mar 2026 11:40:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773920409; bh=qIkLNR7+ZeHfeqFPzxIPCfzS+ttK2D0PbrApFdChGkI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dTsSlivEVoEq0kLeC1INKxxtS/0T07V+ceuXBAMEwwwU6dsFVhXctVvK3IGwm9W+o 2gGYpmYFHQp/beS9Or+TGctcgP6owb0AipLETtmfGmmFbXNfq5/j8Nhj5Fbi+CVb92 uzYzbVD9rzcf10E7r84GNxs7gUl+YEqCecc7Wq7ZK1zre6BfTXtoIaFOPysADHS28J KffED7pr2yxvWUdFN2nsO/2dVjDQ1Qoj5osCOJh+ButCNFzm3CGQ7fKfwnhbHkIG1M gKaP0YuXKOpZRS84aGA2S9KuqNbznDBMb42JtQcYAht2b4kgkhzb48rrx1bhAAG81C MYai+GuoHvNQw== From: Sasha Levin To: stable@vger.kernel.org Cc: Long Li , "Darrick J. Wong" , Carlos Maiolino , Sasha Levin Subject: [PATCH 5.10.y] xfs: fix integer overflow in bmap intent sort comparator Date: Thu, 19 Mar 2026 07:40:07 -0400 Message-ID: <20260319114007.2348969-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <2026031715-deepen-kabob-15c4@gregkh> References: <2026031715-deepen-kabob-15c4@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Long Li [ Upstream commit 362c490980867930a098b99f421268fbd7ca05fd ] xfs_bmap_update_diff_items() sorts bmap intents by inode number using a subtraction of two xfs_ino_t (uint64_t) values, with the result truncated to int. This is incorrect when two inode numbers differ by more than INT_MAX (2^31 - 1), which is entirely possible on large XFS filesystems. Fix this by replacing the subtraction with cmp_int(). Cc: # v4.9 Fixes: 9f3afb57d5f1 ("xfs: implement deferred bmbt map/unmap operations") Signed-off-by: Long Li Reviewed-by: Darrick J. Wong Signed-off-by: Carlos Maiolino [ replaced `bi_entry()` macro with `container_of()` and inlined `cmp_int()` as a manual three-way comparison expression ] Signed-off-by: Sasha Levin --- fs/xfs/xfs_bmap_item.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/xfs/xfs_bmap_item.c b/fs/xfs/xfs_bmap_item.c index 984bb480f1774..a3b350437db26 100644 --- a/fs/xfs/xfs_bmap_item.c +++ b/fs/xfs/xfs_bmap_item.c @@ -273,7 +273,8 @@ xfs_bmap_update_diff_items( ba = container_of(a, struct xfs_bmap_intent, bi_list); bb = container_of(b, struct xfs_bmap_intent, bi_list); - return ba->bi_owner->i_ino - bb->bi_owner->i_ino; + return (ba->bi_owner->i_ino > bb->bi_owner->i_ino) - + (ba->bi_owner->i_ino < bb->bi_owner->i_ino); } /* Set the map extent flags for this mapping. */ -- 2.51.0