From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EBF633F589 for ; Thu, 19 Mar 2026 11:50:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773921003; cv=none; b=Ls2qerPPP7ODHZTaxsbdzyVwWCEGQq0YEzWXC7y0nQaBNDoeO3yMGRJ8pLWIHXYUCWaBsjtLWKnhpf0bwZ7OGvcnMM7cwIlJzZlhXhydakdzh2R+x3Av8HNp3lx2gWOEnzWieGqnu62NlSvgIwPBbtL9zt3MfLtg+G+Zt5aZhJQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773921003; c=relaxed/simple; bh=tao9E4zUamd0RQZi1p+9aRvb8M31GMtYQidEw662Vd0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=M3yKa+YrRGIQIgbvF+acBRBZYpl5OITDwVUB2sN+MrD50p1vPr9iZ0ns90txWoNNXm75YABndKaGFf3SZC5DnZ5mhfHHabazSUUN5gfwz/0xK/IR1CKETbMO3r466zw+xTToclQhPH+vEB0flEzzZSjLMLvSUG08qGXAjABOd8g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IX2FFqT1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IX2FFqT1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C83AC19424; Thu, 19 Mar 2026 11:50:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773921003; bh=tao9E4zUamd0RQZi1p+9aRvb8M31GMtYQidEw662Vd0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IX2FFqT1OVNvL2SPV7JvU7AxEUyJa02lcs2Iwprfdim79SnOxH9XkJLTyp1nBOmSt d/4/rYBbvf4intvTdvQYJYP/xLC7dqMrgh7erbTfgxxN2UEh4FCSL5Aj1uFdyznsCA XgLHVvVscznUBWO6XMNrOC//tJt0LFJHxIm1yQO5Ed1AgIEErJdQLNFIv/ncZ6qc4x PjcxpW9rRGho4tMIc7he4Udzff3iNj7wBnK+RpuIEZ6RfWsHVov2PvQat8P8FbQDHI H4Rlk/aYazXvD4LS7ITVd1amGVlvuMJoardhzq2ZnsLq/3UWH84bxh+tsXOqAsECPp yc5KTbk7MIkow== From: Sasha Levin To: stable@vger.kernel.org Cc: Harald Freudenberger , Ingo Franzki , Vasily Gorbik , Sasha Levin Subject: [PATCH 5.10.y] s390/zcrypt: Enable AUTOSEL_DOM for CCA serialnr sysfs attribute Date: Thu, 19 Mar 2026 07:50:01 -0400 Message-ID: <20260319115001.2359762-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <2026031714-unsent-plausibly-e43b@gregkh> References: <2026031714-unsent-plausibly-e43b@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Harald Freudenberger [ Upstream commit 598bbefa8032cc58b564a81d1ad68bd815c8dc0f ] The serialnr sysfs attribute for CCA cards when queried always used the default domain for sending the request down to the card. If for any reason exactly this default domain is disabled then the attribute code fails to retrieve the CCA info and the sysfs entry shows an empty string. Works as designed but the serial number is a card attribute and thus it does not matter which domain is used for the query. So if there are other domains on this card available, these could be used. So extend the code to use AUTOSEL_DOM for the domain value to address any online domain within the card for querying the cca info and thus show the serialnr as long as there is one domain usable regardless of the default domain setting. Fixes: 8f291ebf3270 ("s390/zcrypt: enable card/domain autoselect on ep11 cprbs") Suggested-by: Ingo Franzki Signed-off-by: Harald Freudenberger Reviewed-by: Ingo Franzki Cc: stable@vger.kernel.org Signed-off-by: Vasily Gorbik [ preserved zc->online as the fourth argument to cca_get_info() ] Signed-off-by: Sasha Levin --- drivers/s390/crypto/zcrypt_ccamisc.c | 12 +++++++----- drivers/s390/crypto/zcrypt_cex4.c | 3 +-- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/s390/crypto/zcrypt_ccamisc.c b/drivers/s390/crypto/zcrypt_ccamisc.c index ffab935ddd95b..d8046e589742a 100644 --- a/drivers/s390/crypto/zcrypt_ccamisc.c +++ b/drivers/s390/crypto/zcrypt_ccamisc.c @@ -1680,11 +1680,13 @@ static int fetch_cca_info(u16 cardnr, u16 domain, struct cca_info *ci) memset(ci, 0, sizeof(*ci)); - /* get first info from zcrypt device driver about this apqn */ - rc = zcrypt_device_status_ext(cardnr, domain, &devstat); - if (rc) - return rc; - ci->hwtype = devstat.hwtype; + /* if specific domain given, fetch status and hw info for this apqn */ + if (domain != AUTOSEL_DOM) { + rc = zcrypt_device_status_ext(cardnr, domain, &devstat); + if (rc) + return rc; + ci->hwtype = devstat.hwtype; + } /* prep page for rule array and var array use */ pg = (u8 *) __get_free_page(GFP_KERNEL); diff --git a/drivers/s390/crypto/zcrypt_cex4.c b/drivers/s390/crypto/zcrypt_cex4.c index f5195bca1d856..20e17dc61530f 100644 --- a/drivers/s390/crypto/zcrypt_cex4.c +++ b/drivers/s390/crypto/zcrypt_cex4.c @@ -84,8 +84,7 @@ static ssize_t cca_serialnr_show(struct device *dev, memset(&ci, 0, sizeof(ci)); - if (ap_domain_index >= 0) - cca_get_info(ac->id, ap_domain_index, &ci, zc->online); + cca_get_info(ac->id, AUTOSEL_DOM, &ci, zc->online); return scnprintf(buf, PAGE_SIZE, "%s\n", ci.serial); } -- 2.51.0