From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14E8738550C for ; Thu, 19 Mar 2026 16:06:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773936384; cv=none; b=sLtHTVv2aRx9qXdJz7JLcsFSww0TDsDFbX5M3NI6ezbdo236rUrM218hFf48karJx/f1fnx3LBVxCLYnHOLDjTFntdoZ5dThwxGI9vBUZFo6wvADAFlMD70qGsagDk+4VTrBaSM4T+Lm8ZgVoxd8P8nTvKuLlabr/df1zlrsQrM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773936384; c=relaxed/simple; bh=tsKPTjh/u3DOsVmmEk37G0rapNW8pZqOoBS2apK8Ofg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eQcJ8/qnENNSMrNfLIDUdkm5tOhXlu2yM6Al8nmTAtlKo18hDO+Ip0P12FBgH5JCC/gRGX4PROQLUzgOFVpHM/0RwST55w94Ku9kpB2Q+0x97iVhRW1mmuk2QAqjYcErsSJbp/92S90hiuecNZt5yuXEbCQy3hFNEK2YHfieqH8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cdGF/nMw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cdGF/nMw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 100BEC19424; Thu, 19 Mar 2026 16:06:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773936383; bh=tsKPTjh/u3DOsVmmEk37G0rapNW8pZqOoBS2apK8Ofg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cdGF/nMw8roYwMgeHYfu0ELpvjv/KRlOOQsfameCsus/YRvsbHpmd4H65/LCrycr9 XJbEa7c2pyNTbwtHNM8RCNL32HbO6PioVTOyi0GgX0XI+CgWCQMLKSNOE56gLMxSbX KN8lEgpbXfyztZ8Ab1y5HiZfflmKTGGdgYdODXZQklozn5HQwZ6h6grezB3wIoftYo bzwJ9Nkq7qZp5aEKloG3TtwgzobHUQ2VKqAz49mje4JpI0hIyCaduja0qQmbvIbQWd VTQgBGA9vrM44GBw+lKLUHglULykRXaTodoL/SiBjpH8ZFn93vcdZkuFiBzYh8Uz9n 0gvxvMr2kqc/Q== From: Sasha Levin To: stable@vger.kernel.org Cc: Henrique Carvalho , "Dr. Thomas Orgis" , Enzo Matsumiya , Steve French , Sasha Levin Subject: [PATCH 5.10.y] smb: client: fix iface port assignment in parse_server_interfaces Date: Thu, 19 Mar 2026 12:06:21 -0400 Message-ID: <20260319160621.2651487-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <2026031729-supplier-untoasted-565e@gregkh> References: <2026031729-supplier-untoasted-565e@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Henrique Carvalho [ Upstream commit d4c7210d2f3ea481a6481f03040a64d9077a6172 ] parse_server_interfaces() initializes interface socket addresses with CIFS_PORT. When the mount uses a non-default port this overwrites the configured destination port. Later, cifs_chan_update_iface() copies this sockaddr into server->dstaddr, causing reconnect attempts to use the wrong port after server interface updates. Use the existing port from server->dstaddr instead. Cc: stable@vger.kernel.org Fixes: fe856be475f7 ("CIFS: parse and store info on iface queries") Tested-by: Dr. Thomas Orgis Reviewed-by: Enzo Matsumiya Signed-off-by: Henrique Carvalho Signed-off-by: Steve French [ adapted struct types, function signature, lock name, and file path ] Signed-off-by: Sasha Levin --- fs/cifs/smb2ops.c | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c index 1297acb5bf8e5..5e11362ecc47e 100644 --- a/fs/cifs/smb2ops.c +++ b/fs/cifs/smb2ops.c @@ -437,7 +437,7 @@ smb3_negotiate_rsize(struct cifs_tcon *tcon, struct smb_vol *volume_info) static int parse_server_interfaces(struct network_interface_info_ioctl_rsp *buf, - size_t buf_len, + size_t buf_len, struct cifs_ses *ses, struct cifs_server_iface **iface_list, size_t *iface_count) { @@ -447,6 +447,7 @@ parse_server_interfaces(struct network_interface_info_ioctl_rsp *buf, struct iface_info_ipv4 *p4; struct iface_info_ipv6 *p6; struct cifs_server_iface *info; + __be16 port; ssize_t bytes_left; size_t next = 0; int nb_iface = 0; @@ -493,6 +494,15 @@ parse_server_interfaces(struct network_interface_info_ioctl_rsp *buf, goto out; } + spin_lock(&cifs_tcp_ses_lock); + if (ses->server->dstaddr.ss_family == AF_INET) + port = ((struct sockaddr_in *)&ses->server->dstaddr)->sin_port; + else if (ses->server->dstaddr.ss_family == AF_INET6) + port = ((struct sockaddr_in6 *)&ses->server->dstaddr)->sin6_port; + else + port = cpu_to_be16(CIFS_PORT); + spin_unlock(&cifs_tcp_ses_lock); + info = *iface_list; bytes_left = buf_len; p = buf; @@ -519,7 +529,7 @@ parse_server_interfaces(struct network_interface_info_ioctl_rsp *buf, memcpy(&addr4->sin_addr, &p4->IPv4Address, 4); /* [MS-SMB2] 2.2.32.5.1.1 Clients MUST ignore these */ - addr4->sin_port = cpu_to_be16(CIFS_PORT); + addr4->sin_port = port; cifs_dbg(FYI, "%s: ipv4 %pI4\n", __func__, &addr4->sin_addr); @@ -533,7 +543,7 @@ parse_server_interfaces(struct network_interface_info_ioctl_rsp *buf, /* [MS-SMB2] 2.2.32.5.1.2 Clients MUST ignore these */ addr6->sin6_flowinfo = 0; addr6->sin6_scope_id = 0; - addr6->sin6_port = cpu_to_be16(CIFS_PORT); + addr6->sin6_port = port; cifs_dbg(FYI, "%s: ipv6 %pI6\n", __func__, &addr6->sin6_addr); @@ -600,7 +610,7 @@ SMB3_request_interfaces(const unsigned int xid, struct cifs_tcon *tcon) goto out; } - rc = parse_server_interfaces(out_buf, ret_data_len, + rc = parse_server_interfaces(out_buf, ret_data_len, ses, &iface_list, &iface_count); if (rc) goto out; -- 2.51.0