From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DD9F244694 for ; Thu, 19 Mar 2026 17:18:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773940697; cv=none; b=YcbnFa3vPEEojPckq9d268x1dThYoLOVav2ZRTOVrbOTo2ljtYs7WvrXuIJjJpg7gAJhqudGYV07jwUn647GRPN4F10BU04sO9fsrKuMhDK/SmivnVNIet59Qz/1twB5mSoQ96f8TjkfVn8d6nzk5aupPekODdI8rh83A3N43Ho= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773940697; c=relaxed/simple; bh=QPbJcRbKerA+3iTpTGiNSDAZkUtpE9YH3B85ibI0koQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=J2PrT/ENzv4xBuMussuFi8dGdb33EYkEenwQj9X1XRSuKQ500a2UwP+AyvZXLO2oCe/Hx6Uf3oOmp382rKkFnvkTt0wA2bEoggGCUTgcBIkPDER74BsbfhSbiN0GHSiOoPeOApJtuLuN/pPBH8BLJERySRTIwMvMV87214mqyfw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=h9TDFjXW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="h9TDFjXW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73317C19425; Thu, 19 Mar 2026 17:18:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773940697; bh=QPbJcRbKerA+3iTpTGiNSDAZkUtpE9YH3B85ibI0koQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=h9TDFjXWnTadoRzsa/Wx67704kaPith3HD2jTkEENaJrZ1rfqHqORKPDNKf4Rshoy 1zlXa+B9OXD5Lp5XU4BDnXgb/8/jAgJNnjz5iz9t//Zg6b8uZKoXuMVs0KGrzEbA6U eepRXcc5GIp4uSfxIaEDXLuIJVoauaaNjF203Md0hhTMWBvGyofWNqyFOizJOOUODc SgOeOOJVf1hve+90iBFJ149M1gZ/+65PRx+3u6hp1U59KbXihLiA3m2NWABidMOj6E zk0SzOiS7QqzQtv46clhiB0kBa0dTiTf18QhIXKxowjkWPC2m/yoTyoJvsWnCVABYk vVyx//5xP4XJg== From: Sasha Levin To: stable@vger.kernel.org Cc: =?UTF-8?q?Nuno=20S=C3=A1?= , David Lechner , Stable@vger.kernel.org, Jonathan Cameron , Sasha Levin Subject: [PATCH 6.1.y 2/2] iio: buffer: Fix wait_queue not being removed Date: Thu, 19 Mar 2026 13:18:14 -0400 Message-ID: <20260319171814.2756731-2-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260319171814.2756731-1-sashal@kernel.org> References: <2026031730-control-earplugs-97b6@gregkh> <20260319171814.2756731-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Nuno Sá [ Upstream commit 064234044056c93a3719d6893e6e5a26a94a61b6 ] In the edge case where the IIO device is unregistered while we're buffering, we were directly returning an error without removing the wait queue. Instead, set 'ret' and break out of the loop. Fixes: 9eeee3b0bf19 ("iio: Add output buffer support") Signed-off-by: Nuno Sá Reviewed-by: David Lechner Cc: Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/iio/industrialio-buffer.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c index e02a4cb3d491c..d0bcb9c57f965 100644 --- a/drivers/iio/industrialio-buffer.c +++ b/drivers/iio/industrialio-buffer.c @@ -194,8 +194,10 @@ static ssize_t iio_buffer_write(struct file *filp, const char __user *buf, written = 0; add_wait_queue(&rb->pollq, &wait); do { - if (!indio_dev->info) - return -ENODEV; + if (!indio_dev->info) { + ret = -ENODEV; + break; + } if (!iio_buffer_space_available(rb)) { if (signal_pending(current)) { -- 2.51.0