From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E2B32ECEA0 for ; Thu, 19 Mar 2026 18:34:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773945282; cv=none; b=cGzTlz2hkxTvlPv4cYXVMkurykC8i6Fj/qMwsH/EyUKi1FFSEU6UqUWNVsNDEigu+7T/oPMXQdPwwzPITWmtAWYhqYrVnVI6my0dd/u0Yj90iRxYQnBrH6SU1Pp13SS6i0LmtzKie0L77Re61hHJjkMfJSZ8KWJnfMVPqL4/ue4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773945282; c=relaxed/simple; bh=oeFSrQrPBd5eid99AlC7cN3Ce4tELYishor/albvZ7U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YQVS7OkhRa8uzyOEw6gaXavH/ByXOrh2U+c3nhaeH/rvaEnGH/zwlC3lwQgpZz8vTKoFAY8IYauWooJgxLEM3UJW7entnxPEoQ/2R/qalxWyL7NPRzZLMVpkfngSt95stB4xUdjZu9dUvlWFmtE8TwxhRC/zfHFRJVA0ZcHzORc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kwSlQ1hn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kwSlQ1hn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D349C2BC87; Thu, 19 Mar 2026 18:34:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773945282; bh=oeFSrQrPBd5eid99AlC7cN3Ce4tELYishor/albvZ7U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kwSlQ1hnBE3w7ssDqwo/hI41Inp46rMYhRQaLQuhT7n6tGFCgF5dctr8dWOW7cRV/ 0iHSkamWJclRLyV728b6rbC1flvEgX0P2NSrYqDFLG+95YhW4IgNhe8ONzWT+gQ2bL TzE5dviZnhgp15YKVMFNgPo3KlUDE9COJOQo3gpRbgv0BG1WfWF+ntr+m9wbD3MwOJ JlvQDzmENW8XVdDpiAoVRsQgCRcAssS1Mx2MeLNRKufGt0YVRBIhUDq7Mtqh0CiCP8 CKkCcRWX30SPlE8HFoP+02hoDrEGgsCAz3Kor4jLHponpSFIQ4TWhblcUVuSvVQj4X wDD9TNE6ihHPw== From: Sasha Levin To: stable@vger.kernel.org Cc: Antoniu Miclaus , Linus Walleij , Stable@vger.kernel.org, Jonathan Cameron , Sasha Levin Subject: [PATCH 6.12.y 2/2] iio: light: bh1780: fix PM runtime leak on error path Date: Thu, 19 Mar 2026 14:34:38 -0400 Message-ID: <20260319183438.2928887-2-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260319183438.2928887-1-sashal@kernel.org> References: <2026031706-gentile-unbalance-017b@gregkh> <20260319183438.2928887-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Antoniu Miclaus [ Upstream commit dd72e6c3cdea05cad24e99710939086f7a113fb5 ] Move pm_runtime_put_autosuspend() before the error check to ensure the PM runtime reference count is always decremented after pm_runtime_get_sync(), regardless of whether the read operation succeeds or fails. Fixes: 1f0477f18306 ("iio: light: new driver for the ROHM BH1780") Signed-off-by: Antoniu Miclaus Reviewed-by: Linus Walleij Cc: Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/iio/light/bh1780.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/light/bh1780.c b/drivers/iio/light/bh1780.c index 604eeb48ebc48..6e4d5bd79a303 100644 --- a/drivers/iio/light/bh1780.c +++ b/drivers/iio/light/bh1780.c @@ -109,9 +109,9 @@ static int bh1780_read_raw(struct iio_dev *indio_dev, case IIO_LIGHT: pm_runtime_get_sync(&bh1780->client->dev); value = bh1780_read_word(bh1780, BH1780_REG_DLOW); + pm_runtime_put_autosuspend(&bh1780->client->dev); if (value < 0) return value; - pm_runtime_put_autosuspend(&bh1780->client->dev); *val = value; return IIO_VAL_INT; -- 2.51.0