From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF72164 for ; Fri, 20 Mar 2026 00:22:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773966130; cv=none; b=cyc5LAT6FOCJFU+caYafoT+fpY0iC4adHSv+SlW6gowiFhcrbAnKrgT1y+MfMj49ZWxA36Bdlf6dKhGpgthxBDt/Sl9lqW//PNkTmQlF3Qjn8QnhJoQKpGws7MkWNNeWdoZfrKFrNzN6/ZmR9xDhkq1iiihk8YM5btD7EE7k+ws= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773966130; c=relaxed/simple; bh=6yE/rFdm0clviVs+9lAMyfpRWD2ThgTGDVg1DeXUwUg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Dboz6TAFxDtsXY8KsXgaxAOjJJz89gx3neVWWmAH67gBuMuQxf8t7LbUVeBs3XvveyZYDTvEy3wQ0DZBmuSF3gkRjIhXWVsA78UnerazxY0KTFxfLaioRUtNrtQErjm06aOMV7NsFWZD83OpVd+j/bQt5jYGtllhtrIwCCqpD1Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dktpfuoR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dktpfuoR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD72CC19424; Fri, 20 Mar 2026 00:22:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773966130; bh=6yE/rFdm0clviVs+9lAMyfpRWD2ThgTGDVg1DeXUwUg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dktpfuoRJE+NEHEkc8WrRKmZQzbYl3rn5Y2IeCJncIZfUZA4tVf1mbUHwrvqIjUHh 5tqAXY+asdZD+cAYWtz8ZNCHf5Sr8AS0TkqVyQTDbAoApL1DJlxwfNQOr3o6Kz2d84 sx5X9pa5D4FlSXAGNUvwaEf10nuoOnwX4JhLgVu+4O9LKUAcmoiTUulr3vNXxmjgr3 ZsKMce1lezcIjOQHMpqLzjABL1aS7kGscCGGMN8QdQljgrmiZBqfRpbUsds2YM44CS roOwuMAoT/UEUlUGLy9RtaIdwFhPhTCL/Q0+NliWKj/74/HC4+ACXQiyGM9tmXyiuC 2Q5CN1XZCM+6w== From: Sasha Levin To: stable@vger.kernel.org Cc: Antoniu Miclaus , Linus Walleij , Stable@vger.kernel.org, Jonathan Cameron , Sasha Levin Subject: [PATCH 5.10.y] iio: light: bh1780: fix PM runtime leak on error path Date: Thu, 19 Mar 2026 20:22:08 -0400 Message-ID: <20260320002208.3250719-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <2026031708-darkened-unrelated-6f05@gregkh> References: <2026031708-darkened-unrelated-6f05@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Antoniu Miclaus [ Upstream commit dd72e6c3cdea05cad24e99710939086f7a113fb5 ] Move pm_runtime_put_autosuspend() before the error check to ensure the PM runtime reference count is always decremented after pm_runtime_get_sync(), regardless of whether the read operation succeeds or fails. Fixes: 1f0477f18306 ("iio: light: new driver for the ROHM BH1780") Signed-off-by: Antoniu Miclaus Reviewed-by: Linus Walleij Cc: Signed-off-by: Jonathan Cameron [ moved both pm_runtime_mark_last_busy() and pm_runtime_put_autosuspend() before the error check instead of just pm_runtime_put_autosuspend() ] Signed-off-by: Sasha Levin --- drivers/iio/light/bh1780.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/light/bh1780.c b/drivers/iio/light/bh1780.c index abbf2e662e7db..e0a72ff2ebf8b 100644 --- a/drivers/iio/light/bh1780.c +++ b/drivers/iio/light/bh1780.c @@ -109,10 +109,10 @@ static int bh1780_read_raw(struct iio_dev *indio_dev, case IIO_LIGHT: pm_runtime_get_sync(&bh1780->client->dev); value = bh1780_read_word(bh1780, BH1780_REG_DLOW); - if (value < 0) - return value; pm_runtime_mark_last_busy(&bh1780->client->dev); pm_runtime_put_autosuspend(&bh1780->client->dev); + if (value < 0) + return value; *val = value; return IIO_VAL_INT; -- 2.51.0