From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44556284896 for ; Fri, 20 Mar 2026 14:57:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774018671; cv=none; b=as0zpre6ym0ROTA7Aed947SV1XMRbWPLggOIHjjhQGg4IvapQU+EvJoV24BL/w36KI/0/vDdo9ye/5NndfVaD5Bbqb95lw4GKHNR58wYne3kcCNwW/H5T79jwXw5S3475Yz/SfFAtJuyTbAVHCdox8dRLwc+68TpbAF5KDZnuTo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774018671; c=relaxed/simple; bh=WYTHIaIReKaxPZlMBRdB79V6pGaS1TcFf7jAqJvVIvw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dADV/ftMyQMV882ufnQuUiXg94OwHz2Uv4/kc9aAtALpMohjKdWNpMlTVwp2HedIF9rWFw0SeWN8cSbCUvdsqAIyVd6USHrKhfDhHehtodn0h81BCGY8diTC0OtUzt82/GRMyVb4dFfxDh04JdOozRWHw6rTxSpmwi/903QNU7U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XuWTZ63f; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XuWTZ63f" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 508EAC4CEF7; Fri, 20 Mar 2026 14:57:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774018671; bh=WYTHIaIReKaxPZlMBRdB79V6pGaS1TcFf7jAqJvVIvw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XuWTZ63fQMcnZBGUzIbCHjomSqej+iLafx2sht79FymZE3mygh9kuT8ATyFoXpwRU VCwepGHMrcFGZkQVTmfzJwWvaRCGS3vm7DziDCXOw+0/eV1skxhWccuVCk0/prQXbx YNfSfGJeillzW+OAD1bcVurURxC9KmDxblDF4IqgkePSwO/HgRuU/hnyE+Ig2O7BlT T9J/7982u9WZ3m0GyAzyJHFL0+bv/p1V8z53WQ6WdDYEyYRIRla1RLe9Z7ZDoEow0C 0HLgZkvKhwNW9p24aqMWJSknjBgPs1h38K0y4DN1ejqYB0xOWraOK7+8DBXkD2mv4x Ev/d5Hhgt/+xA== From: Sasha Levin To: stable@vger.kernel.org Cc: Kevin Hao , Quanyang Wang , Simon Horman , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.6.y 3/3] net: macb: Reinitialize tx/rx queue pointer registers and rx ring during resume Date: Fri, 20 Mar 2026 10:57:46 -0400 Message-ID: <20260320145746.4187361-3-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260320145746.4187361-1-sashal@kernel.org> References: <2026032001-degrease-handcuff-81e4@gregkh> <20260320145746.4187361-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Kevin Hao [ Upstream commit 718d0766ce4c7634ce62fa78b526ea7263487edd ] On certain platforms, such as AMD Versal boards, the tx/rx queue pointer registers are cleared after suspend, and the rx queue pointer register is also disabled during suspend if WOL is enabled. Previously, we assumed that these registers would be restored by macb_mac_link_up(). However, in commit bf9cf80cab81, macb_init_buffers() was moved from macb_mac_link_up() to macb_open(). Therefore, we should call macb_init_buffers() to reinitialize the tx/rx queue pointer registers during resume. Due to the reset of these two registers, we also need to adjust the tx/rx rings accordingly. The tx ring will be handled by gem_shuffle_tx_rings() in macb_mac_link_up(), so we only need to initialize the rx ring here. Fixes: bf9cf80cab81 ("net: macb: Fix tx/rx malfunction after phy link down and up") Reported-by: Quanyang Wang Signed-off-by: Kevin Hao Tested-by: Quanyang Wang Cc: stable@vger.kernel.org Reviewed-by: Simon Horman Link: https://patch.msgid.link/20260312-macb-versal-v1-2-467647173fa4@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/cadence/macb_main.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index ffd39103dd860..98970266165e9 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -5408,8 +5408,18 @@ static int __maybe_unused macb_resume(struct device *dev) rtnl_unlock(); } + if (!(bp->caps & MACB_CAPS_MACB_IS_EMAC)) + macb_init_buffers(bp); + for (q = 0, queue = bp->queues; q < bp->num_queues; ++q, ++queue) { + if (!(bp->caps & MACB_CAPS_MACB_IS_EMAC)) { + if (macb_is_gem(bp)) + gem_init_rx_ring(queue); + else + macb_init_rx_ring(queue); + } + napi_enable(&queue->napi_rx); napi_enable(&queue->napi_tx); } -- 2.51.0