From: Greg KH <gregkh@linuxfoundation.org>
To: Ionut Nechita <ionut.nechita@windriver.com>
Cc: stable@vger.kernel.org, rafael.j.wysocki@intel.com,
linux-pm@vger.kernel.org, christian.loehle@arm.com,
artem.bityutskiy@linux.intel.com, quic_zhonhan@quicinc.com,
aboorvad@linux.ibm.com
Subject: Re: [PATCH 6.12.y 1/6] cpuidle: menu: Drop a redundant local variable
Date: Sat, 21 Mar 2026 09:24:11 +0100 [thread overview]
Message-ID: <2026032141-tightness-lukewarm-43df@gregkh> (raw)
In-Reply-To: <20260320202908.24377-2-ionut.nechita@windriver.com>
On Fri, Mar 20, 2026 at 10:29:03PM +0200, Ionut Nechita wrote:
> From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
>
> Local variable min in get_typical_interval() is updated, but never
> accessed later, so drop it.
>
> No functional impact.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Reviewed-by: Christian Loehle <christian.loehle@arm.com>
> Tested-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> Tested-by: Christian Loehle <christian.loehle@arm.com>
> Tested-by: Aboorva Devarajan <aboorvad@linux.ibm.com>
> Link: https://patch.msgid.link/13699686.uLZWGnKmhe@rjwysocki.net
> ---
> drivers/cpuidle/governors/menu.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
Again, you forgot the original git id. Please redo the series with that
information.
And you all know this, I went through "how to properly backport patches
to stable" a lot with your team, this needs to be reviewed by someone
else at windriver before it can be accepted as you also messed up on
something else here that you should have gotten correct :(
thanks,
greg k-h
next prev parent reply other threads:[~2026-03-21 8:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 20:29 [PATCH 6.12.y 0/6] cpuidle: menu: Backport get_typical_interval() improvements Ionut Nechita
2026-03-20 20:29 ` [PATCH 6.12.y 1/6] cpuidle: menu: Drop a redundant local variable Ionut Nechita
2026-03-21 8:24 ` Greg KH [this message]
2026-03-20 20:29 ` [PATCH 6.12.y 2/6] cpuidle: menu: Use one loop for average and variance computations Ionut Nechita
2026-03-20 20:29 ` [PATCH 6.12.y 3/6] cpuidle: menu: Tweak threshold use in get_typical_interval() Ionut Nechita
2026-03-20 20:29 ` [PATCH 6.12.y 4/6] cpuidle: menu: Eliminate outliers on both ends of the sample set Ionut Nechita
2026-03-20 20:29 ` [PATCH 6.12.y 5/6] cpuidle: menu: Update documentation after get_typical_interval() changes Ionut Nechita
2026-03-20 20:29 ` [PATCH 6.12.y 6/6] cpuidle: menu: Optimize bucket assignment when next_timer_ns equals KTIME_MAX Ionut Nechita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026032141-tightness-lukewarm-43df@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=aboorvad@linux.ibm.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=christian.loehle@arm.com \
--cc=ionut.nechita@windriver.com \
--cc=linux-pm@vger.kernel.org \
--cc=quic_zhonhan@quicinc.com \
--cc=rafael.j.wysocki@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox