From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1376C2E2665; Sun, 22 Mar 2026 13:11:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774185080; cv=none; b=EFCY1KnKTpLHNf9qNnkCxsmry3JlnkQ9110E8L6H6NjwG6Hy5m7OqNSfwJ4fE3UxJU8paPRrnV22fHjvPEi6oKlxxF2vYdRKU/uL6yTevnGz87kLMuwdob8KnxrkyozVn1b2g4Nq5uuFTruTc0hdHTXynLgWbtXmzZ3Yzwtuqak= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774185080; c=relaxed/simple; bh=L06mMv13leSJidJpgulaO5FBALi9cUTwx4gGFd0q7as=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ElZdKpakd9WxPYcfxlCXYojK/eWW8i0WWof9MFTWS8NiQvF7MemM8zTv3KW55m9KrQqGZBsGBEnL4c72rqG7it9CKgV04r6AdfeWtVkhsK0LxjQ0UEy7ovAkJIxygfLU7km5Z6CE9p1v7tYvO9HFYLAvbVWqXLkagv/cr0A8zJY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=aoBPG9Q1; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="aoBPG9Q1" Received: from linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net (linux.microsoft.com [13.77.154.182]) by linux.microsoft.com (Postfix) with ESMTPSA id CB8E220B710C; Sun, 22 Mar 2026 06:11:07 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com CB8E220B710C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1774185067; bh=TnvIecdWPOnc/JdZh2X2csrYBPQtgwy00+VNBTpbbfU=; h=From:To:Cc:Subject:Date:From; b=aoBPG9Q1b3b0vm51kmGXY5j0baDy/VH1glvCjgjObRIaN9Bgj3miWHd+RvrDbA+fO 3l7Fyn+ECkMx8waAmtkUmRy+M4KqW2a2868ZCkN02iLSowXYFOEAHZ4Mvc/tvn9QhG qxSgwKawewNpqzbvkuQdNqFj+of7y4Pqa+I5/9CU= From: Prasanna Kumar T S M To: ptsm@linux.microsoft.com, shubhrajyoti.datta@amd.com, bp@alien8.de, tony.luck@intel.com, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Subject: [PATCH 1/5] EDAC/versalnet: Fix teardown ordering in mc_remove() Date: Sun, 22 Mar 2026 06:11:07 -0700 Message-ID: <20260322131107.1684647-1-ptsm@linux.microsoft.com> X-Mailer: git-send-email 2.43.7 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The teardown sequence in mc_remove() does not mirror the reverse of the initialization order in mc_probe(). In particular, unregister_rpmsg_driver() is called before remove_versalnet(), and cdx_mcdi_finish() is called after rproc_shutdown(). Reorder mc_remove() to reverse the probe initialization sequence, consistent with the probe error-unwind paths. Fixes: d5fe2fec6c40d ("EDAC: Add a driver for the AMD Versal NET DDR controller") Cc: stable@vger.kernel.org Signed-off-by: Prasanna Kumar T S M --- drivers/edac/versalnet_edac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/edac/versalnet_edac.c b/drivers/edac/versalnet_edac.c index 0b47ed7fed63..f70243bc8a7a 100644 --- a/drivers/edac/versalnet_edac.c +++ b/drivers/edac/versalnet_edac.c @@ -954,10 +954,10 @@ static void mc_remove(struct platform_device *pdev) { struct mc_priv *priv = platform_get_drvdata(pdev); - unregister_rpmsg_driver(&amd_rpmsg_driver); remove_versalnet(priv); - rproc_shutdown(priv->mcdi->r5_rproc); cdx_mcdi_finish(priv->mcdi); + unregister_rpmsg_driver(&amd_rpmsg_driver); + rproc_shutdown(priv->mcdi->r5_rproc); } static const struct of_device_id amd_edac_match[] = { -- 2.49.0