From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72A7D3AE1AD; Mon, 23 Mar 2026 13:51:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774273877; cv=none; b=HxdxhXbAtO3GcammQhOmer+a6J577h//YaD+3xadd8MW/53/DZrTlc8Wcn7cyOf0pLRglkRxvFCSqjuZDQYkg4LM2rt2H1X+bfmo2R2Vko03VGc1zt9qgpLka0f+Mp3qoj6Ex5sZk/GBLT/l0WwoFTy5Rad59MtDtLPqHw1RoPI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774273877; c=relaxed/simple; bh=V8yQo9zNz7wxMcz+IDmU+FPWTxJgqZIIqjjgcjTLcCk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CxratA+gfIIhA+cdjqyNjmTLMSbto2S3ZwVFANsakbygxN190MpftskNMButdnVclLvKeEunGVsPeRFUXRIUjg4zTfHh+YzV6Vc5Sf1GexSD5Vym6ajeL0pHvdBdItZlesybWFpwKgCAq4GHnpikUD4q8v1LgxAWmEL8n6dEXxY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=pjXo/v7u; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="pjXo/v7u" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8482C2BCB3; Mon, 23 Mar 2026 13:51:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1774273877; bh=V8yQo9zNz7wxMcz+IDmU+FPWTxJgqZIIqjjgcjTLcCk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pjXo/v7uQtBqehR6REdQi34rnWA49INm1+7kcrybzI42MAM0co2Qv/zN9QXU9u0XF L3+q92lSLM+XBFvwjIApG847Dplf991MlFsA3DHHnddv07GKZ7iSeNLh7sgHlgADZN f3t/zYziIPvbp27XODkav2bqvTRtPZxDXJDA+HNM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Shuicheng Lin , Varun Gupta , Matthew Brost , Tejas Upadhyay , Rodrigo Vivi , Sasha Levin Subject: [PATCH 6.19 038/220] drm/xe: Fix memory leak in xe_vm_madvise_ioctl Date: Mon, 23 Mar 2026 14:43:35 +0100 Message-ID: <20260323134505.789738405@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260323134504.575022936@linuxfoundation.org> References: <20260323134504.575022936@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Varun Gupta [ Upstream commit 0cfe9c4838f1147713f6b5c02094cd4dc0c598fa ] When check_bo_args_are_sane() validation fails, jump to the new free_vmas cleanup label to properly free the allocated resources. This ensures proper cleanup in this error path. Fixes: 293032eec4ba ("drm/xe/bo: Update atomic_access attribute on madvise") Cc: stable@vger.kernel.org # v6.18+ Reviewed-by: Shuicheng Lin Signed-off-by: Varun Gupta Reviewed-by: Matthew Brost Link: https://patch.msgid.link/20260223175145.1532801-1-varun.gupta@intel.com Signed-off-by: Tejas Upadhyay (cherry picked from commit 29bd06faf727a4b76663e4be0f7d770e2d2a7965) Signed-off-by: Rodrigo Vivi [ changed old goto target from `madv_fini` to `unlock_vm` ] Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/xe/xe_vm_madvise.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/gpu/drm/xe/xe_vm_madvise.c +++ b/drivers/gpu/drm/xe/xe_vm_madvise.c @@ -390,7 +390,7 @@ int xe_vm_madvise_ioctl(struct drm_devic madvise_range.num_vmas, args->atomic.val)) { err = -EINVAL; - goto unlock_vm; + goto free_vmas; } } @@ -426,6 +426,7 @@ int xe_vm_madvise_ioctl(struct drm_devic err_fini: if (madvise_range.has_bo_vmas) drm_exec_fini(&exec); +free_vmas: kfree(madvise_range.vmas); madvise_range.vmas = NULL; unlock_vm: