From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F1C43AD536; Mon, 23 Mar 2026 13:55:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774274128; cv=none; b=Hlx3hFWiL8ETp0CTzqNrSbTqTwF1AaUv4RBXTwUGnVLdB5XjIFg68QDRQnMXNIWqgHcxHTYb1QEz4+6W1QknjEZLMpLYDGQM1OY1YyWaCYTvkDbQW6lw/Gr99GXhj4S/A0EcT8SOKv2nHZI0cisSQEMtwRfzC3TkxkuQoP09YvA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774274128; c=relaxed/simple; bh=I1snRBp8n03zI8/WvbwdGXtcOcHwhNM+rJG/99yCnJU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Lw4p0o82gtc0Iz/Dboo/0/1q4Q54vYQ/en/OquWjFqtVWkJ05sXeEoMLr72NLuDgdHokwXAUJ9Iveh7wDDRwjdmwuFGhuUxFVJ4v4VvYhsCOirfGDO8fM5KPZaC3uSEWStKP8YzGBmt+16GpsVIghiA12qz+0sO9Md8B0i12JZ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ZK88+0XL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ZK88+0XL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 862DDC4CEF7; Mon, 23 Mar 2026 13:55:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1774274127; bh=I1snRBp8n03zI8/WvbwdGXtcOcHwhNM+rJG/99yCnJU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZK88+0XLq/lEsZJsjHgVz+JmOYpp+JIkVCp6cNZ4nwSh1Ka01EqTfc1Yr5K/xuRyM 27HiqV8zMN0Lif4PP6/hVxeq5fvoxHcxHXbYqr0w99pMZqf7bFNtGuV6LRz58c3NlB pokxVd3bG3HwLe9MFly9d2SFSYlrGfdLDRWq3uLo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Felix Gu , Sudeep Holla , Sasha Levin Subject: [PATCH 6.19 116/220] firmware: arm_scpi: Fix device_node reference leak in probe path Date: Mon, 23 Mar 2026 14:44:53 +0100 Message-ID: <20260323134508.269579806@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260323134504.575022936@linuxfoundation.org> References: <20260323134504.575022936@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Felix Gu [ Upstream commit 879c001afbac3df94160334fe5117c0c83b2cf48 ] A device_node reference obtained from the device tree is not released on all error paths in the arm_scpi probe path. Specifically, a node returned by of_parse_phandle() could be leaked when the probe failed after the node was acquired. The probe function returns early and the shmem reference is not released. Use __free(device_node) scope-based cleanup to automatically release the reference when the variable goes out of scope. Fixes: ed7ecb883901 ("firmware: arm_scpi: Add compatibility checks for shmem node") Signed-off-by: Felix Gu Message-Id: <20260121-arm_scpi_2-v2-1-702d7fa84acb@gmail.com> Signed-off-by: Sudeep Holla Signed-off-by: Sasha Levin --- drivers/firmware/arm_scpi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/arm_scpi.c b/drivers/firmware/arm_scpi.c index 87c323de17b90..398642cc25d90 100644 --- a/drivers/firmware/arm_scpi.c +++ b/drivers/firmware/arm_scpi.c @@ -18,6 +18,7 @@ #include #include +#include #include #include #include @@ -940,13 +941,13 @@ static int scpi_probe(struct platform_device *pdev) int idx = scpi_drvinfo->num_chans; struct scpi_chan *pchan = scpi_drvinfo->channels + idx; struct mbox_client *cl = &pchan->cl; - struct device_node *shmem = of_parse_phandle(np, "shmem", idx); + struct device_node *shmem __free(device_node) = + of_parse_phandle(np, "shmem", idx); if (!of_match_node(shmem_of_match, shmem)) return -ENXIO; ret = of_address_to_resource(shmem, 0, &res); - of_node_put(shmem); if (ret) { dev_err(dev, "failed to get SCPI payload mem resource\n"); return ret; -- 2.51.0