From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B4973B19AF; Mon, 23 Mar 2026 15:28:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774279716; cv=none; b=hEQxQ+zLLzU55paP+sfi0Jp/rpoQmrJxm3wCKu4DDxHZRgxwQ9vXtTH3tTbHVeyDX2yYmRGXw8NYDCikYqt+pzcDF+YpLnjsG7aDU/xMlIdww5xlFgZj1EVbiquNbvsjKsP1v++jPQ8fK9buIoCzhrnyTgn02oo3pHMcJiszcfM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774279716; c=relaxed/simple; bh=dP4HAlmRXRnd/S4CF6zBQTQ1Idsp7N+knBUolOP4+xo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Rb2mhQIUV+Etvo5cEMdXrWiqb64J5JzvhTFc3SGXdfGlDDTkEMIyIDmei1i6lxOgjRbnuIwUksVxKslht7vQpT+TRN58UQaAvm+OQg487FBw6QUmCnQqEufJPZlL+ypSQWrUhrKtGMEDEaR4/17Wp3s4Ysx63rbEFiB6XlbBsaw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=heQgKIvW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="heQgKIvW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC80DC4CEF7; Mon, 23 Mar 2026 15:28:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1774279716; bh=dP4HAlmRXRnd/S4CF6zBQTQ1Idsp7N+knBUolOP4+xo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=heQgKIvW/mp4DOKV+vnAR7BuJG3gsqIot67NsWQxGHLdC5i63O92nUs6y8c/M3Mbn WkRg1E42LaJCAQ3cvMyOTAQl+loCwq3HawgeKZ96fXhe2/o/k3K1R6YthO6qUshbFn TCDEcMvEZ/tzx4TzcDH3W3aCimQelQA4UjzWVRSQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Johan Hovold , Dmitry Baryshkov , Konrad Dybcio , Lee Jones , Sasha Levin Subject: [PATCH 6.1 055/481] mfd: qcom-pm8xxx: Fix OF populate on driver rebind Date: Mon, 23 Mar 2026 14:40:37 +0100 Message-ID: <20260323134526.566549684@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260323134525.256603107@linuxfoundation.org> References: <20260323134525.256603107@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold [ Upstream commit 27a8acea47a93fea6ad0e2df4c20a9b51490e4d9 ] Since commit c6e126de43e7 ("of: Keep track of populated platform devices") child devices will not be created by of_platform_populate() if the devices had previously been deregistered individually so that the OF_POPULATED flag is still set in the corresponding OF nodes. Switch to using of_platform_depopulate() instead of open coding so that the child devices are created if the driver is rebound. Fixes: c6e126de43e7 ("of: Keep track of populated platform devices") Cc: stable@vger.kernel.org # 3.16 Signed-off-by: Johan Hovold Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio Link: https://patch.msgid.link/20251219110947.24101-1-johan@kernel.org Signed-off-by: Lee Jones Signed-off-by: Sasha Levin --- drivers/mfd/qcom-pm8xxx.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/mfd/qcom-pm8xxx.c b/drivers/mfd/qcom-pm8xxx.c index 8831448371290..cbcbff3c95ecb 100644 --- a/drivers/mfd/qcom-pm8xxx.c +++ b/drivers/mfd/qcom-pm8xxx.c @@ -581,17 +581,11 @@ static int pm8xxx_probe(struct platform_device *pdev) return rc; } -static int pm8xxx_remove_child(struct device *dev, void *unused) -{ - platform_device_unregister(to_platform_device(dev)); - return 0; -} - static void pm8xxx_remove(struct platform_device *pdev) { struct pm_irq_chip *chip = platform_get_drvdata(pdev); - device_for_each_child(&pdev->dev, NULL, pm8xxx_remove_child); + of_platform_depopulate(&pdev->dev); irq_domain_remove(chip->irqdomain); } -- 2.51.0