From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 821CC3AE70F; Mon, 23 Mar 2026 15:28:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774279718; cv=none; b=P6Ultgnn99gsubyI256b0rMMHprk1vmsW6hSHvqY+DL1uXIBiIDFCybxnMSf1Uhx0DI/hjpv+1sLSoq8tEgnherA4/z1+U2DTB7QVQZZBhUnvqWZCoK4eeKEXkIDtlrt428ii504ggyfo+wfX2keGdi4UouQ/OyRM4x+oS+lujo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774279718; c=relaxed/simple; bh=iu86mPmzXon6/feiXFvJTBepSBSZdNsoGqMokFwK9to=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=c1X9yOOq3EU4ewXhHV85hJOhOWI6Ae15me2Ua7CoN/qzARvKRvdN2HCtlf9EpTURfT6KRkrai3pEI40v7K0TBcaR149nHDzkXnLrBGdvUwBZDSbWFQyBYMocoJCoxKVDkXSdcoAZTs46X9h1noa5aRS+u13CqgQFhEvF2jpWn1M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=U+hCZmS4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="U+hCZmS4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1CCF1C4CEF7; Mon, 23 Mar 2026 15:28:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1774279718; bh=iu86mPmzXon6/feiXFvJTBepSBSZdNsoGqMokFwK9to=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U+hCZmS4MVmAcB5RoDvGCEtPrurwxNyQP//nI1VhuZBm0D9A1bb1fGCyxI3abA97f /a50tvoWDnM9xjxx9obLgCBkBDpqnQwH5K53Fk0xRjcZp7k2FXU6ifV/CZ0o0RGKbu xywiYNluecfdfylg3rIEZrzhqZ8s6o2pqmHnJ5SE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Lee Jones , Sasha Levin Subject: [PATCH 6.1 056/481] mfd: omap-usb-host: Convert to platform remove callback returning void Date: Mon, 23 Mar 2026 14:40:38 +0100 Message-ID: <20260323134526.588843651@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260323134525.256603107@linuxfoundation.org> References: <20260323134525.256603107@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Uwe Kleine-König [ Upstream commit 418d1e74f8597e0b2d5d0d6e1be8f1f47e68f0a4 ] The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20231123165627.492259-11-u.kleine-koenig@pengutronix.de Signed-off-by: Lee Jones Stable-dep-of: 24804ba508a3 ("mfd: omap-usb-host: Fix OF populate on driver rebind") Signed-off-by: Sasha Levin --- drivers/mfd/omap-usb-host.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c index 787d2ae863752..b61fb9933aa85 100644 --- a/drivers/mfd/omap-usb-host.c +++ b/drivers/mfd/omap-usb-host.c @@ -818,13 +818,12 @@ static int usbhs_omap_remove_child(struct device *dev, void *data) * * Reverses the effect of usbhs_omap_probe(). */ -static int usbhs_omap_remove(struct platform_device *pdev) +static void usbhs_omap_remove(struct platform_device *pdev) { pm_runtime_disable(&pdev->dev); /* remove children */ device_for_each_child(&pdev->dev, NULL, usbhs_omap_remove_child); - return 0; } static const struct dev_pm_ops usbhsomap_dev_pm_ops = { @@ -847,7 +846,7 @@ static struct platform_driver usbhs_omap_driver = { .of_match_table = usbhs_omap_dt_ids, }, .probe = usbhs_omap_probe, - .remove = usbhs_omap_remove, + .remove_new = usbhs_omap_remove, }; MODULE_AUTHOR("Keshava Munegowda "); -- 2.51.0