From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E6D9199FAB; Mon, 23 Mar 2026 14:14:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774275253; cv=none; b=g5SFuvhlSgaKizTInactV0ocHA3f8IU2c7sQi78DJ9/QQBUd6272I7aAKVyj2+tprFKefnuRdWVvuct6svRs6QA1npXOd0vlpJMEZ57QbUPvkYi7sEEEehheUlMs+FW0jWQOEULP2/2tsbFRmxJ3W+1XbAYgwmeDN3MZaifE8SA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774275253; c=relaxed/simple; bh=PAqoq83stBBSuaB5VlguMskqLb+xiyZKEdpXJLUOH08=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=c3RBPsdcJG3CiQjiFGj7nfq+NgxisaR7BjGtr4mR38xJUwaKR1SoBXF9VJAcfLBZUKAPKHMkZQQog/Kt91cVuHvr/Mx3JAT8cE+jQSTfIavNcDW4V/Pvjo3DtvTSFNJ6GFNYiPu6Hq7sJevHPtMqsEEKPqCumIbxp/vdKbjEA2E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=g68c/+/+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="g68c/+/+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B380DC4CEF7; Mon, 23 Mar 2026 14:14:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1774275253; bh=PAqoq83stBBSuaB5VlguMskqLb+xiyZKEdpXJLUOH08=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g68c/+/+CJaY3Vul8GpRmneg1FE9HJzijYCBBZY0qY+/FF1o8dbfxrHOHI4c5BJ4F xIUMRzoIozbIJ6P9c559Xtn3i8NXmCfsojE3KYi3fduP4slhDN2jwZ/G/zehrIvl2z IPNDGFiPI32lSX8iVU+UPgLVohRUh+fedPwdL0lw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Breno Leitao , Song Liu , Tejun Heo , Sasha Levin Subject: [PATCH 6.12 029/460] workqueue: Use POOL_BH instead of WQ_BH when checking pool flags Date: Mon, 23 Mar 2026 14:40:25 +0100 Message-ID: <20260323134527.413672936@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260323134526.647552166@linuxfoundation.org> References: <20260323134526.647552166@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Breno Leitao [ Upstream commit f42f9091be9e5ff57567a3945cfcdd498f475348 ] pr_cont_worker_id() checks pool->flags against WQ_BH, which is a workqueue-level flag (defined in workqueue.h). Pool flags use a separate namespace with POOL_* constants (defined in workqueue.c). The correct constant is POOL_BH. Both WQ_BH and POOL_BH are defined as (1 << 0) so this has no behavioral impact, but it is semantically wrong and inconsistent with every other pool-level BH check in the file. Fixes: 4cb1ef64609f ("workqueue: Implement BH workqueues to eventually replace tasklets") Signed-off-by: Breno Leitao Acked-by: Song Liu Signed-off-by: Tejun Heo Signed-off-by: Sasha Levin --- kernel/workqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 3840d7ce9cda0..b2fdb8719a744 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -6209,7 +6209,7 @@ static void pr_cont_worker_id(struct worker *worker) { struct worker_pool *pool = worker->pool; - if (pool->flags & WQ_BH) + if (pool->flags & POOL_BH) pr_cont("bh%s", pool->attrs->nice == HIGHPRI_NICE_LEVEL ? "-hi" : ""); else -- 2.51.0