From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C71DE3BF66F; Mon, 23 Mar 2026 16:16:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774282601; cv=none; b=E7WkFtUejHHRV1Dr8HdzUVbEu3olyQox3Y8epn3ykA48najSHp2AlKZoCvXMJ9CRkaag6ZIUoqYlA8Hh/UXmBA6PdXdrxhEUQqVky1BXualAgsrx1jp90Shw9n4g0aILIzPiyHDcief0bbnd09Di2+E+JCPR0iKcXKuWQZrIGfM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774282601; c=relaxed/simple; bh=krjPHeUYHKSxSlM6TzmYOMIevxjvHQcihJScY77Mo7Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SpI3UcLkj2kblsPHnbFAgiL4kGlCsOOjFVdcox1pBNdNz3hxt6Y87OFWM0mugQgmofwFNHH4SLa6KxPss8FrYesNUi2BhIhQUoTA8thD5dfPlPqPlV+jGOMFKn624dr5IkoY5vdGG7W0VoNL5dTg7LBlsMhRjav6Ru1A1Hnn388= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ScGUJies; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ScGUJies" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0EA48C2BC9E; Mon, 23 Mar 2026 16:16:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1774282601; bh=krjPHeUYHKSxSlM6TzmYOMIevxjvHQcihJScY77Mo7Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ScGUJiesjAoZDNBg6e59OY9A9Sq+RNNDIsH9/wrUyACjgy4qHyTu6ov79nwXCzjb8 IIsOlUL+k5l8TlbXpYmh7lDmhWGjj5+bhKTQ9fESbWWJyn+O4B5+M6XlqcX7qUU0jw 62Yrosc/F/i71h6vvg7VLbPtU7Ab9JcMHjXfPrx4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable , Alan Stern , Fan Wu Subject: [PATCH 6.1 216/481] usb: renesas_usbhs: fix use-after-free in ISR during device removal Date: Mon, 23 Mar 2026 14:43:18 +0100 Message-ID: <20260323134530.420120704@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260323134525.256603107@linuxfoundation.org> References: <20260323134525.256603107@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Fan Wu commit 3cbc242b88c607f55da3d0d0d336b49bf1e20412 upstream. In usbhs_remove(), the driver frees resources (including the pipe array) while the interrupt handler (usbhs_interrupt) is still registered. If an interrupt fires after usbhs_pipe_remove() but before the driver is fully unbound, the ISR may access freed memory, causing a use-after-free. Fix this by calling devm_free_irq() before freeing resources. This ensures the interrupt handler is both disabled and synchronized (waits for any running ISR to complete) before usbhs_pipe_remove() is called. Fixes: f1407d5c6624 ("usb: renesas_usbhs: Add Renesas USBHS common code") Cc: stable Suggested-by: Alan Stern Signed-off-by: Fan Wu Link: https://patch.msgid.link/20260303073344.34577-1-fanwu01@zju.edu.cn Signed-off-by: Greg Kroah-Hartman --- drivers/usb/renesas_usbhs/common.c | 9 +++++++++ 1 file changed, 9 insertions(+) --- a/drivers/usb/renesas_usbhs/common.c +++ b/drivers/usb/renesas_usbhs/common.c @@ -800,6 +800,15 @@ static void usbhs_remove(struct platform usbhs_platform_call(priv, hardware_exit, pdev); reset_control_assert(priv->rsts); + + /* + * Explicitly free the IRQ to ensure the interrupt handler is + * disabled and synchronized before freeing resources. + * devm_free_irq() calls free_irq() which waits for any running + * ISR to complete, preventing UAF. + */ + devm_free_irq(&pdev->dev, priv->irq, priv); + usbhs_mod_remove(priv); usbhs_fifo_remove(priv); usbhs_pipe_remove(priv);