From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 082DE3B9DB1; Mon, 23 Mar 2026 16:19:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774282749; cv=none; b=A+4mfuP4VwCc2/5qmvGG49/hl8O2okCVFr/07C9MJOZbG59mdRNh7YqsxTWNZ/KyMy/D8/BMYlDxU4il1xzL15mpFtRyatX+E92byz19MgWbLpYk4t7/Ceu5KfL7vBgRMCk+xva1mlpCChcnwWAtHZpQ5Y/Yl2Ja6SeO2f64EKM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774282749; c=relaxed/simple; bh=QrAetbujNxIkoNSsnEUfSfMrlsWyUaRXpp+3LAt6zhA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sfRuzq+Wzl8i86t3r8UQpbVRx7Q8z5ysmqa6Cf00uvkrw8nXCMX1U1IeVmzDj2zEAuqTHYMqagVmHquP2zS6hsYktzchSH3WZHFmsm5N43c1ArpEGDv56T8kr1o++RrzXFn4RfQXtIOaawStBkimyRTshpuwSmwUtj4Y5wotXwY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=geVkXk+w; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="geVkXk+w" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BCF6C4CEF7; Mon, 23 Mar 2026 16:19:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1774282748; bh=QrAetbujNxIkoNSsnEUfSfMrlsWyUaRXpp+3LAt6zhA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=geVkXk+wd8VEAQ/6bNW7F28WjtV3xOhdrbo1GJu2goBZDMnuEz0RChkO2pr+PFXrr YwowhpXGPo4LK7ZL2tQ56bVG8ja9kn6Am7qaRCIxwp6HYQSdqYynTRbRNidCLKSkT0 gGBR7Cxh7KJzF7zny46ZUe3naTR/My8sttfMy9tc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Aleksandr Loktionov , Piotr Kwapulinski , Paul Menzel , Jedrzej Jagielski , Rafal Romanowski , Tony Nguyen Subject: [PATCH 6.1 234/481] ixgbevf: fix link setup issue Date: Mon, 23 Mar 2026 14:43:36 +0100 Message-ID: <20260323134530.845401543@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260323134525.256603107@linuxfoundation.org> References: <20260323134525.256603107@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jedrzej Jagielski commit feae40a6a178bb525a15f19288016e5778102a99 upstream. It may happen that VF spawned for E610 adapter has problem with setting link up. This happens when ixgbevf supporting mailbox API 1.6 cooperates with PF driver which doesn't support this version of API, and hence doesn't support new approach for getting PF link data. In that case VF asks PF to provide link data but as PF doesn't support it, returns -EOPNOTSUPP what leads to early bail from link configuration sequence. Avoid such situation by using legacy VFLINKS approach whenever negotiated API version is less than 1.6. To reproduce the issue just create VF and set its link up - adapter must be any from the E610 family, ixgbevf must support API 1.6 or higher while ixgbevf must not. Fixes: 53f0eb62b4d2 ("ixgbevf: fix getting link speed data for E610 devices") Reviewed-by: Aleksandr Loktionov Reviewed-by: Piotr Kwapulinski Reviewed-by: Paul Menzel Cc: stable@vger.kernel.org Signed-off-by: Jedrzej Jagielski Tested-by: Rafal Romanowski Signed-off-by: Tony Nguyen Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/intel/ixgbevf/vf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ixgbevf/vf.c b/drivers/net/ethernet/intel/ixgbevf/vf.c index 74d320879513..b67b580f7f1c 100644 --- a/drivers/net/ethernet/intel/ixgbevf/vf.c +++ b/drivers/net/ethernet/intel/ixgbevf/vf.c @@ -852,7 +852,8 @@ static s32 ixgbevf_check_mac_link_vf(struct ixgbe_hw *hw, if (!mac->get_link_status) goto out; - if (hw->mac.type == ixgbe_mac_e610_vf) { + if (hw->mac.type == ixgbe_mac_e610_vf && + hw->api_version >= ixgbe_mbox_api_16) { ret_val = ixgbevf_get_pf_link_state(hw, speed, link_up); if (ret_val) goto out; -- 2.53.0