From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 426303AF678; Mon, 23 Mar 2026 16:19:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774282770; cv=none; b=lFsK/tHNXTHQqAF7us7Kfw6o5uLoX4R5nHwLUZAdKkR7rYqBDNdG29/KHAh18JxQ/uTOfnVwEwwuy6g6hBoP4OLFM8p4pGPpkgxOPtdC+6rJvNEiM0u2Fkd6M23s2qFX/gC8XHdMeioXk7GabcbzH86ZYvaLeWs9v/a/1hgqDJE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774282770; c=relaxed/simple; bh=/uY2nOPjpYlr6g8/PPxT2hrLGJH1jM77uEV1arxxdtM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KbTHlWB72ZB9RO8a2X01THYFrHs+bFFGqfcmqDJ/LH3Z51tbYQ5QcJofdD3ZQTRPbZsUPCZ2fZrIkfhpi2iOESMlJ2QkE74EQxA9FaFwZ16MCqeB0LyKe14q1NN/bfmDsSpzquyED1UvpVvkVY2ITWtaRq/7K29pUFUDVw9BaI0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=p0rK6aAk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="p0rK6aAk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0D50C4CEF7; Mon, 23 Mar 2026 16:19:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1774282770; bh=/uY2nOPjpYlr6g8/PPxT2hrLGJH1jM77uEV1arxxdtM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p0rK6aAkjvBx8TqVKQQArlnD9OePEmq4IYkeWIbkLx3VbEUSK0ABfg9blF3nnUa1i avoZ96j+xw8DJNSIE7nQr9czDcQroIYv3yc4d77JhPUTwFcD94sid25nAKpOj+qCA9 daS4+8y6UIu9GEXJgKJioN4LkNMNlGX1buW4Vl1I= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable , Navaneeth K Subject: [PATCH 6.1 235/481] staging: rtl8723bs: properly validate the data in rtw_get_ie_ex() Date: Mon, 23 Mar 2026 14:43:37 +0100 Message-ID: <20260323134530.869557200@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260323134525.256603107@linuxfoundation.org> References: <20260323134525.256603107@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Greg Kroah-Hartman commit f0109b9d3e1e455429279d602f6276e34689750a upstream. Just like in commit 154828bf9559 ("staging: rtl8723bs: fix out-of-bounds read in rtw_get_ie() parser"), we don't trust the data in the frame so we should check the length better before acting on it Cc: stable Assisted-by: gkh_clanker_2000 Tested-by: Navaneeth K Reviewed-by: Navaneeth K Link: https://patch.msgid.link/2026022336-arrange-footwork-6e54@gregkh Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c @@ -186,20 +186,25 @@ u8 *rtw_get_ie_ex(u8 *in_ie, uint in_len cnt = 0; - while (cnt < in_len) { + while (cnt + 2 <= in_len) { + u8 ie_len = in_ie[cnt + 1]; + + if (cnt + 2 + ie_len > in_len) + break; + if (eid == in_ie[cnt] - && (!oui || !memcmp(&in_ie[cnt+2], oui, oui_len))) { + && (!oui || (ie_len >= oui_len && !memcmp(&in_ie[cnt + 2], oui, oui_len)))) { target_ie = &in_ie[cnt]; if (ie) - memcpy(ie, &in_ie[cnt], in_ie[cnt+1]+2); + memcpy(ie, &in_ie[cnt], ie_len + 2); if (ielen) - *ielen = in_ie[cnt+1]+2; + *ielen = ie_len + 2; break; } - cnt += in_ie[cnt+1]+2; /* goto next */ + cnt += ie_len + 2; /* goto next */ } return target_ie;