From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD6331459FA; Mon, 23 Mar 2026 14:44:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774277041; cv=none; b=a0/xAwl9rFqMG83jcTeN+NC1BadG4Sf56B4QyoZNuPOWQUtwH7w1uSQxGBbrUmz4Igsb1KkSCvUC8+Vyk5T4vhm3a9HcxXXpoxQ1JI+f5vd1WOk9rrkin0BMaBiud5zzDwcWBcOjRw/nu049BPg1UTxVjEZTqjPnVM3nPxXTbHU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774277041; c=relaxed/simple; bh=R2uD3DWkv++P8etgTERNgtbGQXFCA6Y8ekVpqJiSPI4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IFFGmjqizV/uAhk+oY9wEXxd83j++OxAJyMHOCH9TkmS6uTwLFZg/AqfAqA0eDihs2taXKrghL8btc66m7F9LOtkGmNE7nxV3tXhkNPk6eoL9U647yD54CusXiINmx9oGr7VOOu6MIdVWpZyJ+5Qi8LJTzO7fdOh5NbJUVXB7DM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=icpvZxR5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="icpvZxR5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4099FC4CEF7; Mon, 23 Mar 2026 14:44:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1774277041; bh=R2uD3DWkv++P8etgTERNgtbGQXFCA6Y8ekVpqJiSPI4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=icpvZxR5stuwYsetFLx2zfadelU4Gawskga0xJvzqUxk6qf0S5ejVF60I4GYZEekE KAYe5bf/YrtbJo7eGjAzGb6SY0KLzNnhOjMkx8oU00Wmm18U0YvkWNlwOa9hiAEUUM 7tYXZKK6ga/hhv4kCt6LzMOZmUm7AU5mT1fdmU80= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Heiko Carstens , Vasily Gorbik Subject: [PATCH 6.12 300/460] s390/xor: Fix xor_xc_2() inline assembly constraints Date: Mon, 23 Mar 2026 14:44:56 +0100 Message-ID: <20260323134533.853574461@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260323134526.647552166@linuxfoundation.org> References: <20260323134526.647552166@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Heiko Carstens commit f775276edc0c505dc0f782773796c189f31a1123 upstream. The inline assembly constraints for xor_xc_2() are incorrect. "bytes", "p1", and "p2" are input operands, while all three of them are modified within the inline assembly. Given that the function consists only of this inline assembly it seems unlikely that this may cause any problems, however fix this in any case. Fixes: 2cfc5f9ce7f5 ("s390/xor: optimized xor routing using the XC instruction") Cc: stable@vger.kernel.org Signed-off-by: Heiko Carstens Reviewed-by: Vasily Gorbik Link: https://lore.kernel.org/r/20260302133500.1560531-2-hca@linux.ibm.com Signed-off-by: Vasily Gorbik Signed-off-by: Greg Kroah-Hartman --- arch/s390/lib/xor.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/arch/s390/lib/xor.c +++ b/arch/s390/lib/xor.c @@ -29,8 +29,8 @@ static void xor_xc_2(unsigned long bytes " j 3f\n" "2: xc 0(1,%1),0(%2)\n" "3:\n" - : : "d" (bytes), "a" (p1), "a" (p2) - : "0", "1", "cc", "memory"); + : "+d" (bytes), "+a" (p1), "+a" (p2) + : : "0", "1", "cc", "memory"); } static void xor_xc_3(unsigned long bytes, unsigned long * __restrict p1,