From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD78C3AF66A; Mon, 23 Mar 2026 14:53:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774277620; cv=none; b=iiyXVDNe00z15iMO+bqeux7QRESKxsgeE5NeBw1gD2GlyebWn4sjOUd0mxqfVSWk5fQauADE540g1bNru/PqYsuX6+aj4MX2WMENLVj0SPgL1p4D5J79L2gKH1Y74DReClMGPk2/nu6G2W0FKUHPMj4LTWJTsLmF89gTtZ2Nb1I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774277620; c=relaxed/simple; bh=0etu4/JAD+lxf6/p8bCARvQ8nPMT6TrcIfARZ5bzTf4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cUwaf/WUeyE6NnyoeOvBQOLgBIbn0237T9aEpVDd+yG6wPKCELwU9kHkqG8p8tLaFrhiNiIoVv6JOm6b3J5yS/3AAoxePLrBkK+eAKhga4aJgYGgkrMBz2jOyb0Q7iLGYsmjVt4PXKgs6KG+cfVKKgZly25KSiIZnPm1Jg94nPM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=tJIMFAfa; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="tJIMFAfa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43653C2BCB1; Mon, 23 Mar 2026 14:53:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1774277620; bh=0etu4/JAD+lxf6/p8bCARvQ8nPMT6TrcIfARZ5bzTf4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tJIMFAfaG5v+dD3EDYQQ/MmXJ0By/J96Ne2jFqBKOYnJX3XO8hwUC231WKrUGTo0E rZAPWOWXdA/U3NX/Ey/ToqeoZREyV0a111vjCNWPHsBAyztEEC0R4YARSTjQNwZWl1 mrThqi5O9ZGGaur2PLw48ebL7wVBaPtiZ1PTcTsw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yong Wu , Miaoqian Lin , Johan Hovold , Krzysztof Kozlowski , Sasha Levin Subject: [PATCH 6.6 028/567] memory: mtk-smi: fix device leaks on common probe Date: Mon, 23 Mar 2026 14:39:08 +0100 Message-ID: <20260323134534.472747630@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260323134533.749096647@linuxfoundation.org> References: <20260323134533.749096647@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold [ Upstream commit 6cfa038bddd710f544076ea2ef7792fc82fbedd6 ] Make sure to drop the reference taken when looking up the SMI device during common probe on late probe failure (e.g. probe deferral) and on driver unbind. Fixes: 47404757702e ("memory: mtk-smi: Add device link for smi-sub-common") Fixes: 038ae37c510f ("memory: mtk-smi: add missing put_device() call in mtk_smi_device_link_common") Cc: stable@vger.kernel.org # 5.16: 038ae37c510f Cc: stable@vger.kernel.org # 5.16 Cc: Yong Wu Cc: Miaoqian Lin Signed-off-by: Johan Hovold Link: https://patch.msgid.link/20251121164624.13685-2-johan@kernel.org Signed-off-by: Krzysztof Kozlowski Signed-off-by: Sasha Levin --- drivers/memory/mtk-smi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c index 572c7fbdcfd3a..668afd12e4c51 100644 --- a/drivers/memory/mtk-smi.c +++ b/drivers/memory/mtk-smi.c @@ -563,6 +563,7 @@ static int mtk_smi_larb_probe(struct platform_device *pdev) err_pm_disable: pm_runtime_disable(dev); device_link_remove(dev, larb->smi_common_dev); + put_device(larb->smi_common_dev); return ret; } @@ -801,6 +802,7 @@ static void mtk_smi_common_remove(struct platform_device *pdev) if (common->plat->type == MTK_SMI_GEN2_SUB_COMM) device_link_remove(&pdev->dev, common->smi_common_dev); pm_runtime_disable(&pdev->dev); + put_device(common->smi_common_dev); } static int __maybe_unused mtk_smi_common_resume(struct device *dev) -- 2.51.0