From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A2D43AF648; Mon, 23 Mar 2026 14:52:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774277564; cv=none; b=cvvSO7e6aKuOlfIq2R8CIUFWH6ynzCdcjZG7LoqQSMACOIBVp0kmOliIKP0m20QbTWpA3WP+bRuy5GqiMVpBqVxtcGLpbHgESgICwNOM2CbfaCbfwGVZDcJvS9uq+hS5Y8pXk5g/qM4B2FIcq+4nhPFGzuFiLviGkZH6fEKJbeA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774277564; c=relaxed/simple; bh=yx4QRF8ovGsW5TXRdN2DJ3K1YJI6wrsU4zsF3zKw6Y8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=idCBcsaGs3e/M8L5HSfbeHI6/ID00yG68/5kt0QJeQrIX9mE6hDC8bAxALLmf4rd7ewYFIu633R4mpDqrcu23aif5WjBXRt17iTp751qtkNIV9YW7p0hUaIZuLtgEEapAh6zXX2Uo7+gUhuL1b8zFcAjSzP9ZQGsNQG9jW1b0Vc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=dXU7mC2n; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="dXU7mC2n" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BFA26C4CEF7; Mon, 23 Mar 2026 14:52:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1774277564; bh=yx4QRF8ovGsW5TXRdN2DJ3K1YJI6wrsU4zsF3zKw6Y8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dXU7mC2n225IMjilqjuQ63PJy6N21YHaUH3M9SBAsedFUrsxGepZ7rao58zzbCeSV PANAmM7xDpasEkp++Z73Fhhr83EyWkmorsWNAYrTwJftjtmdgSm0OqpG96UFscl4Tl qc2nBiR+EYotCNwXigyyIHGRg3tob+nXsyO7awOw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Bjorn Helgaas , Andy Shevchenko , Christian Marangi , Sasha Levin Subject: [PATCH 6.6 033/567] PCI: Use resource_set_range() that correctly sets ->end Date: Mon, 23 Mar 2026 14:39:13 +0100 Message-ID: <20260323134534.604140390@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260323134533.749096647@linuxfoundation.org> References: <20260323134533.749096647@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ilpo Järvinen [ Upstream commit 11721c45a8266a9d0c9684153d20e37159465f96 ] __pci_read_base() sets resource start and end addresses when resource is larger than 4G but pci_bus_addr_t or resource_size_t are not capable of representing 64-bit PCI addresses. This creates a problematic resource that has non-zero flags but the start and end addresses do not yield to resource size of 0 but 1. Replace custom resource addresses setup with resource_set_range() that correctly sets end address as -1 which results in resource_size() returning 0. For consistency, also use resource_set_range() in the other branch that does size based resource setup. Fixes: 23b13bc76f35 ("PCI: Fail safely if we can't handle BARs larger than 4GB") Link: https://lore.kernel.org/all/20251207215359.28895-1-ansuelsmth@gmail.com/T/#m990492684913c5a158ff0e5fc90697d8ad95351b Signed-off-by: Ilpo Järvinen Signed-off-by: Bjorn Helgaas Reviewed-by: Andy Shevchenko Cc: stable@vger.kernel.org Cc: Christian Marangi Link: https://patch.msgid.link/20251208145654.5294-1-ilpo.jarvinen@linux.intel.com Signed-off-by: Sasha Levin --- drivers/pci/probe.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 92f1902afa3b7..d90ffbb47f0e2 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -263,8 +263,7 @@ int __pci_read_base(struct pci_dev *dev, enum pci_bar_type type, if ((sizeof(pci_bus_addr_t) < 8 || sizeof(resource_size_t) < 8) && sz64 > 0x100000000ULL) { res->flags |= IORESOURCE_UNSET | IORESOURCE_DISABLED; - res->start = 0; - res->end = 0; + resource_set_range(res, 0, 0); pci_err(dev, "%s: can't handle BAR larger than 4GB (size %#010llx)\n", res_name, (unsigned long long)sz64); goto out; @@ -273,8 +272,7 @@ int __pci_read_base(struct pci_dev *dev, enum pci_bar_type type, if ((sizeof(pci_bus_addr_t) < 8) && l) { /* Above 32-bit boundary; try to reallocate */ res->flags |= IORESOURCE_UNSET; - res->start = 0; - res->end = sz64 - 1; + resource_set_range(res, 0, sz64); pci_info(dev, "%s: can't handle BAR above 4GB (bus address %#010llx)\n", res_name, (unsigned long long)l64); goto out; -- 2.51.0