From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FB6523E33D; Mon, 23 Mar 2026 14:56:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774277800; cv=none; b=pmBWFn18ZTpyvvXCEBbAuA5Qxwtk9OmcvsRuNra4M3uchBlnIXeWJjcw4mLHiD3/1H1b6zxULvwCbVHxVw22n8wvUSZL43xAulLA83uB76IW1RT7cGh/70s5344hdx1shwyGs9LsxQXzTB5Ii78uw14I2SMyiyXnV9kJoi042w0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774277800; c=relaxed/simple; bh=5ZgTMgnDEUYLrU7VKnDPdoyNnbecHMwMXXgSCsjUdj0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ie/28CI0S6fbnYne2/v6KDDAStJ+LJmVUX/RQeWJX7GPGJ6jkO5EYi02UXl7IimmK83xJpHfSP/lzSc7wpWjZz8Fi4jO7JGD119J5Kk3Jsywq4UEgb8OYQKFN1YQh5xLR1ShXxOuLzyCngciNHYRbFz9Lhm/VBWcntXbAmbBhFc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=emDo9rLG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="emDo9rLG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F39CFC4CEF7; Mon, 23 Mar 2026 14:56:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1774277800; bh=5ZgTMgnDEUYLrU7VKnDPdoyNnbecHMwMXXgSCsjUdj0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=emDo9rLG7PW28yeh5RKQ5Hdn9zDUXHtOV07wCsoc3Ac0K44PAWQDtkbPn+rmzFye7 bHY9RqFgkSQcUjsM2RXlMR9NEYsyQ+R4JUHI4hRZbTP6Tq20BkRMnhvUjm0mYPgMRO fjmthj1qOpESHQQPlTHRxuxpfye6EOOQj1MQseA4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jason Gunthorpe , Leon Romanovsky Subject: [PATCH 6.6 108/567] IB/mthca: Add missed mthca_unmap_user_db() for mthca_create_srq() Date: Mon, 23 Mar 2026 14:40:28 +0100 Message-ID: <20260323134536.490868710@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260323134533.749096647@linuxfoundation.org> References: <20260323134533.749096647@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jason Gunthorpe commit 117942ca43e2e3c3d121faae530989931b7f67e1 upstream. Fix a user triggerable leak on the system call failure path. Cc: stable@vger.kernel.org Fixes: ec34a922d243 ("[PATCH] IB/mthca: Add SRQ implementation") Signed-off-by: Jason Gunthorpe Link: https://patch.msgid.link/2-v1-83e918d69e73+a9-rdma_udata_rc_jgg@nvidia.com Signed-off-by: Leon Romanovsky Signed-off-by: Greg Kroah-Hartman --- drivers/infiniband/hw/mthca/mthca_provider.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/drivers/infiniband/hw/mthca/mthca_provider.c +++ b/drivers/infiniband/hw/mthca/mthca_provider.c @@ -428,6 +428,8 @@ static int mthca_create_srq(struct ib_sr if (context && ib_copy_to_udata(udata, &srq->srqn, sizeof(__u32))) { mthca_free_srq(to_mdev(ibsrq->device), srq); + mthca_unmap_user_db(to_mdev(ibsrq->device), &context->uar, + context->db_tab, ucmd.db_index); return -EFAULT; } @@ -436,6 +438,7 @@ static int mthca_create_srq(struct ib_sr static int mthca_destroy_srq(struct ib_srq *srq, struct ib_udata *udata) { + mthca_free_srq(to_mdev(srq->device), to_msrq(srq)); if (udata) { struct mthca_ucontext *context = rdma_udata_to_drv_context( @@ -446,8 +449,6 @@ static int mthca_destroy_srq(struct ib_s mthca_unmap_user_db(to_mdev(srq->device), &context->uar, context->db_tab, to_msrq(srq)->db_index); } - - mthca_free_srq(to_mdev(srq->device), to_msrq(srq)); return 0; }