From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CD8D253958; Mon, 23 Mar 2026 15:07:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774278459; cv=none; b=TN6mNGTAizm0SKXFlAiWeptNPFMp5uFyS1lBsUWkqvEwvDFl4tTPC3zhKa179dfpSNTpdiy8N+fVvWBKLfAb+dSF8VZMtP8jliXoHZD8nQaay7yrBYukRV9k2vV3sd9rw5ox/k6YOLkzGm4SNVNwzMriZwl2K9pY2kNg+aaECkE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774278459; c=relaxed/simple; bh=QkwupSL4pOWLIsVzW44P5l9N7T5SlMKhsNrX9WsONm8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=t0eFNIiC75OvizNf4gHX+IAy3kynh6zHjJnMICdWrGHGfQbcG+eRpVQXeefvsKovqFXZlJefTkGi3NUk1xxfOOCxXNbO/0eMu/b4JtmWF1ZvxNLDLy+R/VfwV0N5ON+kRxX0WDSzOuhdFN8OidRFD8pfDIVtxNwRwzMZGrhuGBk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=PSzEASe9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="PSzEASe9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A20BBC2BC9E; Mon, 23 Mar 2026 15:07:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1774278459; bh=QkwupSL4pOWLIsVzW44P5l9N7T5SlMKhsNrX9WsONm8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PSzEASe9de3vtLx2SsqZF3IPi02WAVja8B+OJE3txFjGaMvzW+PHmGjF5tU7ir7N0 pipUmmMUT7DfwZJijiXnqBJCCZRwWVK55ENAyatqMJ3LE3oYVlRyiQFx4kRZN9YmZh tKNzEX9HWvOdIWV4MXM/pcHCl0+xvRINCkyNTG5Q= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Aleksandr Loktionov , Piotr Kwapulinski , Paul Menzel , Jedrzej Jagielski , Rafal Romanowski , Tony Nguyen Subject: [PATCH 6.6 313/567] ixgbevf: fix link setup issue Date: Mon, 23 Mar 2026 14:43:53 +0100 Message-ID: <20260323134541.570731393@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260323134533.749096647@linuxfoundation.org> References: <20260323134533.749096647@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jedrzej Jagielski commit feae40a6a178bb525a15f19288016e5778102a99 upstream. It may happen that VF spawned for E610 adapter has problem with setting link up. This happens when ixgbevf supporting mailbox API 1.6 cooperates with PF driver which doesn't support this version of API, and hence doesn't support new approach for getting PF link data. In that case VF asks PF to provide link data but as PF doesn't support it, returns -EOPNOTSUPP what leads to early bail from link configuration sequence. Avoid such situation by using legacy VFLINKS approach whenever negotiated API version is less than 1.6. To reproduce the issue just create VF and set its link up - adapter must be any from the E610 family, ixgbevf must support API 1.6 or higher while ixgbevf must not. Fixes: 53f0eb62b4d2 ("ixgbevf: fix getting link speed data for E610 devices") Reviewed-by: Aleksandr Loktionov Reviewed-by: Piotr Kwapulinski Reviewed-by: Paul Menzel Cc: stable@vger.kernel.org Signed-off-by: Jedrzej Jagielski Tested-by: Rafal Romanowski Signed-off-by: Tony Nguyen Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/intel/ixgbevf/vf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/net/ethernet/intel/ixgbevf/vf.c +++ b/drivers/net/ethernet/intel/ixgbevf/vf.c @@ -852,7 +852,8 @@ static s32 ixgbevf_check_mac_link_vf(str if (!mac->get_link_status) goto out; - if (hw->mac.type == ixgbe_mac_e610_vf) { + if (hw->mac.type == ixgbe_mac_e610_vf && + hw->api_version >= ixgbe_mbox_api_16) { ret_val = ixgbevf_get_pf_link_state(hw, speed, link_up); if (ret_val) goto out;