From: SeongJae Park <sj@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: SeongJae Park <sj@kernel.org>, Josh Law <objecting@objecting.org>,
damon@lists.linux.dev, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [v3 1/3] mm/damon/sysfs: fix param_ctx leak on damon_sysfs_new_test_ctx() failure
Date: Mon, 23 Mar 2026 08:24:52 -0700 [thread overview]
Message-ID: <20260323152453.81603-1-sj@kernel.org> (raw)
In-Reply-To: <0bf54287-b6c1-4359-823c-e47db6f7830b@web.de>
On Mon, 23 Mar 2026 09:25:52 +0100 Markus Elfring <Markus.Elfring@web.de> wrote:
> > Markus these patches are already merged
It's still in mm-hotfixes-unstable. We can still make changes if needed.
I understand what Markus is suggesting is adding another goto label to make
the flow cleaner. Because this is a hotfix that aims to be also applied to
stable kernels, I think the change is better to be as simple as possible.
Adding another goto label could make it better, but I'm concerned if it will
make porting difficult.
IMHO, it is better to do that as a followup cleanup, rather than make change
into the hotfix. Let me know if this change is somewhat critical and I'm
missing that.
>
> Are there still development interests for the application of a better goto chain?
Sure, if it makes it better, why not? :)
Thanks,
SJ
[...]
next prev parent reply other threads:[~2026-03-23 15:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-21 17:54 [PATCH v3 0/3] mm/damon/sysfs: fix memory leak and NULL dereference issues SeongJae Park
2026-03-21 17:54 ` [PATCH v3 1/3] mm/damon/sysfs: fix param_ctx leak on damon_sysfs_new_test_ctx() failure SeongJae Park
2026-03-23 7:28 ` Markus Elfring
2026-03-23 7:33 ` Josh Law
2026-03-23 8:25 ` [v3 " Markus Elfring
2026-03-23 15:24 ` SeongJae Park [this message]
2026-03-23 15:48 ` Josh Law
2026-03-23 16:48 ` Josh Law
2026-03-24 0:14 ` SeongJae Park
2026-03-24 7:06 ` Josh Law
2026-03-24 14:15 ` SeongJae Park
2026-03-24 15:23 ` Josh Law
2026-03-21 17:54 ` [PATCH v3 2/3] mm/damon/sysfs: check contexts->nr before accessing contexts_arr[0] SeongJae Park
2026-03-21 17:54 ` [PATCH v3 3/3] mm/damon/sysfs: check contexts->nr in repeat_call_fn SeongJae Park
2026-03-21 20:05 ` SeongJae Park
2026-03-21 20:10 ` SeongJae Park
2026-03-21 20:04 ` (sashiko review status) [PATCH v3 0/3] mm/damon/sysfs: fix memory leak and NULL dereference issues SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260323152453.81603-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=Markus.Elfring@web.de \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=objecting@objecting.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox