From: Greg KH <gregkh@linuxfoundation.org>
To: Ghadi Elie Rahme <ghadi.rahme@canonical.com>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH 6.1.y] smb/dfs_cache: Fix NULL pointer dereference on session connection failure
Date: Mon, 23 Mar 2026 13:59:59 +0100 [thread overview]
Message-ID: <2026032355-portfolio-corral-c5de@gregkh> (raw)
In-Reply-To: <20260303173139.517020-1-ghadi.rahme@canonical.com>
On Tue, Mar 03, 2026 at 07:31:39PM +0200, Ghadi Elie Rahme wrote:
> [ Upstream commit 6916881f443f67f6893b504fa2171468c8aed915 ]
No, that is NOT what this commit id is.
> It is possible for find_ipc_from_server_path to run while the tcon is NULL,
> resulting in a NULL pointer dereference crash when calling strcasecmp().
> This happens when the ipc connection fails freeing the tcon and setting it
> to NULL while the dfs cache worker thread was already executing.
> This issue was fixed upstream indirectly by a rewrite that removed this
> function. Although with this fix the issue can still occur, the window of
> the race is now much narrower.
> A fix that would completely fix it using mutexes was tested and
> worked fine. However the regression potential would be much higher and so
> would be the deviation from upstream.
> This is a good balance of safety while minimizing upstream deviation.
No, please use the upstream commits instead. Also, you did not cc: any
of the maintainers or developers involved here, which would mean we
couldn't take this anyway.
sorry.
greg k-h
prev parent reply other threads:[~2026-03-23 13:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 17:31 [PATCH 6.1.y] smb/dfs_cache: Fix NULL pointer dereference on session connection failure Ghadi Elie Rahme
2026-03-23 12:59 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026032355-portfolio-corral-c5de@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=ghadi.rahme@canonical.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox