From: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
To: mptcp@lists.linux.dev, stable@vger.kernel.org,
gregkh@linuxfoundation.org
Cc: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>, sashal@kernel.org
Subject: [PATCH 6.1.y 1/2] selftests: mptcp: join: implicit: stop transfer after last check
Date: Tue, 24 Mar 2026 10:49:38 +0100 [thread overview]
Message-ID: <20260324094936.1826804-5-matttbe@kernel.org> (raw)
In-Reply-To: <20260324094936.1826804-4-matttbe@kernel.org>
With this kernel version, the 'implicit EP' MPTCP Join selftest ended
with an error message:
115 implicit EP creation[ ok ]
ID change is prevented[ ok ]
modif is allowed[ ok ]
TcpPassiveOpens 2 0.0
TcpEstabResets 2 0.0
TcpInSegs 315 0.0
TcpOutSegs 617 0.0
TcpOutRsts 1 0.0
TcpExtDelayedACKs 289 0.0
TcpExtTCPPureAcks 6 0.0
TcpExtTCPOrigDataSent 306 0.0
TcpExtTCPDelivered 306 0.0
MPTcpExtMPCapableSYNRX 1 0.0
MPTcpExtMPCapableACKRX 1 0.0
MPTcpExtMPJoinSynRx 1 0.0
MPTcpExtMPJoinAckRx 1 0.0
MPTcpExtAddAddr 1 0.0
MPTcpExtEchoAdd 1 0.0
MPTcpExtMPFastcloseTx 1 0.0
MPTcpExtMPRstTx 1 0.0
MPTcpExtMPRstRx 1 0.0
TcpActiveOpens 2 0.0
TcpEstabResets 2 0.0
TcpInSegs 617 0.0
TcpOutSegs 315 0.0
TcpOutRsts 1 0.0
TcpExtTCPPureAcks 308 0.0
TcpExtTCPOrigDataSent 306 0.0
TcpExtTCPDelivered 307 0.0
MPTcpExtMPCapableSYNTX 1 0.0
MPTcpExtMPCapableSYNACKRX 1 0.0
MPTcpExtMPJoinSynAckRx 1 0.0
MPTcpExtAddAddr 1 0.0
MPTcpExtEchoAdd 1 0.0
MPTcpExtMPFastcloseRx 1 0.0
MPTcpExtMPRstTx 1 0.0
MPTcpExtMPRstRx 1 0.0
MPTcpExtRcvWndShared 1 0.0
That's because the test was waiting for the end of the transfer for no
reasons, which ended after a timeout with an error. In this case, the
stats were displayed, but this error was ignored: the end of transfer is
not validated in this test.
To fix that, stop the transfer after the last check, similar to what is
done in the other tests.
Fixes: 699879d5f866 ("selftests: mptcp: join: endpoints: longer transfer")
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh
index 80497053fe2f..044ba9c4e169 100755
--- a/tools/testing/selftests/net/mptcp/mptcp_join.sh
+++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh
@@ -3429,6 +3429,7 @@ endpoint_tests()
pm_nl_set_limits $ns2 2 2
pm_nl_add_endpoint $ns1 10.0.2.1 flags signal
run_tests $ns1 $ns2 10.0.1.1 128 0 0 slow 2>/dev/null &
+ local tests_pid=$!
wait_mpj $ns1
pm_nl_check_endpoint 1 "creation" \
@@ -3441,6 +3442,7 @@ endpoint_tests()
pm_nl_add_endpoint $ns2 10.0.2.2 flags signal
pm_nl_check_endpoint 0 "modif is allowed" \
$ns2 10.0.2.2 id 1 flags signal
+ kill_wait "${tests_pid}"
kill_tests_wait
fi
--
2.53.0
next prev parent reply other threads:[~2026-03-24 9:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 9:49 [PATCH 6.1.y 0/2] selftests: mptcp: specific fixes for v6.1 Matthieu Baerts (NGI0)
2026-03-24 9:49 ` Matthieu Baerts (NGI0) [this message]
2026-03-24 9:49 ` [PATCH 6.1.y 2/2] selftests: mptcp: join: check removing signal+subflow endp Matthieu Baerts (NGI0)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260324094936.1826804-5-matttbe@kernel.org \
--to=matttbe@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=mptcp@lists.linux.dev \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox