From: Cathy Xu <ot_cathy.xu@mediatek.com>
To: Chaotian Jing <chaotian.jing@mediatek.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>
Cc: <linux-mmc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
Mengqi Zhang <Mengqi.Zhang@mediatek.com>,
Wenbin Mei <Wenbin.Mei@mediatek.com>,
Andy-ld Lu <Andy-ld.Lu@mediatek.com>,
Axe Yang <Axe.Yang@mediatek.com>,
Yong Mao <yong.mao@mediatek.com>,
Cathy Xu <ot_cathy.xu@mediatek.com>, <stable@vger.kernel.org>
Subject: [PATCH RESEND] mmc: mtk-sd: disable new_tx/rx and modify related settings for mt8189
Date: Thu, 26 Mar 2026 11:05:16 +0800 [thread overview]
Message-ID: <20260326030759.8107-1-ot_cathy.xu@mediatek.com> (raw)
Disable new_tx/rx to avoid data transmission instability, and adjust
.data_tune, .stop_dly_sel, and .pop_en_cnt to fit the overall
configuration after disabling new_tx/rx, making it more compatible
with mt8189.
Fixes: 846a3a2fdff5 ("mmc: mtk-sd: add support for MT8189 SoC")
Cc: stable@vger.kernel.org
Tested-by: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>
Signed-off-by: Cathy Xu <ot_cathy.xu@mediatek.com>
---
drivers/mmc/host/mtk-sd.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 302ac8529c4f..b2680cc054bd 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -682,15 +682,15 @@ static const struct mtk_mmc_compatible mt8189_compat = {
.needs_top_base = true,
.pad_tune_reg = MSDC_PAD_TUNE0,
.async_fifo = true,
- .data_tune = true,
+ .data_tune = false,
.busy_check = true,
.stop_clk_fix = true,
- .stop_dly_sel = 1,
- .pop_en_cnt = 2,
+ .stop_dly_sel = 3,
+ .pop_en_cnt = 8,
.enhance_rx = true,
.support_64g = true,
- .support_new_tx = true,
- .support_new_rx = true,
+ .support_new_tx = false,
+ .support_new_rx = false,
.support_spm_res_release = true,
};
--
2.45.2
next reply other threads:[~2026-03-26 3:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 3:05 Cathy Xu [this message]
2026-03-26 12:34 ` [PATCH RESEND] mmc: mtk-sd: disable new_tx/rx and modify related settings for mt8189 Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260326030759.8107-1-ot_cathy.xu@mediatek.com \
--to=ot_cathy.xu@mediatek.com \
--cc=Andy-ld.Lu@mediatek.com \
--cc=Axe.Yang@mediatek.com \
--cc=Mengqi.Zhang@mediatek.com \
--cc=Wenbin.Mei@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chaotian.jing@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=louisalexis.eyraud@collabora.com \
--cc=matthias.bgg@gmail.com \
--cc=stable@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=yong.mao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox