From: Jason Gunthorpe <jgg@ziepe.ca>
To: Alex Williamson <alex.williamson@nvidia.com>
Cc: alex@shazbot.org, kvm@vger.kernel.org,
Renato Marziano <renato@marziano.top>,
stable@vger.kernel.org, Leon Romanovsky <leonro@nvidia.com>
Subject: Re: [PATCH] vfio/pci: Fix double free in dma-buf feature
Date: Thu, 26 Mar 2026 09:12:20 -0300 [thread overview]
Message-ID: <20260326121220.GH8437@ziepe.ca> (raw)
In-Reply-To: <20260323215659.2108191-3-alex.williamson@nvidia.com>
On Mon, Mar 23, 2026 at 03:56:58PM -0600, Alex Williamson wrote:
> The error path through vfio_pci_core_feature_dma_buf() ignores its
> own advice to only use dma_buf_put() after dma_buf_export(), instead
> falling through the entire unwind chain. In the unlikely event that
> we encounter file descriptor exhaustion, this can result in an
> unbalanced refcount on the vfio device and double free of allocated
> objects.
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
prev parent reply other threads:[~2026-03-26 12:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 21:56 [PATCH] vfio/pci: Fix double free in dma-buf feature Alex Williamson
2026-03-26 12:12 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260326121220.GH8437@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=alex.williamson@nvidia.com \
--cc=alex@shazbot.org \
--cc=kvm@vger.kernel.org \
--cc=leonro@nvidia.com \
--cc=renato@marziano.top \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox