From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs1-f42.google.com (mail-vs1-f42.google.com [209.85.217.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 588972D1931 for ; Sun, 29 Mar 2026 07:16:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774768594; cv=none; b=VyLl6afgdWevLzZvZlD1FkR7QPSz4dTkWAppgwtX/PukHxunrowUktXHwmz93KtBkzXcQnYrpc9Fhq4P+lircqfqjmshPjkhsBjAsRY9nOOi/t/WrJsRGzL5WkAcdiPyPEg2UxiYChOHHGrVfw+u2+BcO62VTlIvO6Y6IFwzBIQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774768594; c=relaxed/simple; bh=nEeadJO/2VXHlqj2GhD2b9UbKa7ccc0BljwIKBpHWLM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ksEnFtua/Phq6UqqDGJwsiXHE0Htg1Z92dmPObcImk6ujsv4q0zqVXm5ms3yGYkQ5URvD2LhMQIvVTrSJh4wwOdKXI9LziIh28ci28IUcmXXanT71hbeCLwZnjKm+rgAT+ru8Ko97iwfAf78v2ANwElZCsYF8PA2XXMclLSeYTc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=juweVOqC; arc=none smtp.client-ip=209.85.217.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="juweVOqC" Received: by mail-vs1-f42.google.com with SMTP id ada2fe7eead31-604fb44270aso586697137.2 for ; Sun, 29 Mar 2026 00:16:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774768592; x=1775373392; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nSlLWkq4h8uaqpliAQo5iTD2HSvpKos26zajciLvI7A=; b=juweVOqCT9fNZl0vp0mzqcL4q2xv1isq1BONA8nfrImCvTZ/UWsM8E8eUzoA4IxX7C JnTYL6FJrxx8+piV7K477VtWk5UCcjAPmJk3TdK4SqgIOhcugsbSUkRjFhCSCW/69/z9 7Jta9SV4mQiD8SYiDcwy6Md57JEylxK2E6BhfoskDREJ+PqSe5KKf6lOAc9s7L8Wix5q 72o+Slr+6P3eXsZ0016r6BLZWjWfOpoI33ujWb3ESCM+Sl5muvEtd638Zdw4fNopgBwS nEXK2XlGmh6K46mgkPtwMS3HXQbUTbB4dWDhLOmSCEi1pfNIz7DAYVh8MZkyNwJ3ou0M 0JDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774768592; x=1775373392; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=nSlLWkq4h8uaqpliAQo5iTD2HSvpKos26zajciLvI7A=; b=VncBcaPPOZGuVIlFOG4B0A7s+zYf1caRgzZH4hGfv5vROjNUGoWB1PGFnGL3HMXKOZ SBdpD3WCA5ZmGiwk36IoDyiP7TyzeYM7tYKF0vW1qRM5L/3fcQ/hLK6nOCLQBfsw2WkD k+ZtAyB6EuCF0zvIa3+048R2b9KPwNqSLIAO+orXy2ACswFdvXqPD27z9nQbpt9vD79N zt56Wxxuep1Mb56YjAd0DxwrwEgrOPfGacInG5huunrqS6bJ/4YbDWzvc4WkVGiE7E8D CodZbGIcyOJL3ZIHLxwoBxqr2s59APG6qVs3Pf/cteVCAJdV5mLjNPidBk+4kQgoormf Uhqg== X-Forwarded-Encrypted: i=1; AJvYcCVCTiEywGo4iIZjq+xfnHidx0VpM23liyKU8OgS3uuMGBvfRSW0BbumPVi3qYOIKSAo08Moa5k=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3G59h4Q/JtmqDhu8XuODU1Wk/pZDO2lBZqdJ+jaM37E43a4We 9kWBBDEBGN7eE3lkFnnhaLxuNUCncHrTDeZ16HwIt8EIrWooeiopr1OJ X-Gm-Gg: ATEYQzxeDBtZ4Qi8wQOBwlbBc0CQ/geD/E5Q5ZKOUhhU7TvWOTa8kbB20mcnjgHF48Y 421Co+rujVQHi7//gxiYuFV4fEGlVKWbv1hQivynjbCR4DtHvixNA21TDCYcje0U0UzmF91MX6F ju7CWmnFX6xV9ffRDeNngMEUgH0h/E6EhGk9fJizK/pqEuLtF0e+iqQi571Xg0ef8/dAGCFfh00 BS5G7cN/B01Mtv/6kMMGPjgXVgtwlZ7xxvXwSRCAS0moedzvF9NUdTSMiyjKAknEyDSM7AoHwQ9 Pt1CtkQW8+YYdbPDZggu72zBagsY1VtOY7XyWqV/2aTNHXGxm9gvrD8gUq8jewvFBmNrH2ui7LY 2PoFywC7HSpkTqb2/CisbcBBtwNDj/xeAqt6OC3f96FwSGySuE9cyNUPjNw8GmWDqBQZfQ5zagv OdxlxZOkL5mHHhPf+ev5Ge/V/p X-Received: by 2002:a05:6102:4421:b0:5ff:219b:497a with SMTP id ada2fe7eead31-604f8ff5ff7mr3225622137.3.1774768592246; Sun, 29 Mar 2026 00:16:32 -0700 (PDT) Received: from localhost.localdomain ([2a09:bac6:d6df:aa::11:19a]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-60512a5afa9sm4390638137.6.2026.03.29.00.16.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Mar 2026 00:16:31 -0700 (PDT) From: Sebastian Josue Alba Vives To: Greg Kroah-Hartman , Florian Fainelli Cc: bcm-kernel-feedback-list@broadcom.com, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, Dave Stevenson , kernel-list@raspberrypi.com, =?UTF-8?q?Sebasti=C3=A1n=20Alba=20Vives?= , stable@vger.kernel.org Subject: [PATCH v2 1/4] staging: vc04_services: vchiq-mmal: validate component index in event_to_host_cb() Date: Sun, 29 Mar 2026 01:15:39 -0600 Message-ID: <20260329071616.507876-2-sebasjosue84@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260329071616.507876-1-sebasjosue84@gmail.com> References: <20260329062229.493430-1-sebasjosue84@gmail.com> <20260329071616.507876-1-sebasjosue84@gmail.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Sebastián Alba Vives event_to_host_cb() uses msg->u.event_to_host.client_component as an index into the instance->component[] array (size VCHIQ_MMAL_MAX_COMPONENTS = 64) without bounds validation. While the kernel generally trusts the hardware it is bound to, a bounds check here hardens the driver against potential firmware bugs that could otherwise cause an uncontrolled out-of-bounds array access and kernel crash. Add a bounds check on comp_idx before using it as an array index and move the component pointer assignment after the validation. Use pr_err_ratelimited() to avoid log flooding. Note: this file does not currently have access to a struct device, so dev_err() is not available. Cc: stable@vger.kernel.org Fixes: b18ee53ad297 ("staging: bcm2835: Break MMAL support out from camera") Signed-off-by: Sebastián Alba Vives --- drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c index d36ad71cc..9c6533f82 100644 --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c @@ -477,12 +477,19 @@ static void event_to_host_cb(struct vchiq_mmal_instance *instance, struct mmal_msg *msg, u32 msg_len) { int comp_idx = msg->u.event_to_host.client_component; - struct vchiq_mmal_component *component = - &instance->component[comp_idx]; + struct vchiq_mmal_component *component; struct vchiq_mmal_port *port = NULL; struct mmal_msg_context *msg_context; u32 port_num = msg->u.event_to_host.port_num; + if (comp_idx < 0 || comp_idx >= VCHIQ_MMAL_MAX_COMPONENTS) { + pr_err_ratelimited("%s: component index %d out of range\n", + __func__, comp_idx); + return; + } + + component = &instance->component[comp_idx]; + if (msg->u.buffer_from_host.drvbuf.magic == MMAL_MAGIC) { pr_err("%s: MMAL_MSG_TYPE_BUFFER_TO_HOST with bad magic\n", __func__); -- 2.43.0