From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs1-f46.google.com (mail-vs1-f46.google.com [209.85.217.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C690286409 for ; Sun, 29 Mar 2026 07:16:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774768602; cv=none; b=nNRr8zB5VDwvVq7Vp0AMSN91nooBi8nGcKrRHaff9oX/A1LOOtPEhw3WuC2z4/osoxqOXKBqtbsBgWXFoap4H1AbluPVf2VBiUqVfrofy100Bmh8boo5izg7b1N7XinBV7qD/mLLx2ka8GTJLf4+pH/ZowuTfqA1W95/YeqRwVg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774768602; c=relaxed/simple; bh=JfFn5dD8fXSM0/s/rgq34bUOJdT1IsgTK5+GKwn9EYw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=e4RXawtAuyEef3Lp1LGMY996LA90KXTWM53r2DC+zw9kwNKq7S3mDn/eeLck50Qw92hOX5xVN4zehOknnCUwuxfew98iEsNmuAjaDPO5f2uB6Wd2igVm2UN+vntMdEbbkyYY77aZVdXAtmfET0wmTxgFpZLo95o1AuIlrUrN5OI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F7JYfaCZ; arc=none smtp.client-ip=209.85.217.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F7JYfaCZ" Received: by mail-vs1-f46.google.com with SMTP id ada2fe7eead31-605048a9c94so588263137.0 for ; Sun, 29 Mar 2026 00:16:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774768600; x=1775373400; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IncM+rKcgmau4uVK2sm4qPStCq75MjSeVAISYr8iaEQ=; b=F7JYfaCZ40zkTyZjD4/oo9cjgt8c8bax/h81LxTNsXwIjfCJoEazRrsMgXyVgSpMiV 73Blt8wowCB8elOrluDcCPjsYRtYVz7pOiso/eaUtfl7pcd/zDWi9wCHrzqSyhZ5i4tN CKTcwtLeIZYLDFSdZ36Kln0imkqeAXZKSWoME3+EAnXWFLczLOL1ikqr7sECibdvCYtj 8r7qBA5hv/MQNQIzAZO+KL0FOtiSfZkBnn0oQTHXSB1mDyVK0ymNZSHEOWgkAbndVf6P BmKMcfgune/yu3zuALXgBWM2D915/oZubTB+pMGUgLfnWJhBqo1tHtlZhoNmgQtVukiw d3XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774768600; x=1775373400; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=IncM+rKcgmau4uVK2sm4qPStCq75MjSeVAISYr8iaEQ=; b=asop9uvTLZsZb1DryN/Zb6pXn0jlcaNt3v7D1wUu/PAvxPPE7LzZeEsT/9Ao/Q5fuV RXPoMNKZ/P+cUF4viaC/nsYDzl8Ie96Lqvnez0rnz0jba9o1EJu3zzTsou4TdTtG8Q/u BSewbCICbkpMJv6DdrO5os7BxDADsOLmZqKVAAnTnl7mkXiCJt2T9eJxZLQNWl/mS3gh 4sMiVomy1OGqQrcYyZhkrXZL03rwDfDB0sfDvbj4wJUBhhXmqU3hMOnfSbqQMhZu39Sf vo4Otg5EnR9MerAxl1bg26PnrNCkox62q7+a4UP4Xx6fW3bBWqJ1OorKEpzcHgMDoZ6G gj3A== X-Forwarded-Encrypted: i=1; AJvYcCX7qBMA9vdoHi4pHLjSTO/eyGkJNcYzj6HOYbqoYx9N0ZE3e2gUnsX+jRXnf773dF8q5LrPSQ4=@vger.kernel.org X-Gm-Message-State: AOJu0YzmQI+aAQb9Fx4Lm048NfRod6LnNZnNdEP+XOJev05bNzv91LAT ZJB9LIl3TEF4SQDk7vwjExKx9AVvIzYhRJTWF/A/rr7UCu2i7VEmLLXh X-Gm-Gg: ATEYQzwMTGJGUWFbbON6nVfwqQXqV2EF9/37xI5UjdmnzVW4oISfN9yQ4rjRb9i1QAl R2BqHhUeM0D/VQP00YQUN5EmGCegmh9xOpdxLdkXBoKZy4PqcBWfVmKRxwBxJ2IW4v9W1D1CLbV dnTchfRvPNL7RfmAOYr0FQo8ufUMl0EgTNTm+OR0pXZTBPeFoS2otfbj7F8I2FhjJNMhkMtHEgk wHkimRIf4tb2WZpYUuBoq3kccbaL7K5KYrqsEC4QqZ1vbARRWqjvij7Zp/DbLPscpWUlUvevgnA uuXLrlGOXIehNq4utwBylJNAQ9p0hQZspIfmOhtYCBJIfth7BYPlkvxk7Dhw55m4aoXm8wGvLSW 2pofaFjbhCysQFZwt2K+3Ax3uxOpOYDyFdN5yfZ+lm3oLH33h3WiCvnXJfViJRYfde7pTUz/eiC /Zh3iwxcee/d7BSmy+vOpIcp36 X-Received: by 2002:a05:6102:41aa:b0:5f1:b7b2:8929 with SMTP id ada2fe7eead31-604f90e520cmr2908812137.15.1774768600043; Sun, 29 Mar 2026 00:16:40 -0700 (PDT) Received: from localhost.localdomain ([2a09:bac6:d6df:aa::11:19a]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-60512a5afa9sm4390638137.6.2026.03.29.00.16.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Mar 2026 00:16:39 -0700 (PDT) From: Sebastian Josue Alba Vives To: Greg Kroah-Hartman , Florian Fainelli Cc: bcm-kernel-feedback-list@broadcom.com, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, Dave Stevenson , kernel-list@raspberrypi.com, =?UTF-8?q?Sebasti=C3=A1n=20Alba=20Vives?= , stable@vger.kernel.org Subject: [PATCH v2 4/4] staging: vc04_services: vchiq-mmal: fix integer underflow in port_parameter_get() Date: Sun, 29 Mar 2026 01:15:42 -0600 Message-ID: <20260329071616.507876-5-sebasjosue84@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260329071616.507876-1-sebasjosue84@gmail.com> References: <20260329062229.493430-1-sebasjosue84@gmail.com> <20260329071616.507876-1-sebasjosue84@gmail.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Sebastián Alba Vives port_parameter_get() subtracts 2 * sizeof(u32) from the VideoCore firmware's reply size field to compute the parameter value size. If the firmware returns a size smaller than 8, the subtraction wraps around to a large value due to unsigned integer underflow. The underflowed size is then used in a comparison that selects the wrong copy path and stored back to the caller via *value_size, propagating a bogus size to subsequent operations. Add a minimum size check before the subtraction and return -EPROTO if the reply is malformed. Cc: stable@vger.kernel.org Fixes: b18ee53ad297 ("staging: bcm2835: Break MMAL support out from camera") Signed-off-by: Sebastián Alba Vives --- drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c index 18e805b92..f2bb5ce0a 100644 --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c @@ -1436,6 +1436,10 @@ static int port_parameter_get(struct vchiq_mmal_instance *instance, /* port_parameter_get_reply.size includes the header, * whilst *value_size doesn't. */ + if (rmsg->u.port_parameter_get_reply.size < (2 * sizeof(u32))) { + ret = -EPROTO; + goto release_msg; + } rmsg->u.port_parameter_get_reply.size -= (2 * sizeof(u32)); if (ret || rmsg->u.port_parameter_get_reply.size > *value_size) { -- 2.43.0