From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BD7E22D4DC for ; Sun, 29 Mar 2026 07:20:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774768843; cv=none; b=SQa+O3W8iDpH3vQ5DxILhI6SOlJaFpG5hOCcrVJtGB2gCKb5a0mPtSVoZAIZg4rVtmJ4Dn26QLBJka4cieVHlByEhmGHZ08RKR14kfYa+O5K3E9iA0r7KnuvisqEfqnvYi68K5c+HbuCc9IiL5Kc2YQ+A9ZEkYlIUpD/lSrBmCw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774768843; c=relaxed/simple; bh=Uezbc9fzUKkyTKCnuktca1J16iieX5DS/iruAOvIV4Q=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=ay6g6j47+BFviyk/Z/GSm8BmtOLMVUsqUVXDq/6/dcN7L99UZggkiJtCoxvctmb6Kw0k8/PkJOVsTZbmAwbhJlfKNDc5hw5ywlOKALUWYjQOqd+84WDxL7DBIr+psHUIhX8mXE6L6OWiAThcxi3RT4soo6F0g5znkWtJnFQqMOo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=hGe8p5zh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="hGe8p5zh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F3B4C116C6; Sun, 29 Mar 2026 07:20:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1774768842; bh=Uezbc9fzUKkyTKCnuktca1J16iieX5DS/iruAOvIV4Q=; h=Subject:To:Cc:From:Date:From; b=hGe8p5zhYm0WirTXbVf6+UfNbNNbqpvqbt4FEUjBBFgPpqXHMFKV4whmgJZ2NpKyh RUfORSYSmHsBOiAhkbciP+DL5KlbBqGcwFu2UXyeUAp7ESSU7G7U1uwONMvys6TKeG IXutJPr8L1Xai3wfFK4HD/obG+Sh8/bOd6wDrB8A= Subject: FAILED: patch "[PATCH] ksmbd: fix potencial OOB in get_file_all_info() for compound" failed to apply to 5.15-stable tree To: linkinjeon@kernel.org,manizada@pm.me,stfrench@microsoft.com Cc: From: Date: Sun, 29 Mar 2026 09:20:31 +0200 Message-ID: <2026032931-tubby-automatic-2197@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.15-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.15.y git checkout FETCH_HEAD git cherry-pick -x beef2634f81f1c086208191f7228bce1d366493d # git commit -s git send-email --to '' --in-reply-to '2026032931-tubby-automatic-2197@gregkh' --subject-prefix 'PATCH 5.15.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From beef2634f81f1c086208191f7228bce1d366493d Mon Sep 17 00:00:00 2001 From: Namjae Jeon Date: Thu, 19 Mar 2026 21:00:02 +0900 Subject: [PATCH] ksmbd: fix potencial OOB in get_file_all_info() for compound requests When a compound request consists of QUERY_DIRECTORY + QUERY_INFO (FILE_ALL_INFORMATION) and the first command consumes nearly the entire max_trans_size, get_file_all_info() would blindly call smbConvertToUTF16() with PATH_MAX, causing out-of-bounds write beyond the response buffer. In get_file_all_info(), there was a missing validation check for the client-provided OutputBufferLength before copying the filename into FileName field of the smb2_file_all_info structure. If the filename length exceeds the available buffer space, it could lead to potential buffer overflows or memory corruption during smbConvertToUTF16 conversion. This calculating the actual free buffer size using smb2_calc_max_out_buf_len() and returning -EINVAL if the buffer is insufficient and updating smbConvertToUTF16 to use the actual filename length (clamped by PATH_MAX) to ensure a safe copy operation. Cc: stable@vger.kernel.org Fixes: e2b76ab8b5c9 ("ksmbd: add support for read compound") Reported-by: Asim Viladi Oglu Manizada Signed-off-by: Namjae Jeon Signed-off-by: Steve French diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c index f5f1bf5f642e..6fb7a795ff5d 100644 --- a/fs/smb/server/smb2pdu.c +++ b/fs/smb/server/smb2pdu.c @@ -4940,7 +4940,8 @@ static int get_file_all_info(struct ksmbd_work *work, int conv_len; char *filename; u64 time; - int ret; + int ret, buf_free_len, filename_len; + struct smb2_query_info_req *req = ksmbd_req_buf_next(work); if (!(fp->daccess & FILE_READ_ATTRIBUTES_LE)) { ksmbd_debug(SMB, "no right to read the attributes : 0x%x\n", @@ -4952,6 +4953,16 @@ static int get_file_all_info(struct ksmbd_work *work, if (IS_ERR(filename)) return PTR_ERR(filename); + filename_len = strlen(filename); + buf_free_len = smb2_calc_max_out_buf_len(work, + offsetof(struct smb2_query_info_rsp, Buffer) + + offsetof(struct smb2_file_all_info, FileName), + le32_to_cpu(req->OutputBufferLength)); + if (buf_free_len < (filename_len + 1) * 2) { + kfree(filename); + return -EINVAL; + } + ret = vfs_getattr(&fp->filp->f_path, &stat, STATX_BASIC_STATS, AT_STATX_SYNC_AS_STAT); if (ret) { @@ -4995,7 +5006,8 @@ static int get_file_all_info(struct ksmbd_work *work, file_info->Mode = fp->coption; file_info->AlignmentRequirement = 0; conv_len = smbConvertToUTF16((__le16 *)file_info->FileName, filename, - PATH_MAX, conn->local_nls, 0); + min(filename_len, PATH_MAX), + conn->local_nls, 0); conv_len *= 2; file_info->FileNameLength = cpu_to_le32(conv_len); rsp->OutputBufferLength =