From: SeongJae Park <sj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: SeongJae Park <sj@kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
"# 5 . 19 . x" <stable@vger.kernel.org>,
David Hildenbrand <david@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Lorenzo Stoakes <ljs@kernel.org>, Michal Hocko <mhocko@suse.com>,
Mike Rapoport <rppt@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>,
Suren Baghdasaryan <surenb@google.com>,
Vlastimil Babka <vbabka@kernel.org>,
damon@lists.linux.dev, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Roman Gushchin <roman.gushchin@linux.dev>
Subject: Re: (sashiko status) [PATCH 0/2] Docs/admin-guide/mm/damon: warn commit_inputs vs other params race
Date: Mon, 30 Mar 2026 21:52:45 -0700 [thread overview]
Message-ID: <20260331045245.67438-1-sj@kernel.org> (raw)
In-Reply-To: <20260330142205.e7c7d7b47ec15a634f6eebf4@linux-foundation.org>
On Mon, 30 Mar 2026 14:22:05 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:
> On Sun, 29 Mar 2026 12:32:26 -0700 SeongJae Park <sj@kernel.org> wrote:
>
> > On Sun, 29 Mar 2026 20:05:53 +0200 Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > > On Sun, Mar 29, 2026 at 08:49:16AM -0700, SeongJae Park wrote:
> > > > Forwarding sashiko.dev review status for this thread.
> > > >
> > > > # review url: https://sashiko.dev/#/patchset/20260329153052.46657-1-sj@kernel.org
> > >
> > > Why are you doing this? If we want to see the review, can't we just go
> > > and look at the tool itself?
> >
> > We can. But it is bit cumbersome to opening web browser and moving my focus to
> > there. Reading everything on the mailing tool is easier for some people like
> > me. Like some test bots send reports are replying to patches, or we sometimes
> > forwarding bugzilla reports to mailing lists in a form of a plain text mail.
> >
> > Secondly, I have to share my opinions about the reviews, as many times AI
> > reviews need human's opinions. There is no good way to do that on the web ui
> > of the tool (sashiko) for now, and I think this mail based flow is the best.
>
> I do agree with Greg that it's all a bit excessive. Thanks for your
> your diligence, but perhaps dial it back a bit? It's OK - we're all
> trying to figure out how best to utilize this tool.
Thank you for your kind words, Andrew. I understand and admit the fact that
this looks excessive.
>
> I view Sashiko as primarily an author tool. Sometimes I call it
> checkpatch++.
Thank you for sharing your perspective. This is helpful at what you want from
the use of the tool, thank you.
My view of sashiko was a human reviewer that having very odd characteristic and
cannot answer to my feedback for a reason, but still being useful in many
cases. Hence I wanted to help the special reviewer be able to communicate with
others on the mailing list. And I was thinking anyway that's what sashiko will
do, because I saw sending review as mail as one of TODO items for sashiko, from
the public announcement, and I onboarded DAMON for that.
But apparently not everyone is sharing same view. My understanding of the TODO
item in sashiko public announcement may also be biased. Maybe being a
subsystem's sole maintainer that looking for a reviewer made such uncautiously
biased perspectives.
> In a better world, author would be able to sort out
> Sashiko issues before ever sending out the patchset. But in this
> world, a public send is needed to obtain that review.
>
> So what we're presently seeing is author development activity which is
> unfortunately and inappropriately being conducted on a public list.
Makes sense. Now I understand why you and Roman were discussing having a
separate mailing list for sharing the reviews via mail as a path forward, and
I agree that could be a good option.
>
> Personally, I pay only a little attention to author's Sashiko activity.
> Just enough to see whether I should pay more attention. If author
> says "oops, let me redo" then fine, I'll await the next spin. If
> author says "that was all nonsense" then fine, time to take a closer
> look.
Makes sense. I will try to keep sharing necessary information, but for only
targetted audiences, with less traffic.
Thanks,
SJ
next prev parent reply other threads:[~2026-03-31 4:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-29 15:30 [PATCH 0/2] Docs/admin-guide/mm/damon: warn commit_inputs vs other params race SeongJae Park
2026-03-29 15:30 ` [PATCH 1/2] Docs/admin-guide/mm/damon/reclaim: warn commit_inputs vs param updates race SeongJae Park
2026-03-29 15:49 ` (sashiko review) " SeongJae Park
2026-03-29 15:54 ` SeongJae Park
2026-03-29 15:30 ` [PATCH 2/2] Docs/admin-guide/mm/damon/lru_sort: " SeongJae Park
2026-03-29 15:49 ` (sashiko review) " SeongJae Park
2026-03-29 15:55 ` SeongJae Park
2026-03-29 15:49 ` (sashiko status) [PATCH 0/2] Docs/admin-guide/mm/damon: warn commit_inputs vs other params race SeongJae Park
2026-03-29 16:31 ` SeongJae Park
2026-03-29 18:05 ` Greg KH
2026-03-29 19:32 ` SeongJae Park
2026-03-30 5:47 ` Greg KH
2026-03-30 6:39 ` Andrew Morton
2026-03-31 4:34 ` SeongJae Park
2026-03-30 21:22 ` Andrew Morton
2026-03-31 4:52 ` SeongJae Park [this message]
2026-03-31 12:19 ` Theodore Tso
2026-03-31 15:55 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260331045245.67438-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=damon@lists.linux.dev \
--cc=david@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=roman.gushchin@linux.dev \
--cc=rppt@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=stable@vger.kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox