From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13B7E3F54AD for ; Tue, 31 Mar 2026 14:25:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774967137; cv=none; b=o6RvFRFY8tjoWyItXqtjRhLAXJazDbkPu7hqbBvKmGz2dU9uUQVVyzc9Zd4xHQiDEwx2deVABfuuauAiCXNTONT2dmhBIcHimeF+m5+RRKN2pKcNskB309NDF8YZcdEQ+1cRryixC7hSjsZeqdx1QxGHgVLWskxUR6MCXCw5ecQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774967137; c=relaxed/simple; bh=5bcoGgxrpwVyUOYA1eEQmIr35+1q7oEyf8faEnK/eOA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mZ0wnsHhX+vIqLcKBAVS9/tyVKaserUrd8HXYm0DCLWkFcPiNATE1cQc54jVVrvSk63HWdZQvncSi7i9luxwo0TbXsPN1aWP1GGwPYOPDRe1g5rcoxIyn/9s1VydxrKaj7Iops7HuI0sOeZKIjCMDKAA69R8AFIigqd4SE9lxws= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sUNYEhE/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sUNYEhE/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0898C19423; Tue, 31 Mar 2026 14:25:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774967136; bh=5bcoGgxrpwVyUOYA1eEQmIr35+1q7oEyf8faEnK/eOA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sUNYEhE/Ned0aDSXQdCXXEYqB+iOGGUpaOZFsjq60IBwJi+9k/MdlFEYe8FJqkzEI eCZz+yOhje828/l4XsrpnapGC3uu/kIQFaJ4aw6C1pemw9JzjWTG5JO2jweHuPmzcr LvCS32xQoOr+NV2za/eX7R13GzcEgRH4s67jwHppgOE4OoTlF+X95w5nMDpPhZbW2+ IxToUIAZhvFDu0CPdNc58DugVXHnuQUeB6EuaVar/4iDMTJbqPv3k+tqYFR3JMo3Uu aMXOPJQ+HKEi2rN3yF1aGWGQYwmFNSgSYQY31zWb0dUln4F7OO/rS+QiseeZcFgnY9 c5vZDJl1VA5cA== From: Sasha Levin To: stable@vger.kernel.org Cc: Nikunj A Dadhania , Borislav Petkov , Sohil Mehta , stable@kernel.org, Sasha Levin Subject: [PATCH 5.10.y] x86/cpu: Enable FSGSBASE early in cpu_init_exception_handling() Date: Tue, 31 Mar 2026 10:25:33 -0400 Message-ID: <20260331142533.2463086-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026033008-surfboard-squirt-5661@gregkh> References: <2026033008-surfboard-squirt-5661@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Nikunj A Dadhania [ Upstream commit 05243d490bb7852a8acca7b5b5658019c7797a52 ] Move FSGSBASE enablement from identify_cpu() to cpu_init_exception_handling() to ensure it is enabled before any exceptions can occur on both boot and secondary CPUs. == Background == Exception entry code (paranoid_entry()) uses ALTERNATIVE patching based on X86_FEATURE_FSGSBASE to decide whether to use RDGSBASE/WRGSBASE instructions or the slower RDMSR/SWAPGS sequence for saving/restoring GSBASE. On boot CPU, ALTERNATIVE patching happens after enabling FSGSBASE in CR4. When the feature is available, the code is permanently patched to use RDGSBASE/WRGSBASE, which require CR4.FSGSBASE=1 to execute without triggering == Boot Sequence == Boot CPU (with CR pinning enabled): trap_init() cpu_init() <- Uses unpatched code (RDMSR/SWAPGS) x2apic_setup() ... arch_cpu_finalize_init() identify_boot_cpu() identify_cpu() cr4_set_bits(X86_CR4_FSGSBASE) # Enables the feature # This becomes part of cr4_pinned_bits ... alternative_instructions() <- Patches code to use RDGSBASE/WRGSBASE Secondary CPUs (with CR pinning enabled): start_secondary() cr4_init() <- Code already patched, CR4.FSGSBASE=1 set implicitly via cr4_pinned_bits cpu_init() <- exceptions work because FSGSBASE is already enabled Secondary CPU (with CR pinning disabled): start_secondary() cr4_init() <- Code already patched, CR4.FSGSBASE=0 cpu_init() x2apic_setup() rdmsrq(MSR_IA32_APICBASE) <- Triggers #VC in SNP guests exc_vmm_communication() paranoid_entry() <- Uses RDGSBASE with CR4.FSGSBASE=0 (patched code) ... ap_starting() identify_secondary_cpu() identify_cpu() cr4_set_bits(X86_CR4_FSGSBASE) <- Enables the feature, which is too late == CR Pinning == Currently, for secondary CPUs, CR4.FSGSBASE is set implicitly through CR-pinning: the boot CPU sets it during identify_cpu(), it becomes part of cr4_pinned_bits, and cr4_init() applies those pinned bits to secondary CPUs. This works but creates an undocumented dependency between cr4_init() and the pinning mechanism. == Problem == Secondary CPUs boot after alternatives have been applied globally. They execute already-patched paranoid_entry() code that uses RDGSBASE/WRGSBASE instructions, which require CR4.FSGSBASE=1. Upcoming changes to CR pinning behavior will break the implicit dependency, causing secondary CPUs to generate #UD. This issue manifests itself on AMD SEV-SNP guests, where the rdmsrq() in x2apic_setup() triggers a #VC exception early during cpu_init(). The #VC handler (exc_vmm_communication()) executes the patched paranoid_entry() path. Without CR4.FSGSBASE enabled, RDGSBASE instructions trigger #UD. == Fix == Enable FSGSBASE explicitly in cpu_init_exception_handling() before loading exception handlers. This makes the dependency explicit and ensures both boot and secondary CPUs have FSGSBASE enabled before paranoid_entry() executes. Fixes: c82965f9e530 ("x86/entry/64: Handle FSGSBASE enabled paranoid entry/exit") Reported-by: Borislav Petkov Suggested-by: Sohil Mehta Signed-off-by: Nikunj A Dadhania Signed-off-by: Borislav Petkov (AMD) Reviewed-by: Sohil Mehta Cc: Link: https://patch.msgid.link/20260318075654.1792916-2-nikunj@amd.com [ placed FSGSBASE enablement before load_current_idt() ] Signed-off-by: Sasha Levin --- arch/x86/kernel/cpu/common.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c index cc0b43dbb1c30..c14982471082d 100644 --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -1816,12 +1816,6 @@ static void identify_cpu(struct cpuinfo_x86 *c) setup_smap(c); setup_umip(c); - /* Enable FSGSBASE instructions if available. */ - if (cpu_has(c, X86_FEATURE_FSGSBASE)) { - cr4_set_bits(X86_CR4_FSGSBASE); - elf_hwcap2 |= HWCAP2_FSGSBASE; - } - /* * The vendor-specific functions might have changed features. * Now we do "generic changes." @@ -2188,6 +2182,18 @@ void cpu_init_exception_handling(void) load_TR_desc(); + /* + * On CPUs with FSGSBASE support, paranoid_entry() uses + * ALTERNATIVE-patched RDGSBASE/WRGSBASE instructions. Secondary CPUs + * boot after alternatives are patched globally, so early exceptions + * execute patched code that depends on FSGSBASE. Enable the feature + * before any exceptions occur. + */ + if (cpu_feature_enabled(X86_FEATURE_FSGSBASE)) { + cr4_set_bits(X86_CR4_FSGSBASE); + elf_hwcap2 |= HWCAP2_FSGSBASE; + } + /* Finally load the IDT */ load_current_idt(); } -- 2.53.0