From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03A613E3174; Tue, 31 Mar 2026 16:24:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774974279; cv=none; b=RH46qu/8JTK14KOapnjm0XBN/jewLo68XdaguMBKVz51677G4oLnSgW35fl3rraQgsHf7hOyoKUp5BTo+bsNVJhS9ymXPd2jMx1oLfiAU41ee/CzvQSZm27/86jFD6Ch0ECB3jXwJZkKgXXu+tTUW/b3Smiy/TGWs6lCKGLvimI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774974279; c=relaxed/simple; bh=KN6ubHPkOeIztEfNHXMQM8aw7KsktfPaOzGpufkm4d0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cbbV/XKrz0qyRxXGgKq90vZFXrEzfdOX67cxHe0Qj31RPZ7tCIyYpCUcm9Peu0D0ziobRsLDq9xcgsJlJrM5rRWObsGdRVl31hbqgbBVW+1Tz33gRiRbWPAiMUOMEYjwz+GXlTmJEctH25t0z9W528c839fDjgYCbjMMDpipzWs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=NmqFFQW5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="NmqFFQW5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B42FC19423; Tue, 31 Mar 2026 16:24:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1774974278; bh=KN6ubHPkOeIztEfNHXMQM8aw7KsktfPaOzGpufkm4d0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NmqFFQW5e7oG8Zt9LbqtQ4X/uV36W9z1+o+37VaJm/w3edyqBjfw+HTNgYtog8Wtv 76vVTvmBsaPHOx4PKMGCDdNjwZVsWGdvCZC3YvDMNPM8EqE7MtVuQi94D/RnAT+Yc4 l9TnqgQZTNKvqds7Pe1lNQsOiqt5CI5JYWB7EH50= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Mark Brown , Sasha Levin Subject: [PATCH 6.6 023/175] ASoC: fsl_easrc: Fix event generation in fsl_easrc_iec958_set_reg() Date: Tue, 31 Mar 2026 18:20:07 +0200 Message-ID: <20260331161730.634104428@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260331161729.779738837@linuxfoundation.org> References: <20260331161729.779738837@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mark Brown [ Upstream commit 31ddc62c1cd92e51b9db61d7954b85ae2ec224da ] ALSA controls should return 1 if the value in the control changed but the control put operation fsl_easrc_set_reg() only returns 0 or a negative error code, causing ALSA to not generate any change events. Add a suitable check by using regmap_update_bits_check() with the underlying regmap, this is more clearly and simply correct than trying to verify that one of the generic ops is exactly equivalent to this one. Signed-off-by: Mark Brown Link: https://patch.msgid.link/20260205-asoc-fsl-easrc-fix-events-v1-2-39d4c766918b@kernel.org Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/fsl/fsl_easrc.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/sound/soc/fsl/fsl_easrc.c b/sound/soc/fsl/fsl_easrc.c index ec53bda46a467..c3d81cab2556d 100644 --- a/sound/soc/fsl/fsl_easrc.c +++ b/sound/soc/fsl/fsl_easrc.c @@ -93,14 +93,17 @@ static int fsl_easrc_set_reg(struct snd_kcontrol *kcontrol, struct snd_soc_component *component = snd_kcontrol_chip(kcontrol); struct soc_mreg_control *mc = (struct soc_mreg_control *)kcontrol->private_value; + struct fsl_asrc *easrc = snd_soc_component_get_drvdata(component); unsigned int regval = ucontrol->value.integer.value[0]; + bool changed; int ret; - ret = snd_soc_component_write(component, mc->regbase, regval); - if (ret < 0) + ret = regmap_update_bits_check(easrc->regmap, mc->regbase, + GENMASK(31, 0), regval, &changed); + if (ret != 0) return ret; - return 0; + return changed; } #define SOC_SINGLE_REG_RW(xname, xreg) \ -- 2.51.0