From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D018F421898; Tue, 31 Mar 2026 16:25:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774974348; cv=none; b=s7G49lFXhqxJTb0ROL4pRrzKnyQM6ZEYNvk8PvF2h4oY8j8oIAlkr5k84MoFwwA7FdL/zHDVknv6pIYZSgOhTrslvYBuzPS1NlAqUsfv7adwzHXAW9kIwmccUo2MLZn/C3ckmeiKZ06dFiB0NY2KSTbDKZdvGaGIXs8pAguJYVQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774974348; c=relaxed/simple; bh=mTTj7KvTf16IC/23NehJJlHtZN13klj9cJ377HEifio=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=n6XWIV97EJ8YUD7YxL/zpZYUIWcIS+yGwwnYV1w0wFl7B2nrCVMFECNQE8bRqz2oABD0g2H6uOOp4I+YPkD8w6EExgZoH/onGnTmb1rkjWpOGesIY6K12vnEpcoWv8QP2XIVuVrEk5rGqFubLl4UqmW6s21weOO+Pc+Lf9i9blo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ndeN2VDD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ndeN2VDD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46D10C19423; Tue, 31 Mar 2026 16:25:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1774974348; bh=mTTj7KvTf16IC/23NehJJlHtZN13klj9cJ377HEifio=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ndeN2VDDZV5wG06S/ShbpXsTEiQPbmoyJLTOcOgHve2LqqXQzvdV8TVUxVVT6HZK0 3aCuhaaXK7GAsugSjJ6of2g9ayrlZg3UeFjuKmW1M7l0IAuP+N20Th2xUN8NBx4u/E YdJumYvMl8pxTPgq37ltokmUWInqhgjQUaaMROIE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Alok Tiwari , Lubomir Rintel , Randy Dunlap , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Sasha Levin Subject: [PATCH 6.6 051/175] platform/olpc: olpc-xo175-ec: Fix overflow error message to print inlen Date: Tue, 31 Mar 2026 18:20:35 +0200 Message-ID: <20260331161731.660336924@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260331161729.779738837@linuxfoundation.org> References: <20260331161729.779738837@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Alok Tiwari [ Upstream commit 2061f7b042f88d372cca79615f8425f3564c0b40 ] The command length check validates inlen (> 5), but the error message incorrectly printed resp_len. Print inlen so the log reflects the actual command length. Fixes: 0c3d931b3ab9e ("Platform: OLPC: Add XO-1.75 EC driver") Signed-off-by: Alok Tiwari Acked-by: Lubomir Rintel Reviewed-by: Randy Dunlap Link: https://patch.msgid.link/20260310130138.700687-1-alok.a.tiwari@oracle.com Reviewed-by: Ilpo Järvinen Signed-off-by: Ilpo Järvinen Signed-off-by: Sasha Levin --- drivers/platform/olpc/olpc-xo175-ec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/olpc/olpc-xo175-ec.c b/drivers/platform/olpc/olpc-xo175-ec.c index 62ccbcb15c744..efe4cee5acfff 100644 --- a/drivers/platform/olpc/olpc-xo175-ec.c +++ b/drivers/platform/olpc/olpc-xo175-ec.c @@ -482,7 +482,7 @@ static int olpc_xo175_ec_cmd(u8 cmd, u8 *inbuf, size_t inlen, u8 *resp, dev_dbg(dev, "CMD %x, %zd bytes expected\n", cmd, resp_len); if (inlen > 5) { - dev_err(dev, "command len %zd too big!\n", resp_len); + dev_err(dev, "command len %zd too big!\n", inlen); return -EOVERFLOW; } -- 2.51.0