From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66EDD4279EA; Tue, 31 Mar 2026 16:52:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774975935; cv=none; b=T9O677ojeWsWDUEZTLuH9ruIeuiBfh/bYx9tlaC6sq5B0xP4eDCDvJOdRsW5DjeK2RzsN0J/ahLYruYytKyc5VxYUONd+mBcW8fz+elFarTBH6bJdSpLXqswBfrQuBKS0Ke5qrNymc0MeIZhBERxlJUUS2bkhXOV7GM+E5gnQt0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774975935; c=relaxed/simple; bh=NApUHE1KWfQ7i1VW+c50HphCGsliw+F3RfukGylOF9E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AxVIXLgthHdVRnEj4LTNCuchgjY/AtPvLkAWQJ6G3KjcblRYylMk6hGn+zACpzY0ah4BowT33V+W/CwI/Gxcw7cVMvwQLYp0y8vdCL+OAy0gAWonpaHRjczTTJ1f8a82z4k/SBYy3stpQxaA3sH1gxVUs9PbaZnJTGHPRYJtdfo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=jrt5onGv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="jrt5onGv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ECDF0C19423; Tue, 31 Mar 2026 16:52:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1774975935; bh=NApUHE1KWfQ7i1VW+c50HphCGsliw+F3RfukGylOF9E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jrt5onGvjqTYJDnfbIGt9wkETZ02QU63zLfCLRJMpjmFyAVDMOtNP9j/kiGyi+mRs wLuaa0752nYxDgVmSDH58UrlEJA1svxL2DbCl5KBdlF/naOP1HRRyWhuv7MEp5cmh0 IND3FgZDb9LEQNuHTYRp/YPFlC/LcLq2G9Oq6h7w= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Tatyana Nikolova , Leon Romanovsky , Sasha Levin Subject: [PATCH 6.12 110/244] RDMA/irdma: Remove a NOP wait_event() in irdma_modify_qp_roce() Date: Tue, 31 Mar 2026 18:21:00 +0200 Message-ID: <20260331161745.729652557@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260331161741.651718120@linuxfoundation.org> References: <20260331161741.651718120@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tatyana Nikolova [ Upstream commit 5e8f0239731a83753473b7aa91bda67bbdff5053 ] Remove a NOP wait_event() in irdma_modify_qp_roce() which is relevant for iWARP and likely a copy and paste artifact for RoCEv2. The wait event is for sending a reset on a TCP connection, after the reset has been requested in irdma_modify_qp(), which occurs only in iWarp mode. Fixes: b48c24c2d710 ("RDMA/irdma: Implement device supported verb APIs") Signed-off-by: Tatyana Nikolova Signed-off-by: Leon Romanovsky Signed-off-by: Sasha Levin --- drivers/infiniband/hw/irdma/verbs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/infiniband/hw/irdma/verbs.c b/drivers/infiniband/hw/irdma/verbs.c index 90d2c36928c1e..5db64fae45515 100644 --- a/drivers/infiniband/hw/irdma/verbs.c +++ b/drivers/infiniband/hw/irdma/verbs.c @@ -1364,8 +1364,6 @@ int irdma_modify_qp_roce(struct ib_qp *ibqp, struct ib_qp_attr *attr, roce_info->rd_en = true; } - wait_event(iwqp->mod_qp_waitq, !atomic_read(&iwqp->hw_mod_qp_pend)); - ibdev_dbg(&iwdev->ibdev, "VERBS: caller: %pS qp_id=%d to_ibqpstate=%d ibqpstate=%d irdma_qpstate=%d attr_mask=0x%x\n", __builtin_return_address(0), ibqp->qp_num, attr->qp_state, -- 2.53.0