From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDAF7428481; Tue, 31 Mar 2026 16:52:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774975938; cv=none; b=MlIaA3o3FTUtroXWQjxJaOsBPWK/yauQZrDKXKh6EoWhA2GtMll83VOUND2CVCOJ1TLp43J5t0YG9MGxWMbmFGKV86Unv8IJHLtIRTBoi5IKbaERp1ZWXYXiKmTCIMYC46N368tpdX1TPnkQ4QpOQPzWbLb0ZqoNg2n0j97S148= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774975938; c=relaxed/simple; bh=Xst8fdtKrPG4G676keHQyZYlioCA7RFf3HdnrsA+Zeg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gngx5+tHq2yXBk7fcB4KxsOf41L1yv6Zc5ZyQCeyzjm6uN6M6QP3Y37Om/8Eht75tRzpuLWrXD9xkNVoYMxff1QRDsxT47j33K7SGN7mYBqcI+8lEcbXizqakcFJT4tk5rtiYl7o9iOtX/WElRISKAAONNZzJUZZkChTP9FIvXc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=G6WrwE0T; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="G6WrwE0T" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83286C2BCB4; Tue, 31 Mar 2026 16:52:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1774975937; bh=Xst8fdtKrPG4G676keHQyZYlioCA7RFf3HdnrsA+Zeg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=G6WrwE0T3cWGEXo/SGXnPmKsfeBmIqL8M6aWjczt/HL17n5CNQfanoIgfLYSKsf21 ifmoH7McBjhlgq56iSU0V656/6n3QE0aKtqI5OUvJrRVEXOlyq0G8ODIVeFltUKoo8 XjEy/O5uof24YlHF9nMIZDNwH4MoeqwOmxIyEiYM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ivan Barrera , Tatyana Nikolova , Leon Romanovsky , Sasha Levin Subject: [PATCH 6.12 111/244] RDMA/irdma: Clean up unnecessary dereference of event->cm_node Date: Tue, 31 Mar 2026 18:21:01 +0200 Message-ID: <20260331161745.765341925@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260331161741.651718120@linuxfoundation.org> References: <20260331161741.651718120@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ivan Barrera [ Upstream commit b415399c9a024d574b65479636f0d4eb625b9abd ] The cm_node is available and the usage of cm_node and event->cm_node seems arbitrary. Clean up unnecessary dereference of event->cm_node. Fixes: 146b9756f14c ("RDMA/irdma: Add connection manager") Signed-off-by: Ivan Barrera Signed-off-by: Tatyana Nikolova Signed-off-by: Leon Romanovsky Signed-off-by: Sasha Levin --- drivers/infiniband/hw/irdma/cm.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/infiniband/hw/irdma/cm.c b/drivers/infiniband/hw/irdma/cm.c index 7b9cba80a7f74..e7f315e102d51 100644 --- a/drivers/infiniband/hw/irdma/cm.c +++ b/drivers/infiniband/hw/irdma/cm.c @@ -4238,21 +4238,21 @@ static void irdma_cm_event_handler(struct work_struct *work) irdma_cm_event_reset(event); break; case IRDMA_CM_EVENT_CONNECTED: - if (!event->cm_node->cm_id || - event->cm_node->state != IRDMA_CM_STATE_OFFLOADED) + if (!cm_node->cm_id || + cm_node->state != IRDMA_CM_STATE_OFFLOADED) break; irdma_cm_event_connected(event); break; case IRDMA_CM_EVENT_MPA_REJECT: - if (!event->cm_node->cm_id || + if (!cm_node->cm_id || cm_node->state == IRDMA_CM_STATE_OFFLOADED) break; irdma_send_cm_event(cm_node, cm_node->cm_id, IW_CM_EVENT_CONNECT_REPLY, -ECONNREFUSED); break; case IRDMA_CM_EVENT_ABORTED: - if (!event->cm_node->cm_id || - event->cm_node->state == IRDMA_CM_STATE_OFFLOADED) + if (!cm_node->cm_id || + cm_node->state == IRDMA_CM_STATE_OFFLOADED) break; irdma_event_connect_error(event); break; @@ -4262,7 +4262,7 @@ static void irdma_cm_event_handler(struct work_struct *work) break; } - irdma_rem_ref_cm_node(event->cm_node); + irdma_rem_ref_cm_node(cm_node); kfree(event); } -- 2.53.0