From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBA03423149; Tue, 31 Mar 2026 16:55:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774976119; cv=none; b=j4dhWNg4pMYzfcYfQbhNrG+xOi+w2Lcf4BuY77FkznNHUwNyia3aD6/7bm4X5s60aAJaUwhyzLI9t0spMA7p75ruKAZR7ImbRMfrGiypfgrhTD9Y3j+z210GigaDtb7nQiyP9RUboAhmi4R73IjKF7Zrnj3DRXPY8CoZd2SmEW4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774976119; c=relaxed/simple; bh=z+0ltH223pVM473NXM5FacEZNE8DLzZSjE+gRYjcJHY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=G9rXT4rkcmPojWSANNU42Fgx2WR6h6fBekulo3fi6U7mxyl15p9FXRAsMr+GlCeHWRm/4aJVb2HTXoNZymykZPBp0DPrt2khHiSTLbGh63w5l68Yf/uv6QIv0LmTmDeHEZh9s4vtK3BH+ne7ktNzwK5JSqcTFoONk/dTqeW3LcM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=om5RNsQV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="om5RNsQV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 70A7BC2BCB1; Tue, 31 Mar 2026 16:55:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1774976119; bh=z+0ltH223pVM473NXM5FacEZNE8DLzZSjE+gRYjcJHY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=om5RNsQVqxM355VngN4NyrELvXRpt+IWd/a4GyunHrC+cYKSozZsq+9AV/xwptwVV IwgMr1Q0vUzxLlKlCwRHIEk7m4SCPGfqnAw/nGoZ0XFtnUEqlJjw20yWRn6JSuI+W5 x1iu3WmKV3FJyFk/5wQnr8mCAlVMhfYGOJwe7eM0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, "Darrick J. Wong" , Long Li , Christoph Hellwig , Carlos Maiolino , Carlos Maiolino Subject: [PATCH 6.12 181/244] xfs: dont irele after failing to iget in xfs_attri_recover_work Date: Tue, 31 Mar 2026 18:22:11 +0200 Message-ID: <20260331161748.442745756@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260331161741.651718120@linuxfoundation.org> References: <20260331161741.651718120@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Darrick J. Wong commit 70685c291ef82269180758130394ecdc4496b52c upstream. xlog_recovery_iget* never set @ip to a valid pointer if they return an error, so this irele will walk off a dangling pointer. Fix that. Cc: stable@vger.kernel.org # v6.10 Fixes: ae673f534a3097 ("xfs: record inode generation in xattr update log intent items") Signed-off-by: Darrick J. Wong Reviewed-by: Long Li Reviewed-by: Christoph Hellwig Reviewed-by: Carlos Maiolino Signed-off-by: Carlos Maiolino Signed-off-by: Greg Kroah-Hartman --- fs/xfs/xfs_attr_item.c | 1 - 1 file changed, 1 deletion(-) --- a/fs/xfs/xfs_attr_item.c +++ b/fs/xfs/xfs_attr_item.c @@ -658,7 +658,6 @@ xfs_attri_recover_work( break; } if (error) { - xfs_irele(ip); XFS_CORRUPTION_ERROR(__func__, XFS_ERRLEVEL_LOW, mp, attrp, sizeof(*attrp)); return ERR_PTR(-EFSCORRUPTED);