From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 025EB2EDD69; Tue, 31 Mar 2026 17:01:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774976501; cv=none; b=gdsSisGGhp05/ke0YGljTi9KkkFl/fNjP9GhiYW0ZQygqikwGGJLibUNYzuB0x2jfBeOGr2cf4nqIXWpyWblr85z44eVSJxz6OQY5c0UgsLeQFqV1P2qsQT+6EdBxwuLGbX6wyzU6cOdjK3X9jZDe4i8kGffoWc2b8sXr7Um09A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774976501; c=relaxed/simple; bh=yzQRZJyJffikl4dVG2HNyN+aUqhafjDdW1t90jSJSz4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mON9sEgRXsFzsowXWDNhEfO5HEn3TeAvZ5G457XnCpjKpTccnpRAWgmy5tJbRIec+YjI3KvlULGmwbVxejJFYsUKdH7NWNXm3UPjkqWoU9D+jnsnD8kFVeGUb+9L4XUl9HkFpSdoT2mnK+9GJh3rNyKMqYGOEQbirPBzJnkUoJc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=rOwKVz8h; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="rOwKVz8h" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2193FC19424; Tue, 31 Mar 2026 17:01:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1774976500; bh=yzQRZJyJffikl4dVG2HNyN+aUqhafjDdW1t90jSJSz4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rOwKVz8h1DTnwSuvupCk29w5kMY9f40RyGTPgcnAyEK1qwsKU2bsEArDAHtb93EWU grXfLVFI3zCP/rYgqeZLdDgBbjMF09JWqvTGa6PwnFd4et3KpyRLk9K1891amuvQ/b d4idgenC4qZCbeLxyBE4NjoBMKLpZNrVrHurk3rk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Thangaraj Samynathan , "Russell King (Oracle)" , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.18 116/309] net: lan743x: fix duplex configuration in mac_link_up Date: Tue, 31 Mar 2026 18:20:19 +0200 Message-ID: <20260331161757.753508500@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260331161753.468533260@linuxfoundation.org> References: <20260331161753.468533260@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Thangaraj Samynathan [ Upstream commit 71399707876b93240f236f48b8062f3423a5fe97 ] The driver does not explicitly configure the MAC duplex mode when bringing the link up. As a result, the MAC may retain a stale duplex setting from a previous link state, leading to duplex mismatches with the link partner and degraded network performance. Update lan743x_phylink_mac_link_up() to set or clear the MAC_CR_DPX_ bit according to the negotiated duplex mode. This ensures the MAC configuration is consistent with the phylink resolved state. Fixes: a5f199a8d8a03 ("net: lan743x: Migrate phylib to phylink") Signed-off-by: Thangaraj Samynathan Reviewed-by: Russell King (Oracle) Link: https://patch.msgid.link/20260323065345.144915-1-thangaraj.s@microchip.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/microchip/lan743x_main.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c index e4c542fc6c2b8..09d255e78f6cd 100644 --- a/drivers/net/ethernet/microchip/lan743x_main.c +++ b/drivers/net/ethernet/microchip/lan743x_main.c @@ -3054,6 +3054,11 @@ static void lan743x_phylink_mac_link_up(struct phylink_config *config, else if (speed == SPEED_100) mac_cr |= MAC_CR_CFG_L_; + if (duplex == DUPLEX_FULL) + mac_cr |= MAC_CR_DPX_; + else + mac_cr &= ~MAC_CR_DPX_; + lan743x_csr_write(adapter, MAC_CR, mac_cr); lan743x_ptp_update_latency(adapter, speed); -- 2.51.0