From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3211F2E1C7C; Tue, 31 Mar 2026 17:02:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774976567; cv=none; b=ZI+MViCHfKV2tEOAk5UiodP9nZmZdwb9hsWeS9hHFmFIFmow6wvo2AqaTOaZvxOqFQOiK/FnarOB/F/1FNQYuaJRxD7ah5K+OAQlky71JD31yQR6NKyAx1B3yL3BrZjMxyewCZaj3po3cx7PvZIh1T6Is0Lqy4cThmOAPkkmbk8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774976567; c=relaxed/simple; bh=AASTxL7DQelLI/k/lvGw5Ykg0TkvWVXcJmYQJrSAcLQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Uwq5vrgghJpbzPhE/XWz8ITETbelHkVJUAmBHMphimQFJdmFfHVWqu8BQvozJ0REXTNrFVa5rIawNN8JANzSTmZxuaTkbLjVrAHmy85COD/IdUL8MDbjCK/dfpH6HMiK5YU4vqwYTvOYnuVQm+cPCr1XR0STWGM5ym2tOd+SvPY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=IK20tEgA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="IK20tEgA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BBB49C19423; Tue, 31 Mar 2026 17:02:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1774976567; bh=AASTxL7DQelLI/k/lvGw5Ykg0TkvWVXcJmYQJrSAcLQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IK20tEgA9FvfOVUQ0F2kOwhXV7O6LjXMquohc2BJv8gyDuXU26dNZjRyS2g0G7BRt hBcZTu9TprPgiCOA/RwolXVQJjs3M4Md8HhbDixD5ZM9USROTYgw8NOQUSPbdsjpNo Y1PKAyX3SL0M74J3jowiDL+IuQhrjpx6JHjKU5GY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Tatyana Nikolova , Leon Romanovsky , Sasha Levin Subject: [PATCH 6.18 143/309] RDMA/irdma: Remove a NOP wait_event() in irdma_modify_qp_roce() Date: Tue, 31 Mar 2026 18:20:46 +0200 Message-ID: <20260331161758.736744522@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260331161753.468533260@linuxfoundation.org> References: <20260331161753.468533260@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tatyana Nikolova [ Upstream commit 5e8f0239731a83753473b7aa91bda67bbdff5053 ] Remove a NOP wait_event() in irdma_modify_qp_roce() which is relevant for iWARP and likely a copy and paste artifact for RoCEv2. The wait event is for sending a reset on a TCP connection, after the reset has been requested in irdma_modify_qp(), which occurs only in iWarp mode. Fixes: b48c24c2d710 ("RDMA/irdma: Implement device supported verb APIs") Signed-off-by: Tatyana Nikolova Signed-off-by: Leon Romanovsky Signed-off-by: Sasha Levin --- drivers/infiniband/hw/irdma/verbs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/infiniband/hw/irdma/verbs.c b/drivers/infiniband/hw/irdma/verbs.c index c2449f5721eeb..ed2f985a35408 100644 --- a/drivers/infiniband/hw/irdma/verbs.c +++ b/drivers/infiniband/hw/irdma/verbs.c @@ -1463,8 +1463,6 @@ int irdma_modify_qp_roce(struct ib_qp *ibqp, struct ib_qp_attr *attr, ctx_info->remote_atomics_en = true; } - wait_event(iwqp->mod_qp_waitq, !atomic_read(&iwqp->hw_mod_qp_pend)); - ibdev_dbg(&iwdev->ibdev, "VERBS: caller: %pS qp_id=%d to_ibqpstate=%d ibqpstate=%d irdma_qpstate=%d attr_mask=0x%x\n", __builtin_return_address(0), ibqp->qp_num, attr->qp_state, -- 2.53.0