From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1001D425CFF; Tue, 31 Mar 2026 16:38:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774975102; cv=none; b=PX9ICadG0rOoJQqJXPL46gsqAqvNFU1fUkntGVN/5eXmfopAuH1+iGZ6YTfwpIEvCIlf3rJTXjk1nYKGjkov+BlXnQUWV8ye3zHjyD8pnsCcK7Zs4e0PGPQOrc/8x2DH3mOkkcGYBtFh0NeapDFrTMbGKEo9NSYb/SNGPgGRoCc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774975102; c=relaxed/simple; bh=+rwcBwCqVqY1299X7BS341Z04JSACTKOl6TAAHudUxU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iecGVYtV25oeAe8UKtwRVlj5godhLfJeu/VDDvfzWa3jtF6PJ1a6HlencYz0Ztyn4Y1apGbCbIUoHYAIQ6ve9Y1CvYO9lw2F0hC2Uv2E8WIWggqFxJ5fenEcW/oSnEA7zbLgQazb3HsSfNQHpstCNejAS0n8nr3RRw2LFjZWyM4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=w6HsDU/o; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="w6HsDU/o" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55DA4C19423; Tue, 31 Mar 2026 16:38:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1774975101; bh=+rwcBwCqVqY1299X7BS341Z04JSACTKOl6TAAHudUxU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=w6HsDU/oM7OonDf4RboWrc4ALSz0WGbnC+3tl5DHKL+vK1vQX9HpzGlm0Vs5qnt7c eqlRgBpwr0F9Sdg9UKUOvlnrJBwneV8D2QKJxVSn/572CGR99vp5idVHx3GT7SdcFK oCKp+w7WCIrR14RFG9D61egUg3i65kFH/AMnYrhg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Miguel Ojeda , Marek Szyprowski , Sasha Levin Subject: [PATCH 6.19 132/342] dma-mapping: add missing `inline` for `dma_free_attrs` Date: Tue, 31 Mar 2026 18:19:25 +0200 Message-ID: <20260331161803.864533651@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260331161758.909578033@linuxfoundation.org> References: <20260331161758.909578033@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Miguel Ojeda [ Upstream commit 2cdaff22ed26f1e619aa2b43f27bb84f2c6ef8f8 ] Under an UML build for an upcoming series [1], I got `-Wstatic-in-inline` for `dma_free_attrs`: BINDGEN rust/bindings/bindings_generated.rs - due to target missing In file included from rust/helpers/helpers.c:59: rust/helpers/dma.c:17:2: warning: static function 'dma_free_attrs' is used in an inline function with external linkage [-Wstatic-in-inline] 17 | dma_free_attrs(dev, size, cpu_addr, dma_handle, attrs); | ^ rust/helpers/dma.c:12:1: note: use 'static' to give inline function 'rust_helper_dma_free_attrs' internal linkage 12 | __rust_helper void rust_helper_dma_free_attrs(struct device *dev, size_t size, | ^ | static The issue is that `dma_free_attrs` was not marked `inline` when it was introduced alongside the rest of the stubs. Thus mark it. Fixes: ed6ccf10f24b ("dma-mapping: properly stub out the DMA API for !CONFIG_HAS_DMA") Closes: https://lore.kernel.org/rust-for-linux/20260322194616.89847-1-ojeda@kernel.org/ [1] Signed-off-by: Miguel Ojeda Signed-off-by: Marek Szyprowski Link: https://lore.kernel.org/r/20260325015548.70912-1-ojeda@kernel.org Signed-off-by: Sasha Levin --- include/linux/dma-mapping.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h index aa36a0d1d9df6..190eab9f5e8c2 100644 --- a/include/linux/dma-mapping.h +++ b/include/linux/dma-mapping.h @@ -240,8 +240,8 @@ static inline void *dma_alloc_attrs(struct device *dev, size_t size, { return NULL; } -static void dma_free_attrs(struct device *dev, size_t size, void *cpu_addr, - dma_addr_t dma_handle, unsigned long attrs) +static inline void dma_free_attrs(struct device *dev, size_t size, + void *cpu_addr, dma_addr_t dma_handle, unsigned long attrs) { } static inline void *dmam_alloc_attrs(struct device *dev, size_t size, -- 2.51.0