From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0993402B9B; Tue, 31 Mar 2026 16:42:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774975368; cv=none; b=qdnbKu56FfRyXLw2geFbRQOvoxy0heFIpDHooeA1vrKcNGpXUeSpIcbLAX8Hl6zmvmB84w+LVJryGl10BwOI1U7lq/MggTF/iL1yYbZVz+SKUrXezr6cCv3hOEn/zkZ4Ljeb661Y91VaKTAgGzw9eAOvDkemMhgXM4UTFC6K5mI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774975368; c=relaxed/simple; bh=UQrxJRCIyurfSyiinWd8wM6GvkMu2/yDthzWUDbRHg0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Wx7YWWGQykSC12kFYPIAq4JYd9DAIn8fzdHDUJu/0uiXg6xCoMid9laQT74vG1uwzu4Dmwxv8T+UbFGxqJIaAohVrOi2sOu/Pefto07TFVgaNAv1mY/LqP5YXCTpIiLtMmfIDVFWGhpOqJ/sH4G9v++fBA9m9K+gnAfGzVDaDEc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=BIR60OaA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="BIR60OaA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81210C19424; Tue, 31 Mar 2026 16:42:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1774975367; bh=UQrxJRCIyurfSyiinWd8wM6GvkMu2/yDthzWUDbRHg0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BIR60OaANHFBKP1EH7iRaRIFzKSSjffnuP3uy3VCQWhQIakK9KvLma+WQ+qiOD+ho eM3Z9zJqo+RkMwU23VNYfixBEAsIbwf0QL4eCqbXBZrJ3N8nNdVJOjRYzY/JjbFfsj US/Wfe6J3UT74vIJ9+c+EKJmy3Wr3eY06MH2nRmY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Gao Xiang , Jiucheng Xu , Chao Yu Subject: [PATCH 6.19 235/342] erofs: add GFP_NOIO in the bio completion if needed Date: Tue, 31 Mar 2026 18:21:08 +0200 Message-ID: <20260331161807.613214482@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260331161758.909578033@linuxfoundation.org> References: <20260331161758.909578033@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jiucheng Xu commit c23df30915f83e7257c8625b690a1cece94142a0 upstream. The bio completion path in the process context (e.g. dm-verity) will directly call into decompression rather than trigger another workqueue context for minimal scheduling latencies, which can then call vm_map_ram() with GFP_KERNEL. Due to insufficient memory, vm_map_ram() may generate memory swapping I/O, which can cause submit_bio_wait to deadlock in some scenarios. Trimmed down the call stack, as follows: f2fs_submit_read_io submit_bio //bio_list is initialized. mmc_blk_mq_recovery z_erofs_endio vm_map_ram __pte_alloc_kernel __alloc_pages_direct_reclaim shrink_folio_list __swap_writepage submit_bio_wait //bio_list is non-NULL, hang!!! Use memalloc_noio_{save,restore}() to wrap up this path. Reviewed-by: Gao Xiang Signed-off-by: Jiucheng Xu Reviewed-by: Chao Yu Signed-off-by: Gao Xiang Signed-off-by: Greg Kroah-Hartman --- fs/erofs/zdata.c | 3 +++ 1 file changed, 3 insertions(+) --- a/fs/erofs/zdata.c +++ b/fs/erofs/zdata.c @@ -1459,6 +1459,7 @@ static void z_erofs_decompress_kickoff(s int bios) { struct erofs_sb_info *const sbi = EROFS_SB(io->sb); + int gfp_flag; /* wake up the caller thread for sync decompression */ if (io->sync) { @@ -1491,7 +1492,9 @@ static void z_erofs_decompress_kickoff(s sbi->opt.sync_decompress = EROFS_SYNC_DECOMPRESS_FORCE_ON; return; } + gfp_flag = memalloc_noio_save(); z_erofs_decompressqueue_work(&io->u.work); + memalloc_noio_restore(gfp_flag); } static void z_erofs_fill_bio_vec(struct bio_vec *bvec,