From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76B493A3E9F for ; Tue, 31 Mar 2026 19:40:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774986022; cv=none; b=UM24V9BV7uAYSq4r9HksFk+9tk4uPRuQpmyN0B3TaWmeusRpQjPnSY6chvoWuJ6dyTFEPuI6OmdsBg764THqE1fXIl0sg7jEnUKI7RYYkiLPFEyTdZ5/SpEY9cLOlT9cBzMEvw7XAKOeAZj2a5G2uNUTz3jMEzJTK552u2sLCpI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774986022; c=relaxed/simple; bh=/H4jmjjgvki87zdyu/VnizmsYs1FxS2iPkZwZN0OIBs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hAKjSDIGvb0wLzxNQrsQAHas1j4xuqSgkbhRPqZF1eMQYQDc7aZSDZEboZ+RyIuLW+2eMluEuqmcSOl2ivdeqAu/bnn8YoKZSgst9gBOLbD+tO7+lbYthr5sS8d6i1NcM0G4RolerOG9FnPV3BuUI95YQs6T1U4JSy1wYsLOZ2E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Rucnqax9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Rucnqax9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C2ABC19423; Tue, 31 Mar 2026 19:40:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774986022; bh=/H4jmjjgvki87zdyu/VnizmsYs1FxS2iPkZwZN0OIBs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Rucnqax985YdAfQft9CGnS7dR18Zo6V0uY1jEAVdGCA8Rhd2d1zboeoUh8GD1cow7 etjiCjSsQM8S+qcm7yIsV7vklTAU1/VOn7/OcvBJQ2ZbZcFQ0GR7l+ukblOTp7c17n p+LLTwN4fIrNXEIYR0/QVvvAf2cMB+DlsC6oQCR2rPWEIXFBCKQtU4oY6HgIi4cc1d TfSny5sDVDEPexT0nDcXWt3N+RF9Oh1oLFiH3kUCBWV5tjpZKhjpxlMnE7FDHHeDmV juOAciIgOs6WaZq8r6znSJiuRCQpntheYFSGZGnRzHU0ikFEz9svC2VVNXS7e8Ek2O nslOXZ0zVT34g== From: Sasha Levin To: stable@vger.kernel.org Cc: Guangshuo Li , Long Li , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.6.y] net: mana: fix use-after-free in add_adev() error path Date: Tue, 31 Mar 2026 15:40:19 -0400 Message-ID: <20260331194019.3088820-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026033042-retriever-acclaim-5e38@gregkh> References: <2026033042-retriever-acclaim-5e38@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Guangshuo Li [ Upstream commit c4ea7d8907cf72b259bf70bd8c2e791e1c4ff70f ] If auxiliary_device_add() fails, add_adev() jumps to add_fail and calls auxiliary_device_uninit(adev). The auxiliary device has its release callback set to adev_release(), which frees the containing struct mana_adev. Since adev is embedded in struct mana_adev, the subsequent fall-through to init_fail and access to adev->id may result in a use-after-free. Fix this by saving the allocated auxiliary device id in a local variable before calling auxiliary_device_add(), and use that saved id in the cleanup path after auxiliary_device_uninit(). Fixes: a69839d4327d ("net: mana: Add support for auxiliary device") Cc: stable@vger.kernel.org Reviewed-by: Long Li Signed-off-by: Guangshuo Li Link: https://patch.msgid.link/20260323165730.945365-1-lgs201920130244@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/microsoft/mana/mana_en.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c index 926502e5e5824..b56a337b1e212 100644 --- a/drivers/net/ethernet/microsoft/mana/mana_en.c +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c @@ -2759,6 +2759,7 @@ static int add_adev(struct gdma_dev *gd) struct auxiliary_device *adev; struct mana_adev *madev; int ret; + int id; madev = kzalloc(sizeof(*madev), GFP_KERNEL); if (!madev) @@ -2768,7 +2769,8 @@ static int add_adev(struct gdma_dev *gd) ret = mana_adev_idx_alloc(); if (ret < 0) goto idx_fail; - adev->id = ret; + id = ret; + adev->id = id; adev->name = "rdma"; adev->dev.parent = gd->gdma_context->dev; @@ -2792,7 +2794,7 @@ static int add_adev(struct gdma_dev *gd) auxiliary_device_uninit(adev); init_fail: - mana_adev_idx_free(adev->id); + mana_adev_idx_free(id); idx_fail: kfree(madev); -- 2.53.0