From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C764039C00C for ; Wed, 1 Apr 2026 08:21:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775031705; cv=none; b=M6MCqaQwojlYZPRHhyQqQI5eF/J08Kat6iaEifUBjqdYKeJXvnKkzRCpZ0GUvsjcLGSwD75brrreSpqwo8VYAg5df4G8wuIE71Tzt6elst+TikaAfW52Rd/BeDbjxbnEWxBazHWzBle79uFLwn2sDb1n78+a8JKh3Tdq5cnY2XY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775031705; c=relaxed/simple; bh=mE58UPyJl/FiMLUP216GucoGkRmpDm4sFWboaotFA54=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SbK7+EtJgrj/CejdLfXOifQ6kbq8dARE3fgWFh/yaGVwIQXTAFKB22cwm5wo9nepvHA4dagsF8gGKbFixVJ5J8HtHbghhLurLMn2bl4Dmbw9d6d9h5rltwX4HVl9oW+02Rr+iPkeS/hNKDPqQGsYjneRSi90+mnfLXdwESTU8yA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=L85HWBCT; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=A75CgZmW; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="L85HWBCT"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="A75CgZmW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775031702; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zFlf2MdDkifmThFJKZCcvKogFCBxiEgmNxrJgdVh+Lg=; b=L85HWBCTk6f5/pxyVCl7a9p+Lke1Cl2jSn7fzq8WJfBOUrCA//k5PNXOxz/O/ugm2mUFkB k9wYWP2R9Xr6I0EeFM+rLLbUFwfRh/qcvTHKFKaxp/GrpnUe/QEiXOB4UAiPP2KYD8pgsv tWu8BqzAdRQk8Nf8pg7YflDgmvLoBgY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-638-aId7bg59OlKN6LtPmP9P7Q-1; Wed, 01 Apr 2026 04:21:41 -0400 X-MC-Unique: aId7bg59OlKN6LtPmP9P7Q-1 X-Mimecast-MFC-AGG-ID: aId7bg59OlKN6LtPmP9P7Q_1775031700 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-485c45885e6so52945345e9.0 for ; Wed, 01 Apr 2026 01:21:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1775031700; x=1775636500; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zFlf2MdDkifmThFJKZCcvKogFCBxiEgmNxrJgdVh+Lg=; b=A75CgZmW345a1CUYbHimxiSs/IIKpO/IhFL1YDHIY+GhyUoCpeuWFOKojlJXXZ5AWl DYSi/RW669lMjUQmp0ZTWKgg0JFWMYmM/CalBqX8ivWIKg2AY9iUTDjeqo5rRThTCU6r 2OkM0a+d68SBsGdcB3gYnmSQyPtFGViBDrjUN7VfgB9Qu+s1w+dQmx5gjT768VeXMtdL YNnueTnb9EDXKXfPgZ3XDDSuD8c+kxtTMk5T0t29BMc7n3CE0VvbuixQr01PmLC3wS2o 8w9kQ/km/JlpGnAjgOdrV5zBxbU26oaxCLCkmmDUklN+MclHWuUOhlA/ZCnIFOeyvjg/ qIbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775031700; x=1775636500; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zFlf2MdDkifmThFJKZCcvKogFCBxiEgmNxrJgdVh+Lg=; b=NahjKvwDrm4xpsmWDKSEdiRYxz0yFirG3iT0aDoe1dPxiEAJsriavQ2X0xE0fQ7yYi jHKAakOQtjG6TtyNDFaLhfoa430IEBUX1WPuSmK3iTuf+NxDQZUpFPFoDCNctS3M4OIj l5EkBVAqxUTDHGE56ztgKDeIvDT27Bozv0ynjJ01rawhr9vS2eYXycKix1pZ4saMs3o6 xPGmp6QlfzNUOK5XKGdiCZbKdeaHnVfCvJrQDLCLfCoH+EALlD/0u61GdTO9e6NQH6j8 KerDdrMizbhOWW3xydiWQPlHAI40Cu617Bgy5cn3Uie5Dm63C6uknEz7w/WaiHO7XADV +O7g== X-Forwarded-Encrypted: i=1; AJvYcCX0eP8hqFy/rkbVNY/bo7MCUasC2yPze4h2LOYcAHPLI+SqHcC3nmUqeIYn9KLmCDu63DD7ojc=@vger.kernel.org X-Gm-Message-State: AOJu0YyAgl0G3XowM+co1KXIXfGJZ7PFhu/Z6o5q5KCShSgbtibbGeCA zr4HC5Iai6/rGHs+Lj9dRzUrgjugjQiqkFL7uE8z7j2DBei+YSfKDmUjr9qsBIENbxhwIE26SPp bX2aNIKfNfXhTiM7zk20nXiEVsgR8JzXmglbgzx1tayV/8mXJnYXNgF5Zpw== X-Gm-Gg: ATEYQzzaLYhxyD2QCwp94ddazPYi3hpNdWIELhS3bkXEkZ6z6D1Utnm6TmV5yGHjv/G Zx9LY0I6VVFJukl+ZQYZqOoO3D/rf6aVTFAHSSjy53Jw5mPzeDmRiCF1YTI1knXfwhvXFUd521o /EcxR/ws45RV8VmH8n5DGp9oDWsU1GppPQSpusqDbl7SIvOykjnbaq6dH6H4hBDd38+X6ugrOpQ nZFZ5ku9jZ6aS+Zli23hHd7CGKGNVP2jb8xr/IRlOh/k6pnearb1lAfTqIM/SmHS6ShqCEIx0mo dQ0LQ9kuXkpkhD2yxg6wjIFGsg2HqFEwq0+Sw9dzDqPUYkS+ru+jC5LQqoMbWkQSnEkRNE1xDCl Qm6iH3yis90HygjDd X-Received: by 2002:a05:600c:8718:b0:487:1c2:6a4f with SMTP id 5b1f17b1804b1-488835c0534mr45597775e9.31.1775031700287; Wed, 01 Apr 2026 01:21:40 -0700 (PDT) X-Received: by 2002:a05:600c:8718:b0:487:1c2:6a4f with SMTP id 5b1f17b1804b1-488835c0534mr45597015e9.31.1775031699827; Wed, 01 Apr 2026 01:21:39 -0700 (PDT) Received: from redhat.com ([2a0d:6fc0:1525:da00:3ac2:1a22:72ff:4256]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43cf21e29b1sm32050464f8f.8.2026.04.01.01.21.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 01:21:39 -0700 (PDT) Date: Wed, 1 Apr 2026 04:21:36 -0400 From: "Michael S. Tsirkin" To: Jakub Kicinski Cc: Paolo Abeni , Srujana Challa , "netdev@vger.kernel.org" , "virtualization@lists.linux.dev" , "jasowang@redhat.com" , "xuanzhuo@linux.alibaba.com" , "eperezma@redhat.com" , "davem@davemloft.net" , "edumazet@google.com" , Nithin Kumar Dabilpuram , Shiva Shankar Kommula , "stable@vger.kernel.org" Subject: Re: [EXTERNAL] Re: [PATCH net,v5] virtio_net: clamp rss_max_key_size to NETDEV_RSS_KEY_LEN Message-ID: <20260401042119-mutt-send-email-mst@kernel.org> References: <20260326142344.1171317-1-schalla@marvell.com> <68ca0a8c-27f9-45f1-94cc-7e3c7936181f@redhat.com> <20260331104737-mutt-send-email-mst@kernel.org> <20260331180522.64ef9886@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260331180522.64ef9886@kernel.org> On Tue, Mar 31, 2026 at 06:05:22PM -0700, Jakub Kicinski wrote: > On Tue, 31 Mar 2026 10:48:41 -0400 Michael S. Tsirkin wrote: > > > > Thank you for the feedback. In net-next, NETDEV_RSS_KEY_LEN is 256. This fix is > > > > also intended for stable kernels, where NETDEV_RSS_KEY_LEN is 52, and > > > > I added the message to make clamping visible in that case. > > > > I will remove the check and send the next version. > > > > > > I'm sorry, I haven't looked at the historical context when I wrote my > > > previous reply. > > > > > > IMHO the additional check does not make sense in the current net tree. > > > On the flip side stable trees will need it. I suggest: > > > > > > - dropping the check for the 'net' patch > > > - also dropping CC: stable tag > > > - explicitly sending to stable the fix variant including the size check. > > > > > > @Michael: WDYT? > > > > I was the one who suggested it, the extra check is harmless, I'm > > inclined to always have it. Less work than maintaining two patches. > > Give us an RB tag please and lets close this one? :) Oh I thought I did. Thanks.